Issue #3274474 by mondrake, longwave, andypost, Spokje, catch, alexpott: Fix...

Issue #3274474 by mondrake, longwave, andypost, Spokje, catch, alexpott: Fix 'Access to an undefined property' PHPStan L0 errors

core/lib/Drupal/Core/Cache/Context/CacheContextsManager.php

@@ -36,6 +36,11 @@ class CacheContextsManager {
    */
   protected $contexts;
 
+  /**
+   * The set of valid context tokens.
+   */
+  protected array $validContextTokens;
+
   /**
    * Constructs a CacheContextsManager object.
    *

core/lib/Drupal/Core/Cache/PhpBackend.php

@@ -3,8 +3,9 @@
 namespace Drupal\Core\Cache;
 
 use Drupal\Component\Assertion\Inspector;
-use Drupal\Core\PhpStorage\PhpStorageFactory;
+use Drupal\Component\PhpStorage\PhpStorageInterface;
 use Drupal\Component\Utility\Crypt;
+use Drupal\Core\PhpStorage\PhpStorageFactory;
 
 /**
  * Defines a PHP cache implementation.
@@ -26,6 +27,11 @@ class PhpBackend implements CacheBackendInterface {
    */
   protected $bin;
 
+  /**
+   * The PHP storage.
+   */
+  protected PhpStorageInterface $storage;
+
   /**
    * Array to store cache objects.
    */

core/lib/Drupal/Core/Config/Entity/Query/QueryFactory.php

@@ -39,6 +39,16 @@ class QueryFactory implements QueryFactoryInterface, EventSubscriberInterface {
    */
   protected $namespaces;
 
+  /**
+   * The key value factory.
+   */
+  protected KeyValueFactoryInterface $keyValueFactory;
+
+  /**
+   * The configuration manager.
+   */
+  protected ConfigManagerInterface $configManager;
+
   /**
    * Constructs a QueryFactory object.
    *

core/lib/Drupal/Core/Database/Query/Truncate.php

@@ -35,20 +35,6 @@ public function __construct(Connection $connection, $table, array $options = [])
     $this->table = $table;
   }
 
-  /**
-   * {@inheritdoc}
-   */
-  public function compile(Connection $connection, PlaceholderInterface $queryPlaceholder) {
-    return $this->condition->compile($connection, $queryPlaceholder);
-  }
-
-  /**
-   * {@inheritdoc}
-   */
-  public function compiled() {
-    return $this->condition->compiled();
-  }
-
   /**
    * Executes the TRUNCATE query.
    *

core/lib/Drupal/Core/Entity/Controller/EntityController.php

@@ -62,6 +62,11 @@ class EntityController implements ContainerInjectionInterface {
    */
   protected $renderer;
 
+  /**
+   * The url generator.
+   */
+  protected UrlGeneratorInterface $urlGenerator;
+
   /**
    * Constructs a new EntityController.
    *

core/lib/Drupal/Core/Entity/EntityResolverManager.php

@@ -28,6 +28,13 @@ class EntityResolverManager {
    */
   protected $classResolver;
 
+  /**
+   * The list of all entity types.
+   *
+   * @var \Drupal\Core\Entity\EntityTypeInterface[]
+   */
+  protected ?array $entityTypes;
+
   /**
    * Constructs a new EntityRouteAlterSubscriber.
    *

core/lib/Drupal/Core/Entity/Query/QueryBase.php

@@ -131,6 +131,11 @@ abstract class QueryBase implements QueryInterface {
    */
   protected $namespaces = [];
 
+  /**
+   * Defines how the conditions on the query need to match.
+   */
+  protected string $conjunction;
+
   /**
    * Constructs this object.
    *

core/lib/Drupal/Core/EventSubscriber/FinishResponseSubscriber.php

@@ -51,10 +51,8 @@ class FinishResponseSubscriber implements EventSubscriberInterface {
 
   /**
    * The cache contexts manager service.
-   *
-   * @var \Drupal\Core\Cache\Context\CacheContextsManager
    */
-  protected $cacheContexts;
+  protected CacheContextsManager $cacheContextsManager;
 
   /**
    * Whether to send cacheability headers for debugging purposes.

core/lib/Drupal/Core/EventSubscriber/RedirectResponseSubscriber.php

@@ -25,6 +25,11 @@ class RedirectResponseSubscriber implements EventSubscriberInterface {
    */
   protected $unroutedUrlAssembler;
 
+  /**
+   * The request context.
+   */
+  protected RequestContext $requestContext;
+
   /**
    * Constructs a RedirectResponseSubscriber object.
    *

core/lib/Drupal/Core/Field/Plugin/Field/FieldWidget/OptionsWidgetBase.php

@@ -30,6 +30,26 @@ abstract class OptionsWidgetBase extends WidgetBase {
    */
   protected $column;
 
+  /**
+   * Tracks whether the field is required.
+   */
+  protected bool $required;
+
+  /**
+   * Tracks whether the data is multi-valued.
+   */
+  protected bool $multiple;
+
+  /**
+   * Tracks whether the field has a value.
+   */
+  protected bool $has_value;
+
+  /**
+   * The array of options for the widget.
+   */
+  protected array $options;
+
   /**
    * {@inheritdoc}
    */

core/lib/Drupal/Core/Language/LanguageManager.php

@@ -32,6 +32,11 @@ class LanguageManager implements LanguageManagerInterface {
    */
   protected $defaultLanguage;
 
+  /**
+   * Information about all defined language types.
+   */
+  protected array $definedLanguageTypesInfo;
+
   /**
    * Constructs the language manager.
    *

core/lib/Drupal/Core/Template/TwigNodeVisitor.php

@@ -20,6 +20,11 @@
  */
 class TwigNodeVisitor extends AbstractNodeVisitor {
 
+  /**
+   * Tracks whether there is a render array aware filter active already.
+   */
+  protected ?bool $skipRenderVarFunction;
+
   /**
    * {@inheritdoc}
    */

core/lib/Drupal/Core/Test/PerformanceTestRecorder.php

@@ -16,10 +16,8 @@ class PerformanceTestRecorder implements EventSubscriberInterface {
 
   /**
    * The state service for persistent storage if necessary.
-   *
-   * @var \Drupal\Core\State\StateInterface
    */
-  protected $service;
+  protected ?StateInterface $state;
 
   /**
    * @var array

core/lib/Drupal/Core/TypedData/Validation/RecursiveContextualValidator.php

@@ -52,6 +52,11 @@ class RecursiveContextualValidator implements ContextualValidatorInterface {
    */
   protected $constraintValidatorFactory;
 
+  /**
+   * The typed data manager.
+   */
+  protected TypedDataManagerInterface $typedDataManager;
+
   /**
    * Creates a validator for the given context.
    *

core/lib/Drupal/Core/Updater/Updater.php

@@ -24,6 +24,16 @@ class Updater {
    */
   protected $root;
 
+  /**
+   * The name of the project directory (basename).
+   */
+  protected string $name;
+
+  /**
+   * The title of the project.
+   */
+  protected string $title;
+
   /**
    * Constructs a new updater.
    *

core/lib/Drupal/Core/Validation/ConstraintValidatorFactory.php

@@ -15,6 +15,11 @@
  */
 class ConstraintValidatorFactory extends BaseConstraintValidatorFactory {
 
+  /**
+   * The class resolver.
+   */
+  protected ClassResolverInterface $classResolver;
+
   /**
    * Constructs a new ConstraintValidatorFactory.
    *

core/modules/block/src/Plugin/migrate/process/BlockTheme.php

@@ -31,6 +31,11 @@ class BlockTheme extends ProcessPluginBase implements ContainerFactoryPluginInte
    */
   protected $themeConfig;
 
+  /**
+   * List of themes available on the destination.
+   */
+  protected array $themes;
+
   /**
    * Constructs a BlockTheme object.
    *

core/modules/block/tests/modules/block_test/src/Plugin/Block/TestAccessBlock.php

@@ -20,6 +20,11 @@
  */
 class TestAccessBlock extends BlockBase implements ContainerFactoryPluginInterface {
 
+  /**
+   * The state service.
+   */
+  protected StateInterface $state;
+
   /**
    * Tests the test access block.
    *

core/modules/comment/src/Plugin/views/field/StatisticsLastCommentName.php

@@ -15,6 +15,16 @@
  */
 class StatisticsLastCommentName extends FieldPluginBase {
 
+  /**
+   * The users table.
+   */
+  protected ?string $user_table;
+
+  /**
+   * The user name field.
+   */
+  protected string $user_field;
+
   /**
    * The user id.
    */

core/modules/comment/src/Plugin/views/field/StatisticsLastUpdated.php

@@ -13,6 +13,11 @@
  */
 class StatisticsLastUpdated extends Date {
 
+  /**
+   * The node table.
+   */
+  protected ?string $node_table;
+
   public function query() {
     $this->ensureMyTable();
     $this->node_table = $this->query->ensureTable('node_field_data', $this->relationship);