Skip to content
Snippets Groups Projects
Commit 3cf540af authored by catch's avatar catch
Browse files

Issue #3274474 by mondrake, longwave, andypost, Spokje, catch, alexpott: Fix...

Issue #3274474 by mondrake, longwave, andypost, Spokje, catch, alexpott: Fix 'Access to an undefined property' PHPStan L0 errors

(cherry picked from commit ffdecfad)
parent 2a147b02
No related branches found
No related tags found
18 merge requests!8506Draft: Issue #3456536 by ibrahim tameme,!5646Issue #3350972 by nod_: [random test failure]...,!5600Issue #3350972 by nod_: [random test failure]...,!5343Issue #3305066 by quietone, Rename RedirectLeadingSlashesSubscriber,!3603#ISSUE 3346218 Add a different message on edit comment,!3555Issue #2473873: Views entity operations lack cacheability support, resulting in incorrect dropbuttons,!3494Issue #3327018 by Spokje, longwave, xjm, mondrake: Update PHPStan to 1.9.3 and...,!3410Issue #3340128: UserLoginForm::submitForm has some dead code,!3389Issue #3325184 by Spokje, andypost, xjm, smustgrave: $this->configFactory is...,!3381Issue #3332363: Refactor Claro's menus-and-lists stylesheet,!3307Issue #3326193: CKEditor 5 can grow past the viewport when there is a lot of content,!3236Issue #3332419: Refactor Claro's messages stylesheet,!3231Draft: Issue #3049525 by longwave, fougere, larowlan, kim.pepper, AaronBauman, Wim...,!3212Issue #3294003: Refactor Claro's entity-meta stylesheet,!3194Issue #3330981: Fix PHPStan L1 error "Relying on entity queries to check access by default is deprecated...",!3143Issue #3313342: [PHP 8.1] Deprecated function: strpos(): Passing null to parameter #1 LayoutBuilderUiCacheContext.php on line 28,!2972Issue #1845004: Replace custom password hashing library with PHP 5.5 password_hash(),!2296Issue #3100732: Allow specifying `meta` data on JSON:API objects
Showing
with 121 additions and 21 deletions
......@@ -36,6 +36,11 @@ class CacheContextsManager {
*/
protected $contexts;
/**
* The set of valid context tokens.
*/
protected array $validContextTokens;
/**
* Constructs a CacheContextsManager object.
*
......
......@@ -3,8 +3,9 @@
namespace Drupal\Core\Cache;
use Drupal\Component\Assertion\Inspector;
use Drupal\Core\PhpStorage\PhpStorageFactory;
use Drupal\Component\PhpStorage\PhpStorageInterface;
use Drupal\Component\Utility\Crypt;
use Drupal\Core\PhpStorage\PhpStorageFactory;
/**
* Defines a PHP cache implementation.
......@@ -26,6 +27,11 @@ class PhpBackend implements CacheBackendInterface {
*/
protected $bin;
/**
* The PHP storage.
*/
protected PhpStorageInterface $storage;
/**
* Array to store cache objects.
*/
......
......@@ -39,6 +39,16 @@ class QueryFactory implements QueryFactoryInterface, EventSubscriberInterface {
*/
protected $namespaces;
/**
* The key value factory.
*/
protected KeyValueFactoryInterface $keyValueFactory;
/**
* The configuration manager.
*/
protected ConfigManagerInterface $configManager;
/**
* Constructs a QueryFactory object.
*
......
......@@ -35,20 +35,6 @@ public function __construct(Connection $connection, $table, array $options = [])
$this->table = $table;
}
/**
* {@inheritdoc}
*/
public function compile(Connection $connection, PlaceholderInterface $queryPlaceholder) {
return $this->condition->compile($connection, $queryPlaceholder);
}
/**
* {@inheritdoc}
*/
public function compiled() {
return $this->condition->compiled();
}
/**
* Executes the TRUNCATE query.
*
......
......@@ -62,6 +62,11 @@ class EntityController implements ContainerInjectionInterface {
*/
protected $renderer;
/**
* The url generator.
*/
protected UrlGeneratorInterface $urlGenerator;
/**
* Constructs a new EntityController.
*
......
......@@ -28,6 +28,13 @@ class EntityResolverManager {
*/
protected $classResolver;
/**
* The list of all entity types.
*
* @var \Drupal\Core\Entity\EntityTypeInterface[]
*/
protected ?array $entityTypes;
/**
* Constructs a new EntityRouteAlterSubscriber.
*
......
......@@ -131,6 +131,11 @@ abstract class QueryBase implements QueryInterface {
*/
protected $namespaces = [];
/**
* Defines how the conditions on the query need to match.
*/
protected string $conjunction;
/**
* Constructs this object.
*
......
......@@ -51,10 +51,8 @@ class FinishResponseSubscriber implements EventSubscriberInterface {
/**
* The cache contexts manager service.
*
* @var \Drupal\Core\Cache\Context\CacheContextsManager
*/
protected $cacheContexts;
protected CacheContextsManager $cacheContextsManager;
/**
* Whether to send cacheability headers for debugging purposes.
......
......@@ -25,6 +25,11 @@ class RedirectResponseSubscriber implements EventSubscriberInterface {
*/
protected $unroutedUrlAssembler;
/**
* The request context.
*/
protected RequestContext $requestContext;
/**
* Constructs a RedirectResponseSubscriber object.
*
......
......@@ -30,6 +30,26 @@ abstract class OptionsWidgetBase extends WidgetBase {
*/
protected $column;
/**
* Tracks whether the field is required.
*/
protected bool $required;
/**
* Tracks whether the data is multi-valued.
*/
protected bool $multiple;
/**
* Tracks whether the field has a value.
*/
protected bool $has_value;
/**
* The array of options for the widget.
*/
protected array $options;
/**
* {@inheritdoc}
*/
......
......@@ -32,6 +32,11 @@ class LanguageManager implements LanguageManagerInterface {
*/
protected $defaultLanguage;
/**
* Information about all defined language types.
*/
protected array $definedLanguageTypesInfo;
/**
* Constructs the language manager.
*
......
......@@ -20,6 +20,11 @@
*/
class TwigNodeVisitor extends AbstractNodeVisitor {
/**
* Tracks whether there is a render array aware filter active already.
*/
protected ?bool $skipRenderVarFunction;
/**
* {@inheritdoc}
*/
......
......@@ -16,10 +16,8 @@ class PerformanceTestRecorder implements EventSubscriberInterface {
/**
* The state service for persistent storage if necessary.
*
* @var \Drupal\Core\State\StateInterface
*/
protected $service;
protected ?StateInterface $state;
/**
* @var array
......
......@@ -52,6 +52,11 @@ class RecursiveContextualValidator implements ContextualValidatorInterface {
*/
protected $constraintValidatorFactory;
/**
* The typed data manager.
*/
protected TypedDataManagerInterface $typedDataManager;
/**
* Creates a validator for the given context.
*
......
......@@ -24,6 +24,16 @@ class Updater {
*/
protected $root;
/**
* The name of the project directory (basename).
*/
protected string $name;
/**
* The title of the project.
*/
protected string $title;
/**
* Constructs a new updater.
*
......
......@@ -15,6 +15,11 @@
*/
class ConstraintValidatorFactory extends BaseConstraintValidatorFactory {
/**
* The class resolver.
*/
protected ClassResolverInterface $classResolver;
/**
* Constructs a new ConstraintValidatorFactory.
*
......
......@@ -31,6 +31,11 @@ class BlockTheme extends ProcessPluginBase implements ContainerFactoryPluginInte
*/
protected $themeConfig;
/**
* List of themes available on the destination.
*/
protected array $themes;
/**
* Constructs a BlockTheme object.
*
......
......@@ -20,6 +20,11 @@
*/
class TestAccessBlock extends BlockBase implements ContainerFactoryPluginInterface {
/**
* The state service.
*/
protected StateInterface $state;
/**
* Tests the test access block.
*
......
......@@ -15,6 +15,16 @@
*/
class StatisticsLastCommentName extends FieldPluginBase {
/**
* The users table.
*/
protected ?string $user_table;
/**
* The user name field.
*/
protected string $user_field;
/**
* The user id.
*/
......
......@@ -13,6 +13,11 @@
*/
class StatisticsLastUpdated extends Date {
/**
* The node table.
*/
protected ?string $node_table;
public function query() {
$this->ensureMyTable();
$this->node_table = $this->query->ensureTable('node_field_data', $this->relationship);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment