Skip to content
Snippets Groups Projects

Issue #3294003: Refactor Claro's entity-meta stylesheet

Closed Issue #3294003: Refactor Claro's entity-meta stylesheet
issue/drupal-3294003:3294003-refactor-claros-entity-meta into 10.1.x
3 unresolved threads
Closed Ben Speare requested to merge issue/drupal-3294003:3294003-refactor-claros-entity-meta into 10.1.x
3 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/themes/claro/css/components/entity-meta.pcss.css
3 3 * Entity meta.
  • Mike Herchel
    Mike Herchel @mherchel
    Developer

    Add a comment here to indicate what this component is and where it can be found. I had to search the codebase to find out it's the right hand sidebar of the node/add form.

  • Please register or sign in to reply
  • Mike Herchel
    Mike Herchel @mherchel started a thread on an old version of the diff
    • core/themes/claro/css/components/entity-meta.pcss.css
    11 --entity-meta-color-bg: var(--color-bg);
    12 --entity-meta-color-white: var(--color-white);
    13 --entity-meta-border-size: var(--details-border-size);
    14 --entity-meta-border-color: var(--details-border-color);
    15 --entity-meta-border-size-radius: var(--details-accordion-border-size-radius);
    16 --entity-meta-font-size-base: var(--font-size-base);
    17
    18 padding: calc(var(--entity-meta-spacing-m) - var(--entity-meta-spacing-xs)) var(--entity-meta-spacing-m) calc(var(--entity-meta-spacing-l) - var(--entity-meta-spacing-xs));
    19 color: var(--entity-meta-color-fg);
    20 border: var(--entity-meta-border-size) solid var(--entity-meta-border-color);
    21 border-radius: var(--entity-meta-border-size-radius);
    22 background-color: var(--entity-meta-color-bg);
    23
    24 & .form-item {
    25 margin-block-start: var(--entity-meta-spacing-xs);
    26 margin-block-end: var(--entity-meta-spacing-xs);
  • Mike Herchel
    Mike Herchel @mherchel started a thread on the diff
    • core/themes/claro/css/components/entity-meta.pcss.css
    6 :root {
    7 --size-entity-meta-spacing: var(--space-xs);
    8 }
    9
    10 6 .entity-meta__header {
    11 padding: calc(var(--space-m) - var(--size-entity-meta-spacing)) var(--space-m) calc(var(--space-l) - var(--size-entity-meta-spacing));
    12 color: var(--color-fg);
    13 border: var(--details-border-size) solid var(--details-border-color);
    14 border-radius: var(--details-accordion-border-size-radius);
    15 background-color: var(--color-bg);
    16 }
    17
    18 @media screen and (min-width: 48em) {
    19 .entity-meta__header {
    20 padding: calc(var(--space-l) - var(--size-entity-meta-spacing)) var(--space-l) var(--space-l);
    7 --entity-meta-spacing-xs: var(--space-xs);
    • Mike Herchel
      Mike Herchel @mherchel
      Developer

      Because these CSS variables are namespaced with --entity-meta, lets attach them to the .entity-meta selector (which exists within the markup, but not yet within the CSS).

    • Please register or sign in to reply
  • Gaurav added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Speare changed the description

    changed the description

  • Ben Speare changed target branch from 10.0.x to 10.1.x

    changed target branch from 10.0.x to 10.1.x

  • Ben Speare changed target branch from 10.1.x to 10.0.x

    changed target branch from 10.1.x to 10.0.x

  • Ben Speare changed target branch from 10.0.x to 10.1.x

    changed target branch from 10.0.x to 10.1.x

  • Ben Speare
    Ben Speare @bspeare
    Author

    I had some issues with the rebase on this MR, so I opened a new one at !3284 (closed) with the requested changes.

  • Ben Speare closed

    closed

    • Please register or sign in to reply