Skip to content
Snippets Groups Projects
Commit 43e4c4a8 authored by catch's avatar catch
Browse files

Issue #3316960 by mondrake: Fix PageRenderTest PHPStan L0 issues

parent 6dcb9151
No related branches found
No related tags found
36 merge requests!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!4289Issue #1344552 by marcingy, Niklas Fiekas, Ravi.J, aleevas, Eduardo Morales...,!4114Issue #2707291: Disable body-level scrolling when a dialog is open as a modal,!4100Issue #3249600: Add support for PHP 8.1 Enums as allowed values for list_* data types,!3630Issue #2815301 by Chi, DanielVeza, kostyashupenko, smustgrave: Allow to create...,!3600Issue #3344629: Passing null to parameter #1 ($haystack) of type string is deprecated,!3291Issue #3336463: Rewrite rules for gzipped CSS and JavaScript aggregates never match,!3102Issue #3164428 by DonAtt, longwave, sahil.goyal, Anchal_gupta, alexpott: Use...,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2074Issue #2707689: NodeForm::actions() checks for delete access on new entities,!2062Issue #3246454: Add weekly granularity to views date sort,!1591Issue #3199697: Add JSON:API Translation experimental module,!1484Exposed filters get values from URL when Ajax is on,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1254Issue #3238915: Refactor (if feasible) uses of the jQuery ready function to use VanillaJS,!1162Issue #3100350: Unable to save '/' root path alias,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!957Added throwing of InvalidPluginDefinitionException from getDefinition().,!925Issue #2339235: Remove taxonomy hard dependency on node module,!877Issue #2708101: Default value for link text is not saved,!873Issue #2875228: Site install not using batch API service,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!844Resolve #3036010 "Updaters",!712Issue #2909128: Autocomplete intermittent on Chrome Android,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
Hide whitespace changes
Inline Side-by-side
core/modules/system/tests/src/Kernel/Common/PageRenderTest.php
+ 2
− 2
View file @ 43e4c4a8
...@@ -56,7 +56,7 @@ public function assertPageRenderHookExceptions(string $module, string $hook): vo ...@@ -56,7 +56,7 @@ public function assertPageRenderHookExceptions(string $module, string $hook): vo
$page = []; $page = [];
try { try {
$html_renderer->invokePageAttachmentHooks($page); $html_renderer->invokePageAttachmentHooks($page);
$this->error($assertion); $this->fail($assertion);
} }
catch (\LogicException $e) { catch (\LogicException $e) {
$this->assertEquals('Only #attached and #cache may be set in ' . $hook . '().', $e->getMessage()); $this->assertEquals('Only #attached and #cache may be set in ' . $hook . '().', $e->getMessage());
...@@ -69,7 +69,7 @@ public function assertPageRenderHookExceptions(string $module, string $hook): vo ...@@ -69,7 +69,7 @@ public function assertPageRenderHookExceptions(string $module, string $hook): vo
$page = []; $page = [];
try { try {
$html_renderer->invokePageAttachmentHooks($page); $html_renderer->invokePageAttachmentHooks($page);
$this->error($assertion); $this->fail($assertion);
} }
catch (\LogicException $e) { catch (\LogicException $e) {
$this->assertEquals('Only #attached and #cache may be set in ' . $hook . '().', $e->getMessage()); $this->assertEquals('Only #attached and #cache may be set in ' . $hook . '().', $e->getMessage());
......
core/phpstan-baseline.neon
+ 0
− 5
View file @ 43e4c4a8
...@@ -1115,11 +1115,6 @@ parameters: ...@@ -1115,11 +1115,6 @@ parameters:
count: 1 count: 1
path: modules/system/tests/src/Functional/FileTransfer/FileTransferTest.php path: modules/system/tests/src/Functional/FileTransfer/FileTransferTest.php
-
message: "#^Call to an undefined method Drupal\\\\Tests\\\\system\\\\Kernel\\\\Common\\\\PageRenderTest\\:\\:error\\(\\)\\.$#"
count: 2
path: modules/system/tests/src/Kernel/Common/PageRenderTest.php
- -
message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#"
count: 1 count: 1
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment