From 43e4c4a853f25935a34fa82c0dc556d450be727d Mon Sep 17 00:00:00 2001
From: catch <catch56@gmail.com>
Date: Mon, 24 Oct 2022 15:23:17 +0100
Subject: [PATCH] Issue #3316960 by mondrake: Fix PageRenderTest PHPStan L0
issues
---
.../system/tests/src/Kernel/Common/PageRenderTest.php | 4 ++--
core/phpstan-baseline.neon | 5 -----
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/core/modules/system/tests/src/Kernel/Common/PageRenderTest.php b/core/modules/system/tests/src/Kernel/Common/PageRenderTest.php
index a7842b480a87..616c3037cd13 100644
--- a/core/modules/system/tests/src/Kernel/Common/PageRenderTest.php
+++ b/core/modules/system/tests/src/Kernel/Common/PageRenderTest.php
@@ -56,7 +56,7 @@ public function assertPageRenderHookExceptions(string $module, string $hook): vo
$page = [];
try {
$html_renderer->invokePageAttachmentHooks($page);
- $this->error($assertion);
+ $this->fail($assertion);
}
catch (\LogicException $e) {
$this->assertEquals('Only #attached and #cache may be set in ' . $hook . '().', $e->getMessage());
@@ -69,7 +69,7 @@ public function assertPageRenderHookExceptions(string $module, string $hook): vo
$page = [];
try {
$html_renderer->invokePageAttachmentHooks($page);
- $this->error($assertion);
+ $this->fail($assertion);
}
catch (\LogicException $e) {
$this->assertEquals('Only #attached and #cache may be set in ' . $hook . '().', $e->getMessage());
diff --git a/core/phpstan-baseline.neon b/core/phpstan-baseline.neon
index eed79b4d4b31..10ac55102806 100644
--- a/core/phpstan-baseline.neon
+++ b/core/phpstan-baseline.neon
@@ -1115,11 +1115,6 @@ parameters:
count: 1
path: modules/system/tests/src/Functional/FileTransfer/FileTransferTest.php
- -
- message: "#^Call to an undefined method Drupal\\\\Tests\\\\system\\\\Kernel\\\\Common\\\\PageRenderTest\\:\\:error\\(\\)\\.$#"
- count: 2
- path: modules/system/tests/src/Kernel/Common/PageRenderTest.php
-
-
message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#"
count: 1
--
GitLab