Skip to content
Snippets Groups Projects
Commit feab11e4 authored by catch's avatar catch
Browse files

Issue #2986962 by fjgarlin, ppseftogiannis, smustgrave, Sut3kh:...

Issue #2986962 by fjgarlin, ppseftogiannis, smustgrave, Sut3kh: BrowserTestBase::drupalGet() does not appear to be handling base url properly
parent a55e653e
No related branches found
Tags 11-44488
42 merge requests!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!3878Removed unused condition head title for views,!38582585169-10.1.x,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3668Resolve #3347842 "Deprecate the trusted",!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3546refactored dialog.pcss file,!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3502Issue #3335308: Confusing behavior with FormState::setFormState and FormState::setMethod,!3452Issue #3332701: Refactor Claro's tablesort-indicator stylesheet,!3451Issue #2410579: Allows setting the current language programmatically.,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3226Issue #2987537: Custom menu link entity type should not declare "bundle" entity key,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3147Issue #3328457: Replace most substr($a, $i) where $i is negative with str_ends_with(),!3146Issue #3328456: Replace substr($a, 0, $i) with str_starts_with(),!3133core/modules/system/css/components/hidden.module.css,!31312878513-10.1.x,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2614Issue #2981326: Replace non-test usages of \Drupal::logger() with IoC injection,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2062Issue #3246454: Add weekly granularity to views date sort,!1591Issue #3199697: Add JSON:API Translation experimental module,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!844Resolve #3036010 "Updaters",!673Issue #3214208: FinishResponseSubscriber could create duplicate headers,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
...@@ -272,6 +272,8 @@ protected function drupalGet($path, array $options = [], array $headers = []) { ...@@ -272,6 +272,8 @@ protected function drupalGet($path, array $options = [], array $headers = []) {
* An absolute URL string. * An absolute URL string.
*/ */
protected function buildUrl($path, array $options = []) { protected function buildUrl($path, array $options = []) {
global $base_path;
if ($path instanceof Url) { if ($path instanceof Url) {
$url_options = $path->getOptions(); $url_options = $path->getOptions();
$options = $url_options + $options; $options = $url_options + $options;
...@@ -281,6 +283,12 @@ protected function buildUrl($path, array $options = []) { ...@@ -281,6 +283,12 @@ protected function buildUrl($path, array $options = []) {
// The URL generator service is not necessarily available yet; e.g., in // The URL generator service is not necessarily available yet; e.g., in
// interactive installer tests. // interactive installer tests.
elseif (\Drupal::hasService('url_generator')) { elseif (\Drupal::hasService('url_generator')) {
// Strip $base_path, if existent.
$length = strlen($base_path);
if (substr($path, 0, $length) === $base_path) {
$path = substr($path, $length);
}
$force_internal = isset($options['external']) && $options['external'] == FALSE; $force_internal = isset($options['external']) && $options['external'] == FALSE;
if (!$force_internal && UrlHelper::isExternal($path)) { if (!$force_internal && UrlHelper::isExternal($path)) {
return Url::fromUri($path, $options)->toString(); return Url::fromUri($path, $options)->toString();
......
  • catch @catch

    mentioned in commit 4ec03b57

    ·

    mentioned in commit 4ec03b57

    Toggle commit list
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment