Issue #3295157 by mondrake: Fix 'Access to an undefined property' PHPStan L0...

Issue #3295157 by mondrake: Fix 'Access to an undefined property' PHPStan L0 errors - public properties

core/lib/Drupal/Core/Database/Query/Select.php

@@ -118,6 +118,16 @@ class Select extends Query implements SelectInterface {
    */
   protected $forUpdate = FALSE;
 
+  /**
+   * The query metadata for alter purposes.
+   */
+  public array $alterMetaData;
+
+  /**
+   * The query tags.
+   */
+  public array $alterTags;
+
   /**
    * Constructs a Select object.
    *

core/lib/Drupal/Core/Extension/Extension.php

@@ -49,6 +49,11 @@ class Extension {
    */
   protected $root;
 
+  /**
+   * The extension info array.
+   */
+  public array $info;
+
   /**
    * Constructs a new Extension object.
    *

core/lib/Drupal/Core/Field/Entity/BaseFieldOverride.php

@@ -49,6 +49,11 @@ class BaseFieldOverride extends FieldConfigBase {
    */
   protected $baseFieldDefinition;
 
+  /**
+   * The original override.
+   */
+  public BaseFieldOverride $original;
+
   /**
    * Creates a base field override object.
    *

core/modules/comment/src/Plugin/views/field/StatisticsLastCommentName.php

@@ -15,6 +15,11 @@
  */
 class StatisticsLastCommentName extends FieldPluginBase {
 
+  /**
+   * The user id.
+   */
+  public string $uid;
+
   /**
    * {@inheritdoc}
    */

core/modules/comment/src/Plugin/views/row/Rss.php

@@ -27,7 +27,12 @@ class Rss extends RssPluginBase {
   /**
    * {@inheritdoc}
    */
-  protected $base_field = 'cid';
+  public string $base_field = 'cid';
+
+  /**
+   * The field alias.
+   */
+  public string $field_alias;
 
   /**
    * @var \Drupal\comment\CommentInterface[]

core/modules/field/src/Entity/FieldConfig.php

@@ -71,6 +71,11 @@ class FieldConfig extends FieldConfigBase implements FieldConfigInterface {
    */
   protected $fieldStorage;
 
+  /**
+   * The original FieldConfig entity.
+   */
+  public FieldConfig $original;
+
   /**
    * Constructs a FieldConfig object.
    *

core/modules/field/src/Entity/FieldStorageConfig.php

@@ -229,6 +229,11 @@ class FieldStorageConfig extends ConfigEntityBase implements FieldStorageConfigI
    */
   protected static $inDeletion = FALSE;
 
+  /**
+   * Copy of the field before changes.
+   */
+  public FieldStorageConfigInterface $original;
+
   /**
    * Constructs a FieldStorageConfig object.
    *

core/modules/node/src/Plugin/views/row/Rss.php

@@ -29,10 +29,8 @@ class Rss extends RssPluginBase {
 
   /**
    * The base field for this row plugin.
-   *
-   * @var string
    */
-  public $base_field = 'nid';
+  public string $base_field = 'nid';
 
   /**
    * Stores the nodes loaded with preRender.

core/modules/search/src/Plugin/views/argument/Search.php

@@ -31,6 +31,11 @@ class Search extends ArgumentPluginBase {
    */
   protected $searchType;
 
+  /**
+   * The search score.
+   */
+  public string $search_score;
+
   /**
    * {@inheritdoc}
    */

core/modules/search/src/Plugin/views/filter/Search.php

@@ -46,6 +46,11 @@ class Search extends FilterPluginBase {
    */
   protected $searchType;
 
+  /**
+   * The search score.
+   */
+  public string $search_score;
+
   /**
    * {@inheritdoc}
    */

core/modules/views/src/ManyToOneHelper.php

@@ -4,6 +4,7 @@
 
 use Drupal\Core\Form\FormStateInterface;
 use Drupal\views\Plugin\views\HandlerBase;
+use Drupal\views\Plugin\views\ViewsHandlerInterface;
 
 /**
  * This many to one helper object is used on both arguments and filters.
@@ -20,6 +21,11 @@
  */
 class ManyToOneHelper {
 
+  /**
+   * The handler.
+   */
+  public ViewsHandlerInterface $handler;
+
   public function __construct($handler) {
     $this->handler = $handler;
   }
@@ -140,7 +146,7 @@ public function summaryJoin() {
               'field' => $this->handler->realField,
               'operator' => '!=',
               'value' => $value,
-              'numeric' => !empty($this->definition['numeric']),
+              'numeric' => !empty($this->handler->definition['numeric']),
             ],
           ];
         }

core/modules/views/src/Plugin/views/HandlerBase.php

@@ -80,6 +80,11 @@ abstract class HandlerBase extends PluginBase implements ViewsHandlerInterface {
    */
   protected $viewsData;
 
+  /**
+   * Tracks whether the plugin is a handler.
+   */
+  public bool $is_handler;
+
   /**
    * Constructs a Handler object.
    *

core/modules/views/src/Plugin/views/argument/ArgumentPluginBase.php

@@ -65,6 +65,11 @@ abstract class ArgumentPluginBase extends HandlerBase implements CacheableDepend
    */
   public $name_table;
 
+  /**
+   * The name table alias.
+   */
+  public string $name_table_alias;
+
   /**
    * The field to use for the name to use in the summary, which is
    * the displayed output. For example, for the node: nid argument,
@@ -73,6 +78,41 @@ abstract class ArgumentPluginBase extends HandlerBase implements CacheableDepend
    */
   public $name_field;
 
+  /**
+   * The alias for the field.
+   */
+  public string $name_alias;
+
+  /**
+   * The base table alias.
+   */
+  public string $base_alias;
+
+  /**
+   * The alias count.
+   */
+  public string $count_alias;
+
+  /**
+   * Is argument validated.
+   */
+  public ?bool $argument_validated;
+
+  /**
+   * Is argument a default.
+   */
+  public bool $is_default;
+
+  /**
+   * The operator used for the query: or|and.
+   */
+  public string $operator;
+
+  /**
+   * The argument position.
+   */
+  public int $position;
+
   /**
    * Overrides Drupal\views\Plugin\views\HandlerBase:init().
    */

core/modules/views/src/Plugin/views/argument/ManyToOne.php

@@ -24,6 +24,11 @@
  */
 class ManyToOne extends ArgumentPluginBase {
 
+  /**
+   * The many-to-one helper.
+   */
+  public ManyToOneHelper $helper;
+
   /**
    * {@inheritdoc}
    */

core/modules/views/src/Plugin/views/argument/NumericArgument.php

@@ -15,12 +15,6 @@
  */
 class NumericArgument extends ArgumentPluginBase {
 
-  /**
-   * The operator used for the query: or|and.
-   * @var string
-   */
-  public $operator;
-
   /**
    * The actual value which is used for querying.
    * @var array

core/modules/views/src/Plugin/views/argument/StringArgument.php

@@ -19,6 +19,11 @@
  */
 class StringArgument extends ArgumentPluginBase {
 
+  /**
+   * The many-to-one helper.
+   */
+  public ManyToOneHelper $helper;
+
   /**
    * {@inheritdoc}
    */

core/modules/views/src/Plugin/views/argument_default/ArgumentDefaultPluginBase.php

@@ -37,6 +37,11 @@ abstract class ArgumentDefaultPluginBase extends PluginBase {
    */
   protected $argument;
 
+  /**
+   * The option name.
+   */
+  public string $option_name;
+
   /**
    * Return the default argument.
    *

core/modules/views/src/Plugin/views/argument_validator/ArgumentValidatorPluginBase.php

@@ -40,6 +40,11 @@ abstract class ArgumentValidatorPluginBase extends PluginBase {
    */
   protected $argument;
 
+  /**
+   * The option name.
+   */
+  public string $option_name;
+
   /**
    * Sets the parent argument this plugin is associated with.
    *

core/modules/views/src/Plugin/views/display/DisplayPluginBase.php

@@ -122,6 +122,16 @@ abstract class DisplayPluginBase extends PluginBase implements DisplayPluginInte
    */
   public $display;
 
+  /**
+   * Keeps track whether the display uses exposed filters.
+   */
+  public bool $has_exposed;
+
+  /**
+   * The default display.
+   */
+  public DisplayPluginInterface $default_display;
+
   /**
    * Constructs a new DisplayPluginBase object.
    *

core/modules/views/src/Plugin/views/display/EntityReference.php

@@ -49,6 +49,11 @@ class EntityReference extends DisplayPluginBase {
    */
   protected $connection;
 
+  /**
+   * The id field alias.
+   */
+  public string $id_field_alias;
+
   /**
    * Constructs a new EntityReference object.
    *