Issue #2254189 by smustgrave, quietone, anya_m, andregp, sun, joachim: Fix...

Issue #2254189 by smustgrave, quietone, anya_m, andregp, sun, joachim: Fix test performance of Drupal\node\Tests\NodeTranslationUITest

core/modules/block_content/tests/src/Functional/BlockContentTranslationUITest.php

@@ -51,6 +51,7 @@ protected function setUp(): void {
     $this->bundle = 'basic';
     $this->testLanguageSelector = FALSE;
     parent::setUp();
+    $this->doSetup();
 
     $this->drupalPlaceBlock('page_title_block');
   }

core/modules/comment/tests/src/Functional/CommentTranslationUITest.php

@@ -71,6 +71,7 @@ protected function setUp(): void {
     $this->testLanguageSelector = FALSE;
     $this->subject = $this->randomMachineName();
     parent::setUp();
+    $this->doSetup();
   }
 
   /**

core/modules/content_translation/tests/src/Functional/ContentTestTranslationUITest.php

@@ -48,6 +48,7 @@ protected function setUp(): void {
     // Use the entity_test_mul as this has multilingual property support.
     $this->entityTypeId = 'entity_test_mul_changed';
     parent::setUp();
+    $this->doSetup();
   }
 
   /**

core/modules/content_translation/tests/src/Functional/ContentTranslationMetadataFieldsTest.php

@@ -43,6 +43,14 @@ protected function setupBundle() {
     $this->createContentType(['type' => $this->bundle]);
   }
 
+  /**
+   * {@inheritdoc}
+   */
+  protected function setUp(): void {
+    parent::setUp();
+    $this->doSetup();
+  }
+
   /**
    * Tests skipping setting non translatable metadata fields.
    */

core/modules/content_translation/tests/src/Functional/ContentTranslationNewTranslationWithExistingRevisionsTest.php

@@ -33,6 +33,7 @@ class ContentTranslationNewTranslationWithExistingRevisionsTest extends ContentT
    */
   protected function setUp(): void {
     parent::setUp();
+    $this->doSetup();
     $this->enableContentModeration();
   }
 

core/modules/content_translation/tests/src/Functional/ContentTranslationOutdatedRevisionTranslationTest.php

@@ -22,6 +22,7 @@ class ContentTranslationOutdatedRevisionTranslationTest extends ContentTranslati
    */
   protected function setUp(): void {
     parent::setUp();
+    $this->doSetup();
     $this->enableContentModeration();
   }
 

core/modules/content_translation/tests/src/Functional/ContentTranslationRevisionTranslationDeletionTest.php

@@ -22,6 +22,7 @@ class ContentTranslationRevisionTranslationDeletionTest extends ContentTranslati
    */
   protected function setUp(): void {
     parent::setUp();
+    $this->doSetup();
     $this->enableContentModeration();
   }
 

core/modules/content_translation/tests/src/Functional/ContentTranslationSyncImageTest.php

@@ -57,6 +57,7 @@ class ContentTranslationSyncImageTest extends ContentTranslationTestBase {
    */
   protected function setUp(): void {
     parent::setUp();
+    $this->doSetup();
     $this->files = $this->drupalGetTestFiles('image');
   }
 

core/modules/content_translation/tests/src/Functional/ContentTranslationTestBase.php

@@ -83,11 +83,9 @@ abstract class ContentTranslationTestBase extends BrowserTestBase {
   protected $manager;
 
   /**
-   * {@inheritdoc}
+   * Completes preparation for content translation tests.
    */
-  protected function setUp(): void {
-    parent::setUp();
-
+  protected function doSetup(): void {
     $this->setupLanguages();
     $this->setupBundle();
     $this->enableTranslation();

core/modules/content_translation/tests/src/Functional/ContentTranslationUntranslatableFieldsTest.php

@@ -32,6 +32,7 @@ class ContentTranslationUntranslatableFieldsTest extends ContentTranslationPendi
    */
   protected function setUp(): void {
     parent::setUp();
+    $this->doSetup();
 
     // Configure one field as untranslatable.
     $this->drupalLogin($this->administrator);

core/modules/content_translation/tests/src/Functional/ContentTranslationWorkflowsTest.php

@@ -74,6 +74,7 @@ class ContentTranslationWorkflowsTest extends ContentTranslationTestBase {
    */
   protected function setUp(): void {
     parent::setUp();
+    $this->doSetup();
 
     $field_storage = FieldStorageConfig::create([
       'field_name' => 'field_reference',

core/modules/content_translation/tests/src/Functional/Views/TranslationLinkTest.php

@@ -42,6 +42,7 @@ protected function setUp(): void {
     $this->entityTypeId = 'user';
 
     parent::setUp();
+    $this->doSetup();
 
     // Assign user 1  a language code so that the entity can be translated.
     $user = User::load(1);

core/modules/layout_builder/tests/src/Functional/LayoutBuilderTranslationTest.php

@@ -41,6 +41,7 @@ class LayoutBuilderTranslationTest extends ContentTranslationTestBase {
    */
   protected function setUp(): void {
     parent::setUp();
+    $this->doSetup();
     $this->setUpViewDisplay();
     $this->setUpEntities();
   }

core/modules/media/tests/src/Functional/MediaTranslationUITest.php

@@ -49,6 +49,7 @@ protected function setUp(): void {
     $this->entityTypeId = 'media';
     $this->bundle = 'test';
     parent::setUp();
+    $this->doSetup();
   }
 
   /**

core/modules/menu_link_content/tests/src/Functional/MenuLinkContentTranslationUITest.php

@@ -41,6 +41,7 @@ protected function setUp(): void {
     $this->entityTypeId = 'menu_link_content';
     $this->bundle = 'menu_link_content';
     parent::setUp();
+    $this->doSetup();
   }
 
   /**

core/modules/node/tests/src/Functional/NodeTranslationUITest.php

@@ -3,12 +3,18 @@
 namespace Drupal\Tests\node\Functional;
 
 use Drupal\Core\Entity\EntityInterface;
+use Drupal\Core\Entity\Entity\EntityFormDisplay;
 use Drupal\Core\Language\LanguageInterface;
 use Drupal\Core\Url;
 use Drupal\Tests\content_translation\Functional\ContentTranslationUITestBase;
 use Drupal\Tests\language\Traits\LanguageTestTrait;
+use Drupal\comment\Tests\CommentTestTrait;
+use Drupal\field\Entity\FieldConfig;
+use Drupal\field\Entity\FieldStorageConfig;
 use Drupal\language\Entity\ConfigurableLanguage;
 use Drupal\node\Entity\Node;
+use Drupal\user\Entity\Role;
+use Drupal\user\RoleInterface;
 
 /**
  * Tests the Node Translation UI.
@@ -19,6 +25,7 @@
 class NodeTranslationUITest extends ContentTranslationUITestBase {
 
   use LanguageTestTrait;
+  use CommentTestTrait;
 
   /**
    * {@inheritdoc}
@@ -29,18 +36,11 @@ class NodeTranslationUITest extends ContentTranslationUITestBase {
    * {@inheritdoc}
    */
   protected $defaultCacheContexts = [
-    'languages:language_interface',
     'theme',
-    'route',
     'timezone',
-    'url.path.parent',
     'url.query_args:_wrapper_format',
     'url.site',
-    'user.roles',
-    'url.path.is_front',
-    // These two cache contexts are added by BigPipe.
-    'cookies:big_pipe_nojs',
-    'session.exists',
+    'user.permissions',
   ];
 
   /**
@@ -53,18 +53,9 @@ class NodeTranslationUITest extends ContentTranslationUITestBase {
     'language',
     'content_translation',
     'node',
-    'datetime',
     'field_ui',
-    'help',
   ];
 
-  /**
-   * The profile to install as a basis for testing.
-   *
-   * @var string
-   */
-  protected $profile = 'standard';
-
   /**
    * {@inheritdoc}
    */
@@ -73,6 +64,10 @@ protected function setUp(): void {
     $this->bundle = 'article';
     parent::setUp();
 
+    // Create the bundle.
+    $this->drupalCreateContentType(['type' => 'article', 'title' => 'Article']);
+    $this->doSetup();
+
     // Ensure the help message is shown even with prefixed paths.
     $this->drupalPlaceBlock('help_block', ['region' => 'content']);
 
@@ -99,10 +94,6 @@ public function testPublishedStatusNoFields() {
     $this->drupalGet('admin/structure/types/manage/article/fields');
     $this->drupalGet('admin/structure/types/manage/article/fields/node.article.' . $this->fieldName . '/delete');
     $this->submitForm([], 'Delete');
-    $this->drupalGet('admin/structure/types/manage/article/fields/node.article.field_tags/delete');
-    $this->submitForm([], 'Delete');
-    $this->drupalGet('admin/structure/types/manage/article/fields/node.article.field_image/delete');
-    $this->submitForm([], 'Delete');
 
     // Add a node.
     $default_langcode = $this->langcodes[0];
@@ -312,6 +303,14 @@ public function testDisabledBundle() {
    * Tests that translations are rendered properly.
    */
   public function testTranslationRendering() {
+    // Add a comment field to the article content type.
+    \Drupal::service('module_installer')->install(['comment']);
+    $this->addDefaultCommentField('node', 'article');
+
+    // Add 'post comments' permission to the authenticated role.
+    $role = Role::load(RoleInterface::AUTHENTICATED_ID);
+    $role->grantPermission('post comments')->save();
+
     $default_langcode = $this->langcodes[0];
     $values[$default_langcode] = $this->getNewEntityValues($default_langcode);
     $this->entityId = $this->createEntity($values[$default_langcode], $default_langcode);
@@ -556,6 +555,20 @@ public function testRevisionTranslationRendering() {
    * Tests title is not escaped (but XSS-filtered) for details form element.
    */
   public function testDetailsTitleIsNotEscaped() {
+    // Create an image field.
+    \Drupal::service('module_installer')->install(['image']);
+    FieldStorageConfig::create([
+      'entity_type' => 'node',
+      'field_name' => 'field_image',
+      'type' => 'image',
+    ])->save();
+    FieldConfig::create([
+      'entity_type' => 'node',
+      'field_name' => 'field_image',
+      'bundle' => 'article',
+      'translatable' => TRUE,
+    ])->save();
+
     $this->drupalLogin($this->administrator);
     // Make the image field a multi-value field in order to display a
     // details form element.
@@ -563,6 +576,10 @@ public function testDetailsTitleIsNotEscaped() {
     $this->drupalGet('admin/structure/types/manage/article/fields/node.article.field_image');
     $this->submitForm($edit, 'Save');
 
+    // Enable the display of the image field.
+    EntityFormDisplay::load('node.article.default')
+      ->setComponent('field_image', ['region' => 'content'])->save();
+
     // Make the image field non-translatable.
     static::setFieldTranslatable('node', 'article', 'field_image', FALSE);
 

core/modules/shortcut/tests/src/Functional/ShortcutTranslationUITest.php

@@ -43,6 +43,7 @@ protected function setUp(): void {
     $this->entityTypeId = 'shortcut';
     $this->bundle = 'default';
     parent::setUp();
+    $this->doSetup();
   }
 
   /**

core/modules/taxonomy/tests/src/Functional/TermTranslationUITest.php

@@ -50,6 +50,7 @@ protected function setUp(): void {
     $this->entityTypeId = 'taxonomy_term';
     $this->bundle = 'tags';
     parent::setUp();
+    $this->doSetup();
   }
 
   /**

core/modules/user/tests/src/Functional/UserTranslationUITest.php

@@ -54,6 +54,7 @@ protected function setUp(): void {
     $this->testLanguageSelector = FALSE;
     $this->name = $this->randomMachineName();
     parent::setUp();
+    $this->doSetup();
 
     \Drupal::entityTypeManager()->getStorage('user')->resetCache();
   }