Skip to content
Snippets Groups Projects
Commit de66aa93 authored by catch's avatar catch
Browse files

Issue #3333858 by miiimooo, larowlan: Blocks that have #attached set removed after upgrade

parent aa373a88
No related tags found
32 merge requests!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!4289Issue #1344552 by marcingy, Niklas Fiekas, Ravi.J, aleevas, Eduardo Morales...,!4114Issue #2707291: Disable body-level scrolling when a dialog is open as a modal,!4100Issue #3249600: Add support for PHP 8.1 Enums as allowed values for list_* data types,!3630Issue #2815301 by Chi, DanielVeza, kostyashupenko, smustgrave: Allow to create...,!3600Issue #3344629: Passing null to parameter #1 ($haystack) of type string is deprecated,!3291Issue #3336463: Rewrite rules for gzipped CSS and JavaScript aggregates never match,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2074Issue #2707689: NodeForm::actions() checks for delete access on new entities,!2062Issue #3246454: Add weekly granularity to views date sort,!1591Issue #3199697: Add JSON:API Translation experimental module,!1484Exposed filters get values from URL when Ajax is on,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1162Issue #3100350: Unable to save '/' root path alias,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!957Added throwing of InvalidPluginDefinitionException from getDefinition().,!925Issue #2339235: Remove taxonomy hard dependency on node module,!877Issue #2708101: Default value for link text is not saved,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!844Resolve #3036010 "Updaters",!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
Hide whitespace changes
Inline Side-by-side
core/lib/Drupal/Core/Render/Element.php
+ 2
− 2
View file @ de66aa93
...@@ -187,7 +187,7 @@ public static function setAttributes(array &$element, array $map) { ...@@ -187,7 +187,7 @@ public static function setAttributes(array &$element, array $map) {
/** /**
* Indicates whether the given element is empty. * Indicates whether the given element is empty.
* *
* An element that only has #cache, #weight, or #attached set is considered * An element that only has #cache or #weight set is considered
* empty, because it will render to the empty string. * empty, because it will render to the empty string.
* *
* @param array $elements * @param array $elements
...@@ -197,7 +197,7 @@ public static function setAttributes(array &$element, array $map) { ...@@ -197,7 +197,7 @@ public static function setAttributes(array &$element, array $map) {
* Whether the given element is empty. * Whether the given element is empty.
*/ */
public static function isEmpty(array $elements) { public static function isEmpty(array $elements) {
return \array_diff(\array_keys($elements), ['#cache', '#weight', '#attached']) === []; return \array_diff(\array_keys($elements), ['#cache', '#weight']) === [];
} }
} }
core/tests/Drupal/Tests/Core/Render/ElementTest.php
+ 7
− 7
View file @ de66aa93
...@@ -188,13 +188,13 @@ public function testIsEmpty(array $element, $expected) { ...@@ -188,13 +188,13 @@ public function testIsEmpty(array $element, $expected) {
public function providerTestIsEmpty() { public function providerTestIsEmpty() {
return [ return [
[[], TRUE], [[], TRUE],
[['#attached' => []], TRUE], [['#attached' => []], FALSE],
[['#cache' => []], TRUE], [['#cache' => []], TRUE],
[['#weight' => []], TRUE], [['#weight' => []], TRUE],
// Variations. // Variations.
[['#attached' => [], '#cache' => []], TRUE], [['#attached' => [], '#cache' => []], FALSE],
[['#attached' => [], '#weight' => []], TRUE], [['#attached' => [], '#weight' => []], FALSE],
[['#attached' => [], '#weight' => [], '#cache' => []], TRUE], [['#attached' => [], '#weight' => [], '#cache' => []], FALSE],
[['#cache' => [], '#weight' => []], TRUE], [['#cache' => [], '#weight' => []], TRUE],
[['#cache' => [], '#weight' => [], '#any_other_property' => []], FALSE], [['#cache' => [], '#weight' => [], '#any_other_property' => []], FALSE],
[ [
...@@ -207,9 +207,9 @@ public function providerTestIsEmpty() { ...@@ -207,9 +207,9 @@ public function providerTestIsEmpty() {
FALSE, FALSE,
], ],
// Cover sorting. // Cover sorting.
[['#cache' => [], '#weight' => [], '#attached' => []], TRUE], [['#cache' => [], '#weight' => [], '#attached' => []], FALSE],
[['#attached' => [], '#cache' => [], '#weight' => []], TRUE], [['#cache' => [], '#weight' => []], TRUE],
[['#weight' => [], '#attached' => [], '#cache' => []], TRUE], [['#weight' => [], '#cache' => []], TRUE],
[['#cache' => []], TRUE], [['#cache' => []], TRUE],
[['#cache' => ['tags' => ['foo']]], TRUE], [['#cache' => ['tags' => ['foo']]], TRUE],
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment