Skip to content
Snippets Groups Projects
Commit d4961724 authored by catch's avatar catch
Browse files

Issue #3306597 by Wim Leers, Anchal_gupta, _utsavsharma, smustgrave: Improve...

Issue #3306597 by Wim Leers, Anchal_gupta, _utsavsharma, smustgrave: Improve usability of the "Enable image uploads" checkbox
parent 83f1d40d
No related branches found
No related tags found
32 merge requests!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!4289Issue #1344552 by marcingy, Niklas Fiekas, Ravi.J, aleevas, Eduardo Morales...,!4114Issue #2707291: Disable body-level scrolling when a dialog is open as a modal,!4100Issue #3249600: Add support for PHP 8.1 Enums as allowed values for list_* data types,!3630Issue #2815301 by Chi, DanielVeza, kostyashupenko, smustgrave: Allow to create...,!3600Issue #3344629: Passing null to parameter #1 ($haystack) of type string is deprecated,!3291Issue #3336463: Rewrite rules for gzipped CSS and JavaScript aggregates never match,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2074Issue #2707689: NodeForm::actions() checks for delete access on new entities,!2062Issue #3246454: Add weekly granularity to views date sort,!1591Issue #3199697: Add JSON:API Translation experimental module,!1484Exposed filters get values from URL when Ajax is on,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1162Issue #3100350: Unable to save '/' root path alias,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!957Added throwing of InvalidPluginDefinitionException from getDefinition().,!925Issue #2339235: Remove taxonomy hard dependency on node module,!877Issue #2708101: Default value for link text is not saved,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!844Resolve #3036010 "Updaters",!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
......@@ -208,3 +208,8 @@ internal.admin.image:
css:
theme:
css/image.admin.css: { }
js:
js/ckeditor5.image.admin.js: { }
dependencies:
- core/jquery
- core/drupal
/**
* @file
* CKEditor 5 Image admin behavior.
*/
(function ($, Drupal) {
/**
* Provides the summary for the "image" plugin settings vertical tab.
*
* @type {Drupal~behavior}
*
* @prop {Drupal~behaviorAttach} attach
* Attaches summary behavior to the plugin settings vertical tab.
*/
Drupal.behaviors.ckeditor5ImageSettingsSummary = {
attach() {
$('[data-ckeditor5-plugin-id="ckeditor5_image"]').drupalSetSummary(
(context) => {
const uploadsEnabled = document.querySelector(
'[data-drupal-selector="edit-editor-settings-plugins-ckeditor5-image-status"]',
).checked;
if (uploadsEnabled) {
return Drupal.t('Images can only be uploaded.');
}
return Drupal.t('Images can only be added by URL.');
},
);
},
};
})(jQuery, Drupal);
......@@ -43,6 +43,7 @@ function editor_image_upload_settings_form(Editor $editor) {
'#attributes' => [
'data-editor-image-upload' => 'status',
],
'#description' => t('When enabled, images can only be uploaded. When disabled, images can only be added by URL.'),
];
$show_if_image_uploads_enabled = [
'visible' => [
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment