Skip to content
Snippets Groups Projects
Verified Commit d3b144d3 authored by Dave Long's avatar Dave Long
Browse files

Issue #3466524 by catch: ModuleConfigureRouteTest is slow

parent 08f436ed
No related branches found
No related tags found
20 merge requests!11131[10.4.x-only-DO-NOT-MERGE]: Issue ##2842525 Ajax attached to Views exposed filter form does not trigger callbacks,!9470[10.3.x-only-DO-NOT-MERGE]: #3331771 Fix file_get_contents(): Passing null to parameter,!8736Update the Documention As per the Function uses.,!8513Issue #3453786: DefaultSelection should document why values for target_bundles NULL and [] behave as they do,!3878Removed unused condition head title for views,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2062Issue #3246454: Add weekly granularity to views date sort,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #247029 passed with warnings
Pipeline: drupal

#247048

    Pipeline: drupal

    #247039

      Pipeline: drupal

      #247034

        ...@@ -47,17 +47,24 @@ protected function setUp(): void { ...@@ -47,17 +47,24 @@ protected function setUp(): void {
        /** /**
        * Tests if the module configure routes exists. * Tests if the module configure routes exists.
        *
        * @dataProvider coreModuleListDataProvider
        */ */
        public function testModuleConfigureRoutes(string $module_name): void { public function testModuleConfigureRoutes(): void {
        foreach (static::coreModuleListDataProvider() as $module_name => $info) {
        $this->doTestModuleConfigureRoutes($module_name);
        }
        }
        /**
        * Checks the configure route for a single module.
        */
        protected function doTestModuleConfigureRoutes(string $module_name): void {
        $module_info = $this->moduleInfo[$module_name]->info; $module_info = $this->moduleInfo[$module_name]->info;
        if (!isset($module_info['configure'])) { if (!isset($module_info['configure'])) {
        $this->markTestSkipped("$module_name has no configure route"); return;
        } }
        $module_lifecycle = $module_info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER]; $module_lifecycle = $module_info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER];
        if (isset($module_lifecycle) && $module_lifecycle === ExtensionLifecycle::DEPRECATED) { if (isset($module_lifecycle) && $module_lifecycle === ExtensionLifecycle::DEPRECATED) {
        $this->markTestSkipped("$module_name is $module_lifecycle"); return;
        } }
        $this->container->get('module_installer')->install([$module_name]); $this->container->get('module_installer')->install([$module_name]);
        $this->assertModuleConfigureRoutesExist($module_name, $module_info); $this->assertModuleConfigureRoutesExist($module_name, $module_info);
        ...@@ -70,17 +77,24 @@ public function testModuleConfigureRoutes(string $module_name): void { ...@@ -70,17 +77,24 @@ public function testModuleConfigureRoutes(string $module_name): void {
        * deprecated module doesn't trigger a deprecation notice. * deprecated module doesn't trigger a deprecation notice.
        * *
        * @group legacy * @group legacy
        *
        * @dataProvider coreModuleListDataProvider
        */ */
        public function testDeprecatedModuleConfigureRoutes(string $module_name): void { public function testDeprecatedModuleConfigureRoutes(): void {
        foreach (static::coreModuleListDataProvider() as $module_name => $info) {
        $this->doTestDeprecatedModuleConfigureRoutes($module_name);
        }
        }
        /**
        * Check the configure route for a single module.
        */
        protected function doTestDeprecatedModuleConfigureRoutes(string $module_name): void {
        $module_info = $this->moduleInfo[$module_name]->info; $module_info = $this->moduleInfo[$module_name]->info;
        if (!isset($module_info['configure'])) { if (!isset($module_info['configure'])) {
        $this->markTestSkipped("$module_name has no configure route"); return;
        } }
        $module_lifecycle = $module_info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER]; $module_lifecycle = $module_info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER];
        if (isset($module_lifecycle) && $module_lifecycle !== ExtensionLifecycle::DEPRECATED) { if (isset($module_lifecycle) && $module_lifecycle !== ExtensionLifecycle::DEPRECATED) {
        $this->markTestSkipped("$module_name is not $module_lifecycle"); return;
        } }
        $this->container->get('module_installer')->install([$module_name]); $this->container->get('module_installer')->install([$module_name]);
        $this->assertModuleConfigureRoutesExist($module_name, $module_info); $this->assertModuleConfigureRoutesExist($module_name, $module_info);
        ......
        0% Loading or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Finish editing this message first!
        Please register or to comment