Skip to content
Snippets Groups Projects

Issue #3453786: DefaultSelection should document why values for target_bundles NULL and [] behave as they do

Closed Issue #3453786: DefaultSelection should document why values for target_bundles NULL and [] behave as they do
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
144 144 // For the 'target_bundles' setting, a NULL value is equivalent to "allow
145 145 // entities from any bundle to be referenced" and an empty array value is
146 146 // equivalent to "no entities from any bundle can be referenced".
147 // The reason behind the null vs empty array situation is due to
  • This was a comment made in Slack, so it needs a bit of copy-editing to make it into good docs!

    'situation' is a big fuzzy.

    Something like 'The reason for NULL and an empty array having a different meaning is to correctly handle the config updates. For example, in the scenario where a single target bundle is allowed, and that bundle is then deleted, the automatic removal of that bundle from the entity reference field's settings leaves an empty array. This empty array must therefore indicate that no bundles are allowed, as otherwise the field would suddenly allow all bundles.'

  • Soham Sengupta changed this line in version 2 of the diff

    changed this line in version 2 of the diff

  • Thank you for reviewing the MR. I have updated the comment as per your suggestion. Thank you.

  • Please register or sign in to reply
  • added 1 commit

    • 3dfc16b9 - Updated the reason to provide more details about the behaviour

    Compare with previous version

  • Jürgen Haas
    Jürgen Haas @jurgenhaas started a thread on commit d8c2dc56
  • 1721 1721 */
    1722 1722 function system_update_11001(&$sandbox) {
    1723 1723 // Execute only if allowed setting, 'timestamp_field_update_y2038', is true.
    1724 if (!Settings::get('timestamp_field_update_y2038', FALSE)) {
    1724 if (Settings::get('timestamp_field_update_y2038', FALSE) === FALSE) {
  • Thomas Ziaja added 567 commits

    added 567 commits

    • 3dfc16b9...b1f72383 - 557 earlier commits
    • 0c9e4a4b - Issue #3467860 by googletorp, catch, smustgrave, alexpott, swentel: Ensure...
    • 6067ed42 - Issue #221761 by mohit_aghera, pameeela, dixon_, catch, ged3000, sun,...
    • 79a49040 - Issue #3403535 by mlncn, tobiasb, nayana_mvr, pameeela: Claro removes default...
    • 5e0ff5a8 - Issue #3457863 by grimreaper, catch, pdureau, maboy, longwave: YAML discovery...
    • a61ad676 - Issue #1630568 by sokru, Laureatus, quietone, smustgrave, ravi.shankar:...
    • 76617730 - Issue #3471949 by mstrelan: Allow passing MarkupInterface to AssertContentTrait::setRawContent
    • aeef5cd6 - Issue #3473214 by mstrelan: Stop passing ints to...
    • d433d966 - Issue #3458426 by mstrelan, catch, smustgrave: Add int return typehints to...
    • 2a549f16 - Revert "Issue #3458426 by mstrelan, catch, smustgrave: Add int return...
    • 5e7f13f3 - mr against 11.x

    Compare with previous version

  • Thomas Ziaja added 1 commit

    added 1 commit

    Compare with previous version

  • Thomas Ziaja added 1 commit

    added 1 commit

    Compare with previous version

  • closed

  • Please register or sign in to reply
    Loading