Skip to content
Snippets Groups Projects
Verified Commit d246c433 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3454212 by nathankg, joachim: Update mentions of #2225961 in comments

parent ca4535dd
No related branches found
No related tags found
24 merge requests!11131[10.4.x-only-DO-NOT-MERGE]: Issue ##2842525 Ajax attached to Views exposed filter form does not trigger callbacks,!9470[10.3.x-only-DO-NOT-MERGE]: #3331771 Fix file_get_contents(): Passing null to parameter,!8736Update the Documention As per the Function uses.,!8540Issue #3457061: Bootstrap Modal dialog Not closing after 10.3.0 Update,!8528Issue #3456871 by Tim Bozeman: Support NULL services,!8513Issue #3453786: DefaultSelection should document why values for target_bundles NULL and [] behave as they do,!8126Added escape fucntionality on admintoolbar close icon,!3878Removed unused condition head title for views,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #201103 canceled
Stage: 🏗️ Build
    Stage: 🪄 Lint
      Stage: 🗜️ Test
        Hide whitespace changes
        Inline Side-by-side
        core/lib/Drupal/Core/Entity/EntityFieldManager.php
        + 5
        − 5
        View file @ d246c433
        ......@@ -277,7 +277,7 @@ protected function buildBaseFieldDefinitions($entity_type_id) {
        $provider = $entity_type->getProvider();
        foreach ($base_field_definitions as $definition) {
        // @todo Remove this check once FieldDefinitionInterface exposes a proper
        // provider setter. See https://www.drupal.org/node/2225961.
        // provider setter. See https://www.drupal.org/node/2346329.
        if ($definition instanceof BaseFieldDefinition) {
        $definition->setProvider($provider);
        }
        ......@@ -292,7 +292,7 @@ function (callable $hook, string $module) use (&$base_field_definitions, $entity
        // defining the field.
        foreach ($module_definitions as $field_name => $definition) {
        // @todo Remove this check once FieldDefinitionInterface exposes a
        // proper provider setter. See https://www.drupal.org/node/2225961.
        // proper provider setter. See https://www.drupal.org/node/2346329.
        if ($definition instanceof BaseFieldDefinition && $definition->getProvider() == NULL) {
        $definition->setProvider($module);
        }
        ......@@ -402,7 +402,7 @@ protected function buildBundleFieldDefinitions($entity_type_id, $bundle, array $
        $provider = $entity_type->getProvider();
        foreach ($bundle_field_definitions as $definition) {
        // @todo Remove this check once FieldDefinitionInterface exposes a proper
        // provider setter. See https://www.drupal.org/node/2225961.
        // provider setter. See https://www.drupal.org/node/2346329.
        if ($definition instanceof BaseFieldDefinition) {
        $definition->setProvider($provider);
        }
        ......@@ -417,7 +417,7 @@ function (callable $hook, string $module) use (&$bundle_field_definitions, $enti
        // defining the field.
        foreach ($module_definitions as $field_name => $definition) {
        // @todo Remove this check once FieldDefinitionInterface exposes a
        // proper provider setter. See https://www.drupal.org/node/2225961.
        // proper provider setter. See https://www.drupal.org/node/2346329.
        if ($definition instanceof BaseFieldDefinition) {
        $definition->setProvider($module);
        }
        ......@@ -594,7 +594,7 @@ function (callable $hook, string $module) use (&$field_definitions, $entity_type
        // defining the field.
        foreach ($module_definitions as $field_name => $definition) {
        // @todo Remove this check once FieldDefinitionInterface exposes a
        // proper provider setter. See https://www.drupal.org/node/2225961.
        // proper provider setter. See https://www.drupal.org/node/2346329.
        if ($definition instanceof BaseFieldDefinition) {
        $definition->setProvider($module);
        $definition->setName($field_name);
        ......
        core/tests/Drupal/Tests/Core/Entity/EntityFieldManagerTest.php
        + 1
        − 1
        View file @ d246c433
        ......@@ -548,7 +548,7 @@ public function testGetFieldDefinitionsProvider() {
        $module = 'entity_field_manager_test_module';
        // @todo Mock FieldDefinitionInterface once it exposes a proper provider
        // setter. See https://www.drupal.org/node/2225961.
        // setter. See https://www.drupal.org/node/2346329.
        $field_definition = $this->prophesize(BaseFieldDefinition::class);
        // We expect two calls as the field definition will be returned from both
        ......
        0% or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Finish editing this message first!
        Please register or to comment