Skip to content
Snippets Groups Projects
Commit c97eb132 authored by catch's avatar catch
Browse files

Issue #3265291 by xjm, neclimdul, longwave, Spokje: QuickStartTest: The waiting is the hardest part

parent 3effb672
Branches
Tags
39 merge requests!12227Issue #3181946 by jonmcl, mglaman,!7471uncessary 5 files are moved from media-library folder to misc folder,!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!4289Issue #1344552 by marcingy, Niklas Fiekas, Ravi.J, aleevas, Eduardo Morales...,!4114Issue #2707291: Disable body-level scrolling when a dialog is open as a modal,!3630Issue #2815301 by Chi, DanielVeza, kostyashupenko, smustgrave: Allow to create...,!3291Issue #3336463: Rewrite rules for gzipped CSS and JavaScript aggregates never match,!3143Issue #3313342: [PHP 8.1] Deprecated function: strpos(): Passing null to parameter #1 LayoutBuilderUiCacheContext.php on line 28,!3102Issue #3164428 by DonAtt, longwave, sahil.goyal, Anchal_gupta, alexpott: Use...,!2853#3274419 Makes BaseFieldOverride inherit the internal property from the base field.,!2719Issue #3110137: Remove Classy from core.,!2437Issue #3238257 by hooroomoo, Wim Leers: Fragment link pointing to <textarea>...,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2074Issue #2707689: NodeForm::actions() checks for delete access on new entities,!2062Issue #3246454: Add weekly granularity to views date sort,!1974Issue #3036862 demonstration,!1591Issue #3199697: Add JSON:API Translation experimental module,!1484Exposed filters get values from URL when Ajax is on,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1254Issue #3238915: Refactor (if feasible) uses of the jQuery ready function to use VanillaJS,!1162Issue #3100350: Unable to save '/' root path alias,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!957Added throwing of InvalidPluginDefinitionException from getDefinition().,!925Issue #2339235: Remove taxonomy hard dependency on node module,!877Issue #2708101: Default value for link text is not saved,!873Issue #2875228: Site install not using batch API service,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!844Resolve #3036010 "Updaters",!712Issue #2909128: Autocomplete intermittent on Chrome Android,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!213Issue #2906496: Give Media a menu item under Content,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
Show whitespace changes
Inline Side-by-side
core/tests/Drupal/Tests/Core/Command/QuickStartTest.php
+ 9
− 18
View file @ c97eb132
...@@ -108,14 +108,12 @@ public function testQuickStartCommand() { ...@@ -108,14 +108,12 @@ public function testQuickStartCommand() {
$process->start(); $process->start();
$guzzle = new Client(); $guzzle = new Client();
$port = FALSE; $port = FALSE;
while ($process->isRunning()) { $process->waitUntil(function ($type, $output) use (&$port) {
if (preg_match('/127.0.0.1:(\d+)/', $process->getOutput(), $match)) { if (preg_match('/127.0.0.1:(\d+)/', $output, $match)) {
$port = $match[1]; $port = $match[1];
break; return TRUE;
}
// Wait for more output.
sleep(1);
} }
});
// The progress bar uses STDERR to write messages. // The progress bar uses STDERR to write messages.
$this->assertStringContainsString('Congratulations, you installed Drupal!', $process->getErrorOutput()); $this->assertStringContainsString('Congratulations, you installed Drupal!', $process->getErrorOutput());
$this->assertNotFalse($port, "Web server running on port $port"); $this->assertNotFalse($port, "Web server running on port $port");
...@@ -157,12 +155,7 @@ public function testPhpRequirement() { ...@@ -157,12 +155,7 @@ public function testPhpRequirement() {
]; ];
$process = new Process($install_command, NULL, ['DRUPAL_DEV_SITE_PATH' => $this->testDb->getTestSitePath()]); $process = new Process($install_command, NULL, ['DRUPAL_DEV_SITE_PATH' => $this->testDb->getTestSitePath()]);
$process->setTimeout(500); $process->setTimeout(500);
$process->start(); $process->run();
while ($process->isRunning()) {
// Wait for more output.
sleep(1);
}
$error_output = $process->getErrorOutput(); $error_output = $process->getErrorOutput();
$this->assertStringContainsString('Your PHP installation is too old.', $error_output); $this->assertStringContainsString('Your PHP installation is too old.', $error_output);
$this->assertStringContainsString('Drupal requires at least PHP', $error_output); $this->assertStringContainsString('Drupal requires at least PHP', $error_output);
...@@ -209,14 +202,12 @@ public function testQuickStartInstallAndServerCommands() { ...@@ -209,14 +202,12 @@ public function testQuickStartInstallAndServerCommands() {
$server_process->start(); $server_process->start();
$guzzle = new Client(); $guzzle = new Client();
$port = FALSE; $port = FALSE;
while ($server_process->isRunning()) { $server_process->waitUntil(function ($type, $output) use (&$port) {
if (preg_match('/127.0.0.1:(\d+)/', $server_process->getOutput(), $match)) { if (preg_match('/127.0.0.1:(\d+)\/user\/reset\/1\//', $output, $match)) {
$port = $match[1]; $port = $match[1];
break; return TRUE;
}
// Wait for more output.
sleep(1);
} }
});
$this->assertEquals('', $server_process->getErrorOutput()); $this->assertEquals('', $server_process->getErrorOutput());
$this->assertStringContainsString("127.0.0.1:$port/user/reset/1/", $server_process->getOutput()); $this->assertStringContainsString("127.0.0.1:$port/user/reset/1/", $server_process->getOutput());
$this->assertNotFalse($port, "Web server running on port $port"); $this->assertNotFalse($port, "Web server running on port $port");
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment