Skip to content
Snippets Groups Projects
Verified Commit bd6abf7c authored by Théodore Biadala's avatar Théodore Biadala
Browse files

Issue #3308432 by devkinetic, BramDriesen, Shifali Baghel, cilefen,... 

Issue #3308432 by devkinetic, BramDriesen, Shifali Baghel, cilefen, smustgrave, quietone, bnjmnm: The link on the Image tag is redirecting to an undefined page from the node preview screen
parent 3dc29858
No related branches found
No related tags found
20 merge requests!11131[10.4.x-only-DO-NOT-MERGE]: Issue ##2842525 Ajax attached to Views exposed filter form does not trigger callbacks,!9470[10.3.x-only-DO-NOT-MERGE]: #3331771 Fix file_get_contents(): Passing null to parameter,!8736Update the Documention As per the Function uses.,!8513Issue #3453786: DefaultSelection should document why values for target_bundles NULL and [] behave as they do,!3878Removed unused condition head title for views,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2062Issue #3246454: Add weekly granularity to views date sort,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #234122 passed with warnings
Stage: 🏗️ Build
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal

#234132

    Pipeline: drupal

    #234126

      Hide whitespace changes
      Inline Side-by-side
      core/modules/node/node.preview.js
      + 1
      − 1
      View file @ bd6abf7c
      ...@@ -46,7 +46,7 @@ ...@@ -46,7 +46,7 @@
      { {
      text: Drupal.t('Leave preview'), text: Drupal.t('Leave preview'),
      click() { click() {
      window.top.location.href = event.target.href; window.top.location.href = event.currentTarget.href;
      }, },
      }, },
      ], ],
      ......
      core/modules/node/tests/src/FunctionalJavascript/NodePreviewLinkTest.php
      + 16
      − 2
      View file @ bd6abf7c
      ...@@ -54,15 +54,29 @@ public function testPreviewLinks(): void { ...@@ -54,15 +54,29 @@ public function testPreviewLinks(): void {
      $assertSession = $this->assertSession(); $assertSession = $this->assertSession();
      $this->drupalGet('node/add/test'); $this->drupalGet('node/add/test');
      $this->submitForm([ $this->submitForm([
      'title[0][value]' => 'Test node', 'title[0][value]' => 'Test anchor link',
      'body[0][value]' => '<a href="#foo">Anchor link</a><a href="/foo">Normal link</a>', 'body[0][value]' => '<a href="#foo">Anchor link</a>',
      ], 'Preview'); ], 'Preview');
      $this->clickLink('Anchor link'); $this->clickLink('Anchor link');
      $assertSession->pageTextNotContains('Leave preview?'); $assertSession->pageTextNotContains('Leave preview?');
      $this->drupalGet('node/add/test');
      $this->submitForm([
      'title[0][value]' => 'Test normal link',
      'body[0][value]' => '<a href="/foo">Normal link</a>',
      ], 'Preview');
      $this->clickLink('Normal link'); $this->clickLink('Normal link');
      $assertSession->pageTextContains('Leave preview?'); $assertSession->pageTextContains('Leave preview?');
      $this->click('button:contains("Leave preview")'); $this->click('button:contains("Leave preview")');
      $this->assertStringEndsWith('/foo', $this->getUrl()); $this->assertStringEndsWith('/foo', $this->getUrl());
      $this->drupalGet('node/add/test');
      $this->submitForm([
      'title[0][value]' => 'Test child element link',
      'body[0][value]' => '<a href="/foo" class="preview-child-element"><span>Child element link</span></a>',
      ], 'Preview');
      $this->getSession()->getPage()->find('css', '.preview-child-element span')->click();
      $assertSession->pageTextContains('Leave preview?');
      $this->click('button:contains("Leave preview")');
      $this->assertStringEndsWith('/foo', $this->getUrl());
      } }
      } }
      0% or .
      You are about to add 0 people to the discussion. Proceed with caution.
      Please register or to comment