Skip to content
Snippets Groups Projects
Verified Commit bc8ed7fe authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3247121 by ramil g, joelpittet: Aggregation of nid when using COUNT produces syntax error

parent ac84424e
No related branches found
No related tags found
36 merge requests!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!4289Issue #1344552 by marcingy, Niklas Fiekas, Ravi.J, aleevas, Eduardo Morales...,!4114Issue #2707291: Disable body-level scrolling when a dialog is open as a modal,!4100Issue #3249600: Add support for PHP 8.1 Enums as allowed values for list_* data types,!3630Issue #2815301 by Chi, DanielVeza, kostyashupenko, smustgrave: Allow to create...,!3600Issue #3344629: Passing null to parameter #1 ($haystack) of type string is deprecated,!3291Issue #3336463: Rewrite rules for gzipped CSS and JavaScript aggregates never match,!3102Issue #3164428 by DonAtt, longwave, sahil.goyal, Anchal_gupta, alexpott: Use...,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2074Issue #2707689: NodeForm::actions() checks for delete access on new entities,!2062Issue #3246454: Add weekly granularity to views date sort,!1591Issue #3199697: Add JSON:API Translation experimental module,!1484Exposed filters get values from URL when Ajax is on,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1254Issue #3238915: Refactor (if feasible) uses of the jQuery ready function to use VanillaJS,!1162Issue #3100350: Unable to save '/' root path alias,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!957Added throwing of InvalidPluginDefinitionException from getDefinition().,!925Issue #2339235: Remove taxonomy hard dependency on node module,!877Issue #2708101: Default value for link text is not saved,!873Issue #2875228: Site install not using batch API service,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!844Resolve #3036010 "Updaters",!712Issue #2909128: Autocomplete intermittent on Chrome Android,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
......@@ -1357,7 +1357,7 @@ public function query($get_count = FALSE) {
$entity_information = $this->getEntityTableInfo();
if ($entity_information) {
$params = [];
if ($groupby) {
if ($this->hasAggregate) {
// Handle grouping, by retrieving the minimum entity_id.
$params = [
'function' => 'min',
......
langcode: en
status: true
dependencies: { }
id: test_aggregate_count_function
label: ''
module: views
description: ''
tag: ''
base_table: entity_test
base_field: id
display:
default:
display_options:
access:
type: none
arguments: { }
cache:
type: tag
exposed_form:
type: basic
fields:
id:
alter:
alter_text: false
ellipsis: true
html: false
make_link: false
strip_tags: false
trim: false
word_boundary: true
empty_zero: false
field: id
group_type: count
hide_empty: false
id: id
table: entity_test
plugin_id: field
type: number_integer
entity_type: entity_test
entity_field: id
group_by: true
pager:
type: some
query:
options:
query_comment: ''
type: views_query
style:
type: default
row:
type: fields
display_plugin: default
display_title: Default
id: default
position: 0
......@@ -21,7 +21,14 @@ class QueryGroupByTest extends ViewsKernelTestBase {
*
* @var array
*/
public static $testViews = ['test_group_by_in_filters', 'test_aggregate_count', 'test_group_by_count', 'test_group_by_count_multicardinality', 'test_group_by_field_not_within_bundle'];
public static $testViews = [
'test_group_by_in_filters',
'test_aggregate_count',
'test_aggregate_count_function',
'test_group_by_count',
'test_group_by_count_multicardinality',
'test_group_by_field_not_within_bundle',
];
/**
* Modules to enable.
......@@ -79,6 +86,19 @@ public function testAggregateCount() {
$this->assertEquals(3, $types['name2']);
}
/**
* Tests aggregate count feature with no group by.
*/
public function testAggregateCountFunction() {
$this->setupTestEntities();
$view = Views::getView('test_aggregate_count_function');
$this->executeView($view);
$this->assertEquals(7, $view->result[0]->id);
$this->assertCount(1, $view->result, 'Make sure the count of rows is one.');
}
/**
* Provides a test helper which runs a view with some aggregation function.
*
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment