Skip to content
Snippets Groups Projects
Commit b5c3f1b3 authored by catch's avatar catch
Browse files

Issue #3254723 by mondrake, murilohp, longwave: Remove SimpletestUiPrinter

parent b9e078a0
No related branches found
No related tags found
38 merge requests!7471uncessary 5 files are moved from media-library folder to misc folder,!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!4289Issue #1344552 by marcingy, Niklas Fiekas, Ravi.J, aleevas, Eduardo Morales...,!4114Issue #2707291: Disable body-level scrolling when a dialog is open as a modal,!3630Issue #2815301 by Chi, DanielVeza, kostyashupenko, smustgrave: Allow to create...,!3291Issue #3336463: Rewrite rules for gzipped CSS and JavaScript aggregates never match,!3143Issue #3313342: [PHP 8.1] Deprecated function: strpos(): Passing null to parameter #1 LayoutBuilderUiCacheContext.php on line 28,!3102Issue #3164428 by DonAtt, longwave, sahil.goyal, Anchal_gupta, alexpott: Use...,!2853#3274419 Makes BaseFieldOverride inherit the internal property from the base field.,!2719Issue #3110137: Remove Classy from core.,!2437Issue #3238257 by hooroomoo, Wim Leers: Fragment link pointing to <textarea>...,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2074Issue #2707689: NodeForm::actions() checks for delete access on new entities,!2062Issue #3246454: Add weekly granularity to views date sort,!1974Issue #3036862 demonstration,!1591Issue #3199697: Add JSON:API Translation experimental module,!1484Exposed filters get values from URL when Ajax is on,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1254Issue #3238915: Refactor (if feasible) uses of the jQuery ready function to use VanillaJS,!1162Issue #3100350: Unable to save '/' root path alias,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!957Added throwing of InvalidPluginDefinitionException from getDefinition().,!925Issue #2339235: Remove taxonomy hard dependency on node module,!877Issue #2708101: Default value for link text is not saved,!873Issue #2875228: Site install not using batch API service,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!844Resolve #3036010 "Updaters",!712Issue #2909128: Autocomplete intermittent on Chrome Android,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
use Drupal\Core\Database\Database; use Drupal\Core\Database\Database;
use Drupal\Core\DependencyInjection\ContainerInjectionInterface; use Drupal\Core\DependencyInjection\ContainerInjectionInterface;
use Drupal\Tests\Listeners\SimpletestUiPrinter;
use Symfony\Component\DependencyInjection\ContainerInterface; use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\Process\PhpExecutableFinder; use Symfony\Component\Process\PhpExecutableFinder;
...@@ -145,8 +144,6 @@ public function runCommand(array $unescaped_test_classnames, $phpunit_file, &$st ...@@ -145,8 +144,6 @@ public function runCommand(array $unescaped_test_classnames, $phpunit_file, &$st
$phpunit_bin, $phpunit_bin,
'--log-junit', '--log-junit',
escapeshellarg($phpunit_file), escapeshellarg($phpunit_file),
'--printer',
escapeshellarg(SimpletestUiPrinter::class),
]; ];
// Optimized for running a single test. // Optimized for running a single test.
......
...@@ -32,4 +32,25 @@ public function testPhpUnitListTests() { ...@@ -32,4 +32,25 @@ public function testPhpUnitListTests() {
); );
} }
/**
* Ensures that functional tests produce debug HTML output when required.
*/
public function testFunctionalTestDebugHtmlOutput() {
if (getenv('BROWSERTEST_OUTPUT_DIRECTORY') === FALSE) {
$this->markTestSkipped('This test requires the environment variable BROWSERTEST_OUTPUT_DIRECTORY to be set.');
}
$process = Process::fromShellCommandline('vendor/bin/phpunit --configuration core --verbose core/modules/image/tests/src/Functional/ImageDimensionsTest.php');
$process->setWorkingDirectory($this->root)
->setTimeout(300)
->setIdleTimeout(300);
$process->run();
$this->assertEquals(0, $process->getExitCode(),
'COMMAND: ' . $process->getCommandLine() . "\n" .
'OUTPUT: ' . $process->getOutput() . "\n" .
'ERROR: ' . $process->getErrorOutput() . "\n");
$this->assertStringContainsString('HTML output was generated', $process->getOutput());
$this->assertStringContainsString('Drupal_Tests_image_Functional_ImageDimensionsTest-1', $process->getOutput());
}
} }
...@@ -2,8 +2,6 @@ ...@@ -2,8 +2,6 @@
namespace Drupal\Tests\Listeners; namespace Drupal\Tests\Listeners;
use Drupal\Component\Utility\Html;
/** /**
* Defines a class for providing html output results for functional tests. * Defines a class for providing html output results for functional tests.
* *
...@@ -80,18 +78,4 @@ protected function printHtmlOutput() { ...@@ -80,18 +78,4 @@ protected function printHtmlOutput() {
} }
} }
/**
* Prints HTML output links for the Simpletest UI.
*/
public function simpletestUiWrite($buffer) {
$buffer = Html::escape($buffer);
// Turn HTML output URLs into clickable link <a> tags.
$url_pattern = '@https?://[^\s]+@';
$buffer = preg_replace($url_pattern, '<a href="$0" target="_blank" title="$0">$0</a>', $buffer);
// Make the output readable in HTML by breaking up lines properly.
$buffer = nl2br($buffer);
print $buffer;
}
} }
<?php
namespace Drupal\Tests\Listeners;
/**
* Defines a class for providing html output links in the Simpletest UI.
*/
class SimpletestUiPrinter extends HtmlOutputPrinter {
/**
* {@inheritdoc}
*/
public function write(string $buffer): void {
$this->simpletestUiWrite($buffer);
}
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment