Skip to content
Snippets Groups Projects
Verified Commit aeef5cd6 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3473214 by mstrelan: Stop passing ints to...

Issue #3473214 by mstrelan: Stop passing ints to DateTimePlus::createFromFormat and DrupalDateTime::createFromFormat
parent 76617730
No related branches found
No related tags found
20 merge requests!12227Issue #3181946 by jonmcl, mglaman,!11131[10.4.x-only-DO-NOT-MERGE]: Issue ##2842525 Ajax attached to Views exposed filter form does not trigger callbacks,!8736Update the Documention As per the Function uses.,!8513Issue #3453786: DefaultSelection should document why values for target_bundles NULL and [] behave as they do,!5423Draft: Resolve #3329907 "Test2",!3878Removed unused condition head title for views,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3478Issue #3337882: Deleted menus are not removed from content type config,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2062Issue #3246454: Add weekly granularity to views date sort,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #293428 passed with warnings
Pipeline: drupal

#293454

    Pipeline: drupal

    #293446

      Pipeline: drupal

      #293429

        ...@@ -683,38 +683,38 @@ public static function providerTestDateDiff() { ...@@ -683,38 +683,38 @@ public static function providerTestDateDiff() {
        'expected' => $positive_18_hours, 'expected' => $positive_18_hours,
        ], ],
        [ [
        'input1' => DateTimePlus::createFromFormat('U', 3600, new \DateTimeZone('America/Los_Angeles')), 'input1' => DateTimePlus::createFromFormat('U', '3600', new \DateTimeZone('America/Los_Angeles')),
        'input2' => DateTimePlus::createFromFormat('U', 0, new \DateTimeZone('UTC')), 'input2' => DateTimePlus::createFromTimestamp(0, new \DateTimeZone('UTC')),
        'absolute' => FALSE, 'absolute' => FALSE,
        'expected' => $negative_1_hour, 'expected' => $negative_1_hour,
        ], ],
        [ [
        'input1' => DateTimePlus::createFromFormat('U', 3600), 'input1' => DateTimePlus::createFromTimestamp(3600),
        'input2' => DateTimePlus::createFromFormat('U', 0), 'input2' => DateTimePlus::createFromTimestamp(0),
        'absolute' => FALSE, 'absolute' => FALSE,
        'expected' => $negative_1_hour, 'expected' => $negative_1_hour,
        ], ],
        [ [
        'input1' => DateTimePlus::createFromFormat('U', 3600), 'input1' => DateTimePlus::createFromTimestamp(3600),
        'input2' => \DateTime::createFromFormat('U', '0'), 'input2' => \DateTime::createFromFormat('U', '0'),
        'absolute' => FALSE, 'absolute' => FALSE,
        'expected' => $negative_1_hour, 'expected' => $negative_1_hour,
        ], ],
        [ [
        'input1' => DateTimePlus::createFromFormat('U', 3600), 'input1' => DateTimePlus::createFromTimestamp(3600),
        'input2' => DateTimePlus::createFromFormat('U', 0), 'input2' => DateTimePlus::createFromTimestamp(0),
        'absolute' => TRUE, 'absolute' => TRUE,
        'expected' => $positive_1_hour, 'expected' => $positive_1_hour,
        ], ],
        [ [
        'input1' => DateTimePlus::createFromFormat('U', 3600), 'input1' => DateTimePlus::createFromTimestamp(3600),
        'input2' => \DateTime::createFromFormat('U', '0'), 'input2' => \DateTime::createFromFormat('U', '0'),
        'absolute' => TRUE, 'absolute' => TRUE,
        'expected' => $positive_1_hour, 'expected' => $positive_1_hour,
        ], ],
        [ [
        'input1' => DateTimePlus::createFromFormat('U', 0), 'input1' => DateTimePlus::createFromTimestamp(0),
        'input2' => DateTimePlus::createFromFormat('U', 0), 'input2' => DateTimePlus::createFromTimestamp(0),
        'absolute' => FALSE, 'absolute' => FALSE,
        'expected' => $empty_interval, 'expected' => $empty_interval,
        ], ],
        ...@@ -733,12 +733,12 @@ public static function providerTestDateDiff() { ...@@ -733,12 +733,12 @@ public static function providerTestDateDiff() {
        public static function providerTestInvalidDateDiff() { public static function providerTestInvalidDateDiff() {
        return [ return [
        [ [
        'input1' => DateTimePlus::createFromFormat('U', 3600), 'input1' => DateTimePlus::createFromTimestamp(3600),
        'input2' => '1970-01-01 00:00:00', 'input2' => '1970-01-01 00:00:00',
        'absolute' => FALSE, 'absolute' => FALSE,
        ], ],
        [ [
        'input1' => DateTimePlus::createFromFormat('U', 3600), 'input1' => DateTimePlus::createFromTimestamp(3600),
        'input2' => NULL, 'input2' => NULL,
        'absolute' => FALSE, 'absolute' => FALSE,
        ], ],
        ......
        ...@@ -98,38 +98,38 @@ public static function providerTestDateDiff() { ...@@ -98,38 +98,38 @@ public static function providerTestDateDiff() {
        'expected' => $positive_18_hours, 'expected' => $positive_18_hours,
        ], ],
        [ [
        'input1' => DrupalDateTime::createFromFormat('U', 3600, new \DateTimeZone('America/Los_Angeles'), $settings), 'input1' => DrupalDateTime::createFromFormat('U', '3600', new \DateTimeZone('America/Los_Angeles'), $settings),
        'input2' => DrupalDateTime::createFromFormat('U', 0, $utc_tz, $settings), 'input2' => DrupalDateTime::createFromTimestamp(0, $utc_tz, $settings),
        'absolute' => FALSE, 'absolute' => FALSE,
        'expected' => $negative_1_hour, 'expected' => $negative_1_hour,
        ], ],
        [ [
        'input1' => DrupalDateTime::createFromFormat('U', 3600, $utc_tz, $settings), 'input1' => DrupalDateTime::createFromTimestamp(3600, $utc_tz, $settings),
        'input2' => DrupalDateTime::createFromFormat('U', 0, $utc_tz, $settings), 'input2' => DrupalDateTime::createFromTimestamp(0, $utc_tz, $settings),
        'absolute' => FALSE, 'absolute' => FALSE,
        'expected' => $negative_1_hour, 'expected' => $negative_1_hour,
        ], ],
        [ [
        'input1' => DrupalDateTime::createFromFormat('U', 3600, $utc_tz, $settings), 'input1' => DrupalDateTime::createFromTimestamp(3600, $utc_tz, $settings),
        'input2' => \DateTime::createFromFormat('U', '0'), 'input2' => \DateTime::createFromFormat('U', '0'),
        'absolute' => FALSE, 'absolute' => FALSE,
        'expected' => $negative_1_hour, 'expected' => $negative_1_hour,
        ], ],
        [ [
        'input1' => DrupalDateTime::createFromFormat('U', 3600, $utc_tz, $settings), 'input1' => DrupalDateTime::createFromTimestamp(3600, $utc_tz, $settings),
        'input2' => DrupalDateTime::createFromFormat('U', 0, $utc_tz, $settings), 'input2' => DrupalDateTime::createFromTimestamp(0, $utc_tz, $settings),
        'absolute' => TRUE, 'absolute' => TRUE,
        'expected' => $positive_1_hour, 'expected' => $positive_1_hour,
        ], ],
        [ [
        'input1' => DrupalDateTime::createFromFormat('U', 3600, $utc_tz, $settings), 'input1' => DrupalDateTime::createFromTimestamp(3600, $utc_tz, $settings),
        'input2' => \DateTime::createFromFormat('U', '0'), 'input2' => \DateTime::createFromFormat('U', '0'),
        'absolute' => TRUE, 'absolute' => TRUE,
        'expected' => $positive_1_hour, 'expected' => $positive_1_hour,
        ], ],
        [ [
        'input1' => DrupalDateTime::createFromFormat('U', 0, $utc_tz, $settings), 'input1' => DrupalDateTime::createFromTimestamp(0, $utc_tz, $settings),
        'input2' => DrupalDateTime::createFromFormat('U', 0, $utc_tz, $settings), 'input2' => DrupalDateTime::createFromTimestamp(0, $utc_tz, $settings),
        'absolute' => FALSE, 'absolute' => FALSE,
        'expected' => $empty_interval, 'expected' => $empty_interval,
        ], ],
        ...@@ -150,12 +150,12 @@ public static function providerTestInvalidDateDiff() { ...@@ -150,12 +150,12 @@ public static function providerTestInvalidDateDiff() {
        $utc_tz = new \DateTimeZone('UTC'); $utc_tz = new \DateTimeZone('UTC');
        return [ return [
        [ [
        'input1' => DrupalDateTime::createFromFormat('U', 3600, $utc_tz, $settings), 'input1' => DrupalDateTime::createFromTimestamp(3600, $utc_tz, $settings),
        'input2' => '1970-01-01 00:00:00', 'input2' => '1970-01-01 00:00:00',
        'absolute' => FALSE, 'absolute' => FALSE,
        ], ],
        [ [
        'input1' => DrupalDateTime::createFromFormat('U', 3600, $utc_tz, $settings), 'input1' => DrupalDateTime::createFromTimestamp(3600, $utc_tz, $settings),
        'input2' => NULL, 'input2' => NULL,
        'absolute' => FALSE, 'absolute' => FALSE,
        ], ],
        ......
        0% Loading or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Please register or to comment