Issue #3362453 by NickDickinsonWilde, Wim Leers, tim.plunkett, borisson_: Fix...

Issue #3362453 by NickDickinsonWilde, Wim Leers, tim.plunkett, borisson_: Fix all ConfigExists constraint violations in tests

core/lib/Drupal/Core/Config/Schema/SchemaCheckTrait.php

@@ -62,9 +62,6 @@ public function checkConfigSchema(TypedConfigManagerInterface $typed_config, $co
     // in the config schema tree to have validation constraints defined.
     $violations = $this->schema->validate();
     $ignored_validation_constraint_messages = [
-      // @see \Drupal\Core\Config\Plugin\Validation\Constraint\ConfigExistsConstraint::$message
-      // @todo Remove this in https://www.drupal.org/project/drupal/issues/3362453
-      "The '.*' config does not exist.",
       // @see \Drupal\Core\Extension\Plugin\Validation\Constraint\ExtensionExistsConstraint::$moduleMessage
       // @see \Drupal\Core\Extension\Plugin\Validation\Constraint\ExtensionExistsConstraint::$themeMessage
       // @todo Remove this in https://www.drupal.org/project/drupal/issues/3362456

core/modules/field/tests/src/Kernel/FieldKernelTestBase.php

@@ -61,7 +61,7 @@ protected function setUp(): void {
     $this->installEntitySchema('user');
 
     // Set default storage backend and configure the theme system.
-    $this->installConfig(['field', 'system']);
+    $this->installConfig(['field', 'system', 'user']);
 
     // Create user 1.
     $storage = \Drupal::entityTypeManager()->getStorage('user');

core/modules/field_ui/tests/src/Kernel/EntityFormDisplayTest.php

@@ -25,8 +25,9 @@ class EntityFormDisplayTest extends KernelTestBase {
     'field',
     'entity_test',
     'field_test',
-    'user',
+    'system',
     'text',
+    'user',
   ];
 
   /**
@@ -34,6 +35,8 @@ class EntityFormDisplayTest extends KernelTestBase {
    */
   protected function setUp(): void {
     parent::setUp();
+    $this->installEntitySchema('action');
+    $this->installConfig('user');
     $this->installEntitySchema('entity_test');
   }
 

core/modules/layout_builder/src/Entity/LayoutBuilderEntityViewDisplay.php

@@ -122,7 +122,6 @@ protected function setSections(array $sections) {
    * {@inheritdoc}
    */
   public function preSave(EntityStorageInterface $storage) {
-    parent::preSave($storage);
 
     $original_value = isset($this->original) ? $this->original->isOverridable() : FALSE;
     $new_value = $this->isOverridable();
@@ -138,6 +137,8 @@ public function preSave(EntityStorageInterface $storage) {
       }
     }
 
+    parent::preSave($storage);
+
     $already_enabled = isset($this->original) ? $this->original->isLayoutBuilderEnabled() : FALSE;
     $set_enabled = $this->isLayoutBuilderEnabled();
     if ($already_enabled !== $set_enabled) {

core/modules/system/tests/src/Kernel/Action/ActionTest.php

@@ -34,6 +34,7 @@ protected function setUp(): void {
 
     $this->actionManager = $this->container->get('plugin.manager.action');
     $this->installEntitySchema('user');
+    $this->installConfig('user');
   }
 
   /**

core/modules/text/tests/src/Kernel/TextItemBaseTest.php

@@ -69,6 +69,7 @@ public function testCalculateDependencies() {
       'format' => 'test_format',
       'name' => 'Test format',
     ]);
+    $format->save();
     $fieldName = mb_strtolower($this->randomMachineName());
     $field_storage = FieldStorageConfig::create([
       'field_name' => $fieldName,

core/modules/views/tests/src/Kernel/TestViewsTest.php

@@ -2,11 +2,17 @@
 
 namespace Drupal\Tests\views\Kernel;
 
+use Drupal\Core\Entity\Entity\EntityViewMode;
+use Drupal\Core\Field\FieldStorageDefinitionInterface;
+use Drupal\field\Entity\FieldStorageConfig;
+use Drupal\node\Entity\NodeType;
+use Drupal\taxonomy\Entity\Vocabulary;
 use Drupal\Tests\SchemaCheckTestTrait;
 use Drupal\config_test\TestInstallStorage;
 use Drupal\Core\Config\InstallStorage;
 use Drupal\Core\Config\TypedConfigManager;
 use Drupal\KernelTests\KernelTestBase;
+use Drupal\views\Tests\ViewTestData;
 
 /**
  * Tests that test views provided by all modules match schema.
@@ -22,7 +28,122 @@ class TestViewsTest extends KernelTestBase {
    *
    * @var array
    */
-  protected static $modules = ['views_test_data'];
+  protected static $modules = [
+    // `node.type.book` config entity is a config dependency.
+    // @see core/modules/book/tests/modules/book_test_views/test_views/views.view.test_book_view.yml
+    'book',
+    // For NodeType config entities to exist, its module must be installed.
+    // @see book_entity_type_build()
+    'node',
+    // The `DRUPAL_OPTIONAL` constant is used by the NodeType config entity type
+    // and only available if the system module is installed.
+    // `system.menu.tools` is a config dependency. It is one of the default
+    // config of the System module.
+    // @see \DRUPAL_OPTIONAL
+    // @see \Drupal\node\Entity\NodeType::$preview_mode
+    // @see core/modules/views/tests/modules/views_test_config/test_views/views.view.test_row_render_cache_none.yml
+    'system',
+    // There are a number of `field.storage.*.*` config dependencies. For these
+    // to be created, the Field module must be installed.
+    'field',
+    // Some of the `field.storage.*.*` config dependencies use the `link` field
+    // type. For fields of this type to be created the module must be installed.
+    // @see core/modules/link/tests/modules/link_test_views/test_views/views.view.test_link_tokens.yml
+    // @see \Drupal\Tests\link\Functional\Views\LinkViewsTokensTest
+    'link',
+    // `field.storage.node.body` config entity is a config dependency. It is one
+    // of the default config of the Node module. And it requires the
+    // `text_with_summary` field type, which is provided by the Text module.
+    // @see core/modules/node/tests/modules/node_test_views/test_views/views.view.test_node_tokens.yml
+    'text',
+    // For Vocabulary config entities to exist, its module must be installed.
+    'taxonomy',
+    // `user.role.authenticated` is a config dependency. It is one of the
+    // default config of the User module.
+    'user',
+    // `field.storage.entity_test.field_test` is a config dependency. It uses
+    // the `entity_type` content entity type, which is provided by the
+    // entity_test module.
+    // @see core/modules/views/tests/modules/views_test_config/test_views/views.view.test_field_field_attachment_test.yml
+    // @see \Drupal\Tests\views\Kernel\Handler\FieldFieldTest::setUp()
+    'entity_test',
+    'views_test_data',
+  ];
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function setUp(): void {
+    parent::setUp();
+    // `node.type.book` config entity is a config dependency.
+    // @see core/modules/book/tests/modules/book_test_views/test_views/views.view.test_book_view.yml
+    $this->installConfig('book');
+    // `field.storage.node.body` config entity is a config dependency. It is one
+    // of the default config of the Node module.
+    // @see core/modules/node/tests/modules/node_test_views/test_views/views.view.test_node_tokens.yml
+    $this->installConfig('node');
+    // `user.role.authenticated` is a config dependency. It is one of the
+    // default config of the User module.
+    // @see core/modules/views/tests/modules/views_test_config/test_views/views.view.test_feed_icon.yml
+    $this->installConfig('user');
+    // `system.menu.tools` is a config dependency. It is one of the default
+    // config of the System module.
+    // @see core/modules/views/tests/modules/views_test_config/test_views/views.view.test_row_render_cache_none.yml
+    $this->installConfig('system');
+    // `node.type.article` is a config dependency.
+    // @see core/modules/options/tests/options_test_views/test_views/views.view.test_options_list_argument_numeric.yml
+    NodeType::create(['type' => 'article'])->save();
+    // `node.type.page` is a config dependency.
+    // @see core/modules/views/tests/modules/views_test_config/test_views/views.view.test_argument_default_node.yml
+    NodeType::create(['type' => 'page'])->save();
+    // `taxonomy.vocabulary.tags` is a config dependency.
+    // @see core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_taxonomy_exposed_grouped_filter.yml
+    Vocabulary::create(['vid' => 'tags'])->save();
+    // `taxonomy.vocabulary.test_exposed_checkboxes` is a config dependency.
+    // @see core/modules/views/tests/modules/views_test_config/test_views/views.view.test_exposed_form_checkboxes.yml
+    Vocabulary::create(['vid' => 'test_exposed_checkboxes'])->save();
+    // `core.entity_view_mode.node.default` is a config dependency.
+    // @see core/modules/views/tests/modules/views_test_config/test_views/views.view.test_entity_field_renderered_entity.yml
+    EntityViewMode::create([
+      'id' => 'node.default',
+      'targetEntityType' => 'node',
+    ])->save();
+    // `field.storage.node.field_link` is a config dependency.
+    // @see core/modules/link/tests/modules/link_test_views/test_views/views.view.test_link_tokens.yml
+    // @see \Drupal\Tests\link\Functional\Views\LinkViewsTokensTest
+    FieldStorageConfig::create([
+      'field_name' => 'field_link',
+      'type' => 'link',
+      'entity_type' => 'node',
+      'cardinality' => 1,
+    ])->save();
+    // `field.storage.node.field_test` is a config dependency.
+    // @see core/modules/field/tests/modules/field_test_views/test_views/views.view.test_view_field_delete.yml
+    // @see \Drupal\Tests\field_ui\Functional\FieldUIDeleteTest::testDeleteField()
+    FieldStorageConfig::create([
+      'field_name' => 'field_test',
+      'type' => 'integer',
+      'entity_type' => 'node',
+    ])->save();
+    // `field.storage.entity_test.field_test` is a config dependency.
+    // @see core/modules/views/tests/modules/views_test_config/test_views/views.view.test_field_field_attachment_test.yml
+    // @see \Drupal\Tests\views\Kernel\Handler\FieldFieldTest::setUp()
+    FieldStorageConfig::create([
+      'field_name' => 'field_test',
+      'entity_type' => 'entity_test',
+      'type' => 'integer',
+    ])->save();
+    // `views.view.test_group_rows` is a config dependency.
+    // @see core/modules/views/tests/modules/views_test_config/test_views/views.view.test_group_rows.yml
+    // @see \Drupal\Tests\views\Functional\Handler\FieldGroupRowsWebTest::setUp()
+    FieldStorageConfig::create([
+      'field_name' => 'field_views_testing_group_rows',
+      'entity_type' => 'node',
+      'type' => 'text',
+      'cardinality' => FieldStorageDefinitionInterface::CARDINALITY_UNLIMITED,
+    ])->save();
+    ViewTestData::createTestViews(self::class, ['views_test_data']);
+  }
 
   /**
    * Tests default configuration data type.
@@ -38,6 +159,8 @@ public function testDefaultConfig() {
       \Drupal::service('class_resolver')
     );
     $typed_config->setValidationConstraintManager(\Drupal::service('validation.constraint'));
+    // Avoid restricting to the config schemas discovered.
+    $this->container->get('cache.discovery')->delete('typed_config_definitions');
 
     // Create a configuration storage with access to default configuration in
     // every module, profile and theme.

core/tests/Drupal/KernelTests/Core/Field/FieldSettingsTest.php

@@ -84,13 +84,14 @@ public function testConfigurableFieldStorageSettings() {
       'entity_type' => 'entity_test',
       'type' => 'test_field',
     ]);
-
+    $field_storage->save();
     // Check that the default settings have been populated.
     $expected_settings = [
       'test_field_storage_setting' => 'dummy test string',
       'changeable' => 'a changeable field storage setting',
       'unchangeable' => 'an unchangeable field storage setting',
       'translatable_storage_setting' => 'a translatable field storage setting',
+      'storage_setting_from_config_data' => 'TRUE',
     ];
     $this->assertEquals($expected_settings, $field_storage->getSettings());
 
@@ -111,6 +112,7 @@ public function testConfigurableFieldSettings() {
       'entity_type' => 'entity_test',
       'type' => 'test_field',
     ]);
+    $field_storage->save();
     $field = FieldConfig::create([
       'field_storage' => $field_storage,
       'bundle' => 'entity_test',
@@ -130,6 +132,7 @@ public function testConfigurableFieldSettings() {
       'test_field_setting' => 'dummy test string',
       'translatable_field_setting' => 'a translatable field setting',
       'field_setting_from_config_data' => 'TRUE',
+      'storage_setting_from_config_data' => 'TRUE',
     ];
     $this->assertEquals($expected_settings, $field->getSettings());