Skip to content
Snippets Groups Projects
Verified Commit a3f1255f authored by Lee Rowlands's avatar Lee Rowlands
Browse files

Issue #3410312 by catch: Flood database backend ::isAllowed() should call ::ensureTableExists()

parent 04900c3c
No related branches found
No related tags found
34 merge requests!12227Issue #3181946 by jonmcl, mglaman,!8528Issue #3456871 by Tim Bozeman: Support NULL services,!8323Fix source code editing and in place front page site studio editing.,!6278Issue #3187770 by godotislate, smustgrave, catch, quietone: Views Rendered...,!3878Removed unused condition head title for views,!38582585169-10.1.x,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3668Resolve #3347842 "Deprecate the trusted",!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3478Issue #3337882: Deleted menus are not removed from content type config,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3226Issue #2987537: Custom menu link entity type should not declare "bundle" entity key,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3147Issue #3328457: Replace most substr($a, $i) where $i is negative with str_ends_with(),!3146Issue #3328456: Replace substr($a, 0, $i) with str_starts_with(),!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2614Issue #2981326: Replace non-test usages of \Drupal::logger() with IoC injection,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!844Resolve #3036010 "Updaters",!673Issue #3214208: FinishResponseSubscriber could create duplicate headers,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #67121 passed with warnings
Stage: 🏗️ Build
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal

#67130

    Pipeline: drupal

    #67128

      Pipeline: drupal

      #67126

        Hide whitespace changes
        Inline Side-by-side
        core/lib/Drupal/Core/Flood/DatabaseBackend.php
        + 3
        − 1
        View file @ a3f1255f
        ......@@ -140,7 +140,9 @@ public function isAllowed($name, $threshold, $window = 3600, $identifier = NULL)
        return ($number < $threshold);
        }
        catch (\Exception $e) {
        $this->catchException($e);
        if (!$this->ensureTableExists()) {
        throw $e;
        }
        return TRUE;
        }
        }
        ......
        core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php
        + 7
        − 6
        View file @ a3f1255f
        ......@@ -60,7 +60,7 @@ public function testAnonymous() {
        // the highest and lowest number of observed during test runs.
        // See https://www.drupal.org/project/drupal/issues/3402610
        $this->assertGreaterThanOrEqual(58, $performance_data->getQueryCount());
        $this->assertLessThanOrEqual(67, $performance_data->getQueryCount());
        $this->assertLessThanOrEqual(68, $performance_data->getQueryCount());
        $this->assertGreaterThanOrEqual(129, $performance_data->getCacheGetCount());
        $this->assertLessThanOrEqual(132, $performance_data->getCacheGetCount());
        $this->assertGreaterThanOrEqual(59, $performance_data->getCacheSetCount());
        ......@@ -131,7 +131,7 @@ public function testLogin(): void {
        // random test failures, assert greater than equal the highest and lowest
        // number of queries observed during test runs.
        // See https://www.drupal.org/project/drupal/issues/3402610
        $this->assertLessThanOrEqual(42, $performance_data->getQueryCount());
        $this->assertLessThanOrEqual(39, $performance_data->getQueryCount());
        $this->assertGreaterThanOrEqual(39, $performance_data->getQueryCount());
        $this->assertSame(28, $performance_data->getCacheGetCount());
        $this->assertLessThanOrEqual(2, $performance_data->getCacheSetCount());
        ......@@ -163,14 +163,15 @@ public function testLoginBlock(): void {
        $performance_data = $this->collectPerformanceData(function () use ($account) {
        $this->submitLoginForm($account);
        });
        $this->assertLessThanOrEqual(51, $performance_data->getQueryCount());
        $this->assertLessThanOrEqual(50, $performance_data->getQueryCount());
        $this->assertGreaterThanOrEqual(48, $performance_data->getQueryCount());
        $this->assertSame(30, $performance_data->getCacheGetCount());
        // This test observes a variable number of cache sets, so to avoid random
        // This test observes a variable number of cache operations, so to avoid random
        // test failures, assert greater than equal the highest and lowest number
        // observed during test runs.
        // See https://www.drupal.org/project/drupal/issues/3402610
        $this->assertLessThanOrEqual(32, $performance_data->getCacheGetCount());
        $this->assertGreaterThanOrEqual(30, $performance_data->getCacheGetCount());
        $this->assertLessThanOrEqual(4, $performance_data->getCacheSetCount());
        $this->assertGreaterThanOrEqual(1, $performance_data->getCacheSetCount());
        $this->assertSame(1, $performance_data->getCacheDeleteCount());
        ......
        0% or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Please register or to comment