Skip to content
Snippets Groups Projects
Verified Commit a13dad16 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3397558 by mfb: OEmbed generates URLs with URL-decoded query string

(cherry picked from commit 5776f287)
parent 71b8f1cf
No related branches found
No related tags found
27 merge requests!11958Issue #3490507 by alexpott, smustgrave: Fix bogus mocking in...,!11769Issue #3517987: Add option to contextual filters to encode slashes in query parameter.,!11185Issue #3477324 by andypost, alexpott: Fix usage of str_getcsv() and fgetcsv() for PHP 8.4,!10602Issue #3438769 by vinmayiswamy, antonnavi, michelle, amateescu: Sub workspace does not clear,!10301Issue #3469309 by mstrelan, smustgrave, moshe weitzman: Use one-time login...,!10187Issue #3487488 by dakwamine: ExtensionMimeTypeGuesser::guessMimeType must support file names with "0" (zero) like foo.0.zip,!9944Issue #3483353: Consider making the createCopy config action optionally fail...,!9929Issue #3445469 by pooja_sharma, smustgrave: Add additional test coverage for...,!9787Resolve issue 3479427 - bootstrap barrio issue under Windows,!9742Issue #3463908 by catch, quietone: Split OptionsFieldUiTest into two,!9526Issue #3458177 by mondrake, catch, quietone, godotislate, longwave, larowlan,...,!8738Issue #3424162 by camilledavis, dineshkumarbollu, smustgrave: Claro...,!8704Make greek characters available in ckeditor5,!8597Draft: Issue #3442259 by catch, quietone, dww: Reduce time of Migrate Upgrade tests...,!8533Issue #3446962 by kim.pepper: Remove incorrectly added...,!8517Issue #3443748 by NexusNovaz, smustgrave: Testcase creates false positive,!8325Update file Sort.php,!8095Expose document root on install,!7930Resolve #3427374 "Taxonomytid viewsargumentdefault plugin",!7627Issue #3439440 by nicxvan, Binoli Lalani, longwave: Remove country support from DateFormatter,!7445Issue #3440169: When using drupalGet(), provide an associative array for $headers,!7401#3271894 Fix documented StreamWrapperInterface return types for realpath() and dirname(),!7384Add constraints to system.advisories,!6622Issue #2559833 by piggito, mohit_aghera, larowlan, guptahemant, vakulrai,...,!6502Draft: Resolve #2938524 "Plach testing issue",!38582585169-10.1.x,!3226Issue #2987537: Custom menu link entity type should not declare "bundle" entity key
Pipeline #127443 passed
Pipeline: drupal

#127446

    ......@@ -176,7 +176,7 @@ public function getResourceUrl($url, $max_width = NULL, $max_height = NULL) {
    // provide extra parameters in the query string. For example, Instagram also
    // supports the 'omitscript' parameter.
    $this->moduleHandler->alter('oembed_resource_url', $parsed_url, $provider);
    $resource_url = $parsed_url['path'] . '?' . rawurldecode(UrlHelper::buildQuery($parsed_url['query']));
    $resource_url = $parsed_url['path'] . '?' . UrlHelper::buildQuery($parsed_url['query']);
    $this->urlCache[$url] = $resource_url;
    $this->cacheBackend->set($cache_id, $resource_url);
    ......
    ......@@ -45,19 +45,19 @@ public static function providerEndpointMatching() {
    return [
    'match by endpoint: Twitter' => [
    'https://twitter.com/Dries/status/999985431595880448',
    'https://publish.twitter.com/oembed?url=https://twitter.com/Dries/status/999985431595880448',
    'https://publish.twitter.com/oembed?url=https%3A//twitter.com/Dries/status/999985431595880448',
    ],
    'match by endpoint: Vimeo' => [
    'https://vimeo.com/14782834',
    'https://vimeo.com/api/oembed.json?url=https://vimeo.com/14782834',
    'https://vimeo.com/api/oembed.json?url=https%3A//vimeo.com/14782834',
    ],
    'match by endpoint: Dailymotion' => [
    'https://www.dailymotion.com/video/x2vzluh',
    'https://www.dailymotion.com/services/oembed?url=https://www.dailymotion.com/video/x2vzluh',
    'https://www.dailymotion.com/services/oembed?url=https%3A//www.dailymotion.com/video/x2vzluh',
    ],
    'match by endpoint: Facebook' => [
    'https://www.facebook.com/facebook/videos/10153231379946729/',
    'https://www.facebook.com/plugins/video/oembed.json?url=https://www.facebook.com/facebook/videos/10153231379946729/',
    'https://www.facebook.com/plugins/video/oembed.json?url=https%3A//www.facebook.com/facebook/videos/10153231379946729/',
    ],
    ];
    }
    ......
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Please register or to comment