Skip to content
Snippets Groups Projects
Verified Commit 5776f287 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3397558 by mfb: OEmbed generates URLs with URL-decoded query string

parent a1699fe0
No related branches found
No related tags found
28 merge requests!11131[10.4.x-only-DO-NOT-MERGE]: Issue ##2842525 Ajax attached to Views exposed filter form does not trigger callbacks,!9470[10.3.x-only-DO-NOT-MERGE]: #3331771 Fix file_get_contents(): Passing null to parameter,!8540Issue #3457061: Bootstrap Modal dialog Not closing after 10.3.0 Update,!8528Issue #3456871 by Tim Bozeman: Support NULL services,!8373Issue #3427374 by danflanagan8, Vighneshh: taxonomy_tid ViewsArgumentDefault...,!7526Expose roles in response,!7352Draft: Resolve #3203489 "Set filename as",!3878Removed unused condition head title for views,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2794Issue #3100732: Allow specifying `meta` data on JSON:API objects,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #127502 passed
Stage: 🏗️ Build
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal

#127503

    Hide whitespace changes
    Inline Side-by-side
    core/modules/media/src/OEmbed/UrlResolver.php
    + 1
    − 1
    View file @ 5776f287
    ......@@ -176,7 +176,7 @@ public function getResourceUrl($url, $max_width = NULL, $max_height = NULL) {
    // provide extra parameters in the query string. For example, Instagram also
    // supports the 'omitscript' parameter.
    $this->moduleHandler->alter('oembed_resource_url', $parsed_url, $provider);
    $resource_url = $parsed_url['path'] . '?' . rawurldecode(UrlHelper::buildQuery($parsed_url['query']));
    $resource_url = $parsed_url['path'] . '?' . UrlHelper::buildQuery($parsed_url['query']);
    $this->urlCache[$url] = $resource_url;
    $this->cacheBackend->set($cache_id, $resource_url);
    ......
    core/modules/media/tests/src/Functional/UrlResolverTest.php
    + 4
    − 4
    View file @ 5776f287
    ......@@ -45,19 +45,19 @@ public static function providerEndpointMatching() {
    return [
    'match by endpoint: Twitter' => [
    'https://twitter.com/Dries/status/999985431595880448',
    'https://publish.twitter.com/oembed?url=https://twitter.com/Dries/status/999985431595880448',
    'https://publish.twitter.com/oembed?url=https%3A//twitter.com/Dries/status/999985431595880448',
    ],
    'match by endpoint: Vimeo' => [
    'https://vimeo.com/14782834',
    'https://vimeo.com/api/oembed.json?url=https://vimeo.com/14782834',
    'https://vimeo.com/api/oembed.json?url=https%3A//vimeo.com/14782834',
    ],
    'match by endpoint: Dailymotion' => [
    'https://www.dailymotion.com/video/x2vzluh',
    'https://www.dailymotion.com/services/oembed?url=https://www.dailymotion.com/video/x2vzluh',
    'https://www.dailymotion.com/services/oembed?url=https%3A//www.dailymotion.com/video/x2vzluh',
    ],
    'match by endpoint: Facebook' => [
    'https://www.facebook.com/facebook/videos/10153231379946729/',
    'https://www.facebook.com/plugins/video/oembed.json?url=https://www.facebook.com/facebook/videos/10153231379946729/',
    'https://www.facebook.com/plugins/video/oembed.json?url=https%3A//www.facebook.com/facebook/videos/10153231379946729/',
    ],
    ];
    }
    ......
    0% or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Finish editing this message first!
    Please register or to comment