Skip to content
Snippets Groups Projects
Verified Commit a0548804 authored by Dave Long's avatar Dave Long
Browse files

Issue #2507237 by dimitriskr, twistor, longwave, smustgrave: Replace...

Issue #2507237 by dimitriskr, twistor, longwave, smustgrave: Replace ReflectionClass::implementsInterface() with is_subclass_of()
parent 9089e7a9
No related branches found
No related tags found
28 merge requests!8528Issue #3456871 by Tim Bozeman: Support NULL services,!8323Fix source code editing and in place front page site studio editing.,!6278Issue #3187770 by godotislate, smustgrave, catch, quietone: Views Rendered...,!3878Removed unused condition head title for views,!38582585169-10.1.x,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3668Resolve #3347842 "Deprecate the trusted",!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3226Issue #2987537: Custom menu link entity type should not declare "bundle" entity key,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #76169 passed with warnings
Pipeline: drupal

#76181

    Pipeline: drupal

    #76180

      Pipeline: drupal

      #76175

        +1
        ......@@ -4,6 +4,7 @@
        use Symfony\Component\DependencyInjection\ContainerBuilder;
        use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
        use Symfony\Component\EventDispatcher\EventSubscriberInterface;
        /**
        * Registers all event subscribers to the event dispatcher.
        ......@@ -27,9 +28,8 @@ public function process(ContainerBuilder $container) {
        // the service is created by a factory.
        $class = $container->getDefinition($id)->getClass();
        $refClass = new \ReflectionClass($class);
        $interface = 'Symfony\Component\EventDispatcher\EventSubscriberInterface';
        if (!$refClass->implementsInterface($interface)) {
        $interface = EventSubscriberInterface::class;
        if (!is_subclass_of($class, $interface)) {
        throw new \InvalidArgumentException(sprintf('Service "%s" must implement interface "%s".', $id, $interface));
        }
        ......
        ......@@ -405,9 +405,7 @@ public function getFallbackCandidates(array $context = []) {
        public function getLanguageSwitchLinks($type, Url $url) {
        if ($this->negotiator) {
        foreach ($this->negotiator->getNegotiationMethods($type) as $method_id => $method) {
        $reflector = new \ReflectionClass($method['class']);
        if ($reflector->implementsInterface('\Drupal\language\LanguageSwitcherInterface')) {
        if (is_subclass_of($method['class'], LanguageSwitcherInterface::class)) {
        $original_languages = $this->negotiatedLanguages;
        $result = $this->negotiator->getNegotiationMethodInstance($method_id)->getLanguageSwitchLinks($this->requestStack->getCurrentRequest(), $type, $url);
        ......
        ......@@ -129,14 +129,13 @@ public function processOutbound($path, &$options = [], Request $request = NULL,
        * The scope of the processors: "inbound" or "outbound".
        */
        protected function initProcessors($scope) {
        $interface = '\Drupal\Core\PathProcessor\\' . Unicode::ucfirst($scope) . 'PathProcessorInterface';
        $interface = 'Drupal\Core\PathProcessor\\' . Unicode::ucfirst($scope) . 'PathProcessorInterface';
        $this->processors[$scope] = [];
        $weights = [];
        foreach ($this->languageManager->getLanguageTypes() as $type) {
        foreach ($this->negotiator->getNegotiationMethods($type) as $method_id => $method) {
        if (!isset($this->processors[$scope][$method_id])) {
        $reflector = new \ReflectionClass($method['class']);
        if ($reflector->implementsInterface($interface)) {
        if (is_subclass_of($method['class'], $interface)) {
        $this->processors[$scope][$method_id] = $this->negotiator->getNegotiationMethodInstance($method_id);
        $weights[$method_id] = $method['weight'];
        }
        ......
        0% Loading or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Finish editing this message first!
        Please register or to comment