Skip to content
Snippets Groups Projects
Verified Commit 93c65749 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3454212 by nathankg, joachim: Update mentions of #2225961 in comments 

(cherry picked from commit d246c433)
parent 2afadf48
No related branches found
No related tags found
15 merge requests!10602Issue #3438769 by vinmayiswamy, antonnavi, michelle, amateescu: Sub workspace does not clear,!10301Issue #3469309 by mstrelan, smustgrave, moshe weitzman: Use one-time login...,!10187Issue #3487488 by dakwamine: ExtensionMimeTypeGuesser::guessMimeType must support file names with "0" (zero) like foo.0.zip,!9929Issue #3445469 by pooja_sharma, smustgrave: Add additional test coverage for...,!9787Resolve issue 3479427 - bootstrap barrio issue under Windows,!9742Issue #3463908 by catch, quietone: Split OptionsFieldUiTest into two,!9526Issue #3458177 by mondrake, catch, quietone, godotislate, longwave, larowlan,...,!8949Backport .gitlabci.yml changes.,!8738Issue #3424162 by camilledavis, dineshkumarbollu, smustgrave: Claro...,!8704Make greek characters available in ckeditor5,!8533Issue #3446962 by kim.pepper: Remove incorrectly added...,!8517Issue #3443748 by NexusNovaz, smustgrave: Testcase creates false positive,!6502Draft: Resolve #2938524 "Plach testing issue",!38582585169-10.1.x,!3226Issue #2987537: Custom menu link entity type should not declare "bundle" entity key
Pipeline #200748 passed
Stage: 🏗️ Build
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal

#200782

    Pipeline: drupal

    #200772

      Pipeline: drupal

      #200761

        +1
        Hide whitespace changes
        Inline Side-by-side
        core/lib/Drupal/Core/Entity/EntityFieldManager.php
        + 5
        − 5
        View file @ 93c65749
        ......@@ -277,7 +277,7 @@ protected function buildBaseFieldDefinitions($entity_type_id) {
        $provider = $entity_type->getProvider();
        foreach ($base_field_definitions as $definition) {
        // @todo Remove this check once FieldDefinitionInterface exposes a proper
        // provider setter. See https://www.drupal.org/node/2225961.
        // provider setter. See https://www.drupal.org/node/2346329.
        if ($definition instanceof BaseFieldDefinition) {
        $definition->setProvider($provider);
        }
        ......@@ -292,7 +292,7 @@ function (callable $hook, string $module) use (&$base_field_definitions, $entity
        // defining the field.
        foreach ($module_definitions as $field_name => $definition) {
        // @todo Remove this check once FieldDefinitionInterface exposes a
        // proper provider setter. See https://www.drupal.org/node/2225961.
        // proper provider setter. See https://www.drupal.org/node/2346329.
        if ($definition instanceof BaseFieldDefinition && $definition->getProvider() == NULL) {
        $definition->setProvider($module);
        }
        ......@@ -402,7 +402,7 @@ protected function buildBundleFieldDefinitions($entity_type_id, $bundle, array $
        $provider = $entity_type->getProvider();
        foreach ($bundle_field_definitions as $definition) {
        // @todo Remove this check once FieldDefinitionInterface exposes a proper
        // provider setter. See https://www.drupal.org/node/2225961.
        // provider setter. See https://www.drupal.org/node/2346329.
        if ($definition instanceof BaseFieldDefinition) {
        $definition->setProvider($provider);
        }
        ......@@ -417,7 +417,7 @@ function (callable $hook, string $module) use (&$bundle_field_definitions, $enti
        // defining the field.
        foreach ($module_definitions as $field_name => $definition) {
        // @todo Remove this check once FieldDefinitionInterface exposes a
        // proper provider setter. See https://www.drupal.org/node/2225961.
        // proper provider setter. See https://www.drupal.org/node/2346329.
        if ($definition instanceof BaseFieldDefinition) {
        $definition->setProvider($module);
        }
        ......@@ -594,7 +594,7 @@ function (callable $hook, string $module) use (&$field_definitions, $entity_type
        // defining the field.
        foreach ($module_definitions as $field_name => $definition) {
        // @todo Remove this check once FieldDefinitionInterface exposes a
        // proper provider setter. See https://www.drupal.org/node/2225961.
        // proper provider setter. See https://www.drupal.org/node/2346329.
        if ($definition instanceof BaseFieldDefinition) {
        $definition->setProvider($module);
        $definition->setName($field_name);
        ......
        core/tests/Drupal/Tests/Core/Entity/EntityFieldManagerTest.php
        + 1
        − 1
        View file @ 93c65749
        ......@@ -548,7 +548,7 @@ public function testGetFieldDefinitionsProvider() {
        $module = 'entity_field_manager_test_module';
        // @todo Mock FieldDefinitionInterface once it exposes a proper provider
        // setter. See https://www.drupal.org/node/2225961.
        // setter. See https://www.drupal.org/node/2346329.
        $field_definition = $this->prophesize(BaseFieldDefinition::class);
        // We expect two calls as the field definition will be returned from both
        ......
        0% or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Please register or to comment