Skip to content
Snippets Groups Projects
Commit 8e71d465 authored by catch's avatar catch
Browse files

Issue #3320025 by alexpott, longwave: Make PHPStan baseline the same in 10.1.x and 10.0.x

parent b2bc383e
No related branches found
No related tags found
36 merge requests!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!4289Issue #1344552 by marcingy, Niklas Fiekas, Ravi.J, aleevas, Eduardo Morales...,!4114Issue #2707291: Disable body-level scrolling when a dialog is open as a modal,!4100Issue #3249600: Add support for PHP 8.1 Enums as allowed values for list_* data types,!3630Issue #2815301 by Chi, DanielVeza, kostyashupenko, smustgrave: Allow to create...,!3600Issue #3344629: Passing null to parameter #1 ($haystack) of type string is deprecated,!3291Issue #3336463: Rewrite rules for gzipped CSS and JavaScript aggregates never match,!3102Issue #3164428 by DonAtt, longwave, sahil.goyal, Anchal_gupta, alexpott: Use...,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2074Issue #2707689: NodeForm::actions() checks for delete access on new entities,!2062Issue #3246454: Add weekly granularity to views date sort,!1591Issue #3199697: Add JSON:API Translation experimental module,!1484Exposed filters get values from URL when Ajax is on,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1254Issue #3238915: Refactor (if feasible) uses of the jQuery ready function to use VanillaJS,!1162Issue #3100350: Unable to save '/' root path alias,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!957Added throwing of InvalidPluginDefinitionException from getDefinition().,!925Issue #2339235: Remove taxonomy hard dependency on node module,!877Issue #2708101: Default value for link text is not saved,!873Issue #2875228: Site install not using batch API service,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!844Resolve #3036010 "Updaters",!712Issue #2909128: Autocomplete intermittent on Chrome Android,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
Hide whitespace changes
Inline Side-by-side
Showing
with 9 additions and 32 deletions
core/lib/Drupal/Core/Ajax/AjaxResponseAttachmentsProcessor.php
+ 2
− 2
View file @ 8e71d465
......@@ -88,10 +88,10 @@ class AjaxResponseAttachmentsProcessor implements AttachmentsResponseProcessorIn
* The renderer.
* @param \Drupal\Core\Extension\ModuleHandlerInterface $module_handler
* The module handler.
* @param \Drupal\Core\Language\LanguageManagerInterface $languageManager
* @param \Drupal\Core\Language\LanguageManagerInterface|null $languageManager
* The language manager.
*/
public function __construct(AssetResolverInterface $asset_resolver, ConfigFactoryInterface $config_factory, AssetCollectionRendererInterface $css_collection_renderer, AssetCollectionRendererInterface $js_collection_renderer, RequestStack $request_stack, RendererInterface $renderer, ModuleHandlerInterface $module_handler, protected LanguageManagerInterface $languageManager) {
public function __construct(AssetResolverInterface $asset_resolver, ConfigFactoryInterface $config_factory, AssetCollectionRendererInterface $css_collection_renderer, AssetCollectionRendererInterface $js_collection_renderer, RequestStack $request_stack, RendererInterface $renderer, ModuleHandlerInterface $module_handler, protected ?LanguageManagerInterface $languageManager = NULL) {
$this->assetResolver = $asset_resolver;
$this->config = $config_factory->get('system.performance');
$this->cssCollectionRenderer = $css_collection_renderer;
......
core/lib/Drupal/Core/Asset/CssCollectionOptimizer.php
+ 1
− 1
View file @ 8e71d465
......@@ -206,7 +206,7 @@ public function deleteAll() {
$delete_stale = function ($uri) {
// Default stale file threshold is 30 days.
if (REQUEST_TIME - filemtime($uri) > \Drupal::config('system.performance')->get('stale_file_threshold')) {
if (\Drupal::time()->getRequestTime() - filemtime($uri) > \Drupal::config('system.performance')->get('stale_file_threshold')) {
$this->fileSystem->delete($uri);
}
};
......
core/lib/Drupal/Core/Asset/JsCollectionOptimizer.php
+ 1
− 1
View file @ 8e71d465
......@@ -204,7 +204,7 @@ public function deleteAll() {
$this->state->delete('system.js_cache_files');
$delete_stale = function ($uri) {
// Default stale file threshold is 30 days.
if (REQUEST_TIME - filemtime($uri) > \Drupal::config('system.performance')->get('stale_file_threshold')) {
if (\Drupal::time()->getRequestTime() - filemtime($uri) > \Drupal::config('system.performance')->get('stale_file_threshold')) {
$this->fileSystem->delete($uri);
}
};
......
core/lib/Drupal/Core/Entity/Form/RevisionRevertForm.php
+ 1
− 1
View file @ 8e71d465
......@@ -165,7 +165,7 @@ public function submitForm(array &$form, FormStateInterface $form_state) {
$this->revision = $this->prepareRevision($this->revision, $form_state);
if ($this->revision instanceof RevisionLogInterface) {
if (isset($originalRevisionTimestamp)) {
$date = $this->dateFormatter->format($originalRevisionTimestamp);
$this->messenger->addMessage($this->t('@type %title has been reverted to the revision from %revision-date.', [
'@type' => $bundleLabel,
......
core/lib/Drupal/Core/Render/HtmlResponseAttachmentsProcessor.php
+ 2
− 2
View file @ 8e71d465
......@@ -98,10 +98,10 @@ class HtmlResponseAttachmentsProcessor implements AttachmentsResponseProcessorIn
* The renderer.
* @param \Drupal\Core\Extension\ModuleHandlerInterface $module_handler
* The module handler service.
* @param \Drupal\Core\Language\LanguageManagerInterface $languageManager
* @param \Drupal\Core\Language\LanguageManagerInterface|null $languageManager
* The language manager.
*/
public function __construct(AssetResolverInterface $asset_resolver, ConfigFactoryInterface $config_factory, AssetCollectionRendererInterface $css_collection_renderer, AssetCollectionRendererInterface $js_collection_renderer, RequestStack $request_stack, RendererInterface $renderer, ModuleHandlerInterface $module_handler, protected LanguageManagerInterface $languageManager) {
public function __construct(AssetResolverInterface $asset_resolver, ConfigFactoryInterface $config_factory, AssetCollectionRendererInterface $css_collection_renderer, AssetCollectionRendererInterface $js_collection_renderer, RequestStack $request_stack, RendererInterface $renderer, ModuleHandlerInterface $module_handler, protected ?LanguageManagerInterface $languageManager = NULL) {
$this->assetResolver = $asset_resolver;
$this->config = $config_factory->get('system.performance');
$this->cssCollectionRenderer = $css_collection_renderer;
......
core/phpstan-baseline.neon
+ 0
− 20
View file @ 8e71d465
......@@ -245,11 +245,6 @@ parameters:
count: 1
path: lib/Drupal/Core/Action/ActionManager.php
-
message: "#^Variable \\$languageManager in isset\\(\\) always exists and is not nullable\\.$#"
count: 1
path: lib/Drupal/Core/Ajax/AjaxResponseAttachmentsProcessor.php
-
message: "#^Method Drupal\\\\Core\\\\Archiver\\\\ArchiverManager\\:\\:getInstance\\(\\) should return object\\|false but return statement is missing\\.$#"
count: 1
......@@ -455,11 +450,6 @@ parameters:
count: 2
path: lib/Drupal/Core/Entity/EntityDisplayBase.php
-
message: "#^Variable \\$originalRevisionTimestamp might not be defined\\.$#"
count: 1
path: lib/Drupal/Core/Entity/Form/RevisionRevertForm.php
-
message: "#^Method Drupal\\\\Core\\\\Entity\\\\KeyValueStore\\\\KeyValueContentEntityStorage\\:\\:createTranslation\\(\\) should return Drupal\\\\Core\\\\Entity\\\\ContentEntityInterface but return statement is missing\\.$#"
count: 1
......@@ -725,11 +715,6 @@ parameters:
count: 1
path: lib/Drupal/Core/Render/Element/RenderElement.php
-
message: "#^Variable \\$languageManager in isset\\(\\) always exists and is not nullable\\.$#"
count: 1
path: lib/Drupal/Core/Render/HtmlResponseAttachmentsProcessor.php
-
message: "#^Variable \\$output in empty\\(\\) always exists and is not falsy\\.$#"
count: 1
......@@ -3570,11 +3555,6 @@ parameters:
count: 52
path: tests/Drupal/Tests/Core/Assert/WebAssertArgumentsTest.php
-
message: "#^Class Drupal\\\\Core\\\\Asset\\\\CssCollectionOptimizer constructor invoked with 6 parameters, 5 required\\.$#"
count: 2
path: tests/Drupal/Tests/Core/Asset/CssCollectionOptimizerUnitTest.php
-
message: "#^Class Drupal\\\\Core\\\\Asset\\\\LibraryDiscovery constructor invoked with 2 parameters, 1 required\\.$#"
count: 1
......
core/tests/Drupal/Tests/Core/Asset/CssCollectionOptimizerUnitTest.php
+ 2
− 5
View file @ 8e71d465
......@@ -2,7 +2,6 @@
namespace Drupal\Tests\Core\Asset;
use Drupal\Component\Datetime\TimeInterface;
use Drupal\Core\Asset\AssetCollectionGrouperInterface;
use Drupal\Core\Asset\AssetDumperInterface;
use Drupal\Core\Asset\AssetOptimizerInterface;
......@@ -62,8 +61,7 @@ public function testCssImport() {
});
$mock_state = $this->createMock(StateInterface::class);
$mock_file_system = $this->createMock(FileSystemInterface::class);
$mock_time = $this->createMock(TimeInterface::class);
$this->optimizer = new CssCollectionOptimizer($mock_grouper, $mock_optimizer, $mock_dumper, $mock_state, $mock_file_system, $mock_time);
$this->optimizer = new CssCollectionOptimizer($mock_grouper, $mock_optimizer, $mock_dumper, $mock_state, $mock_file_system);
$gpl_license = [
'name' => 'GNU-GPL-2.0-or-later',
'url' => 'https://www.drupal.org/licensing/faq',
......@@ -121,8 +119,7 @@ public function testCssLicenseAggregation() {
});
$mock_state = $this->createMock(StateInterface::class);
$mock_file_system = $this->createMock(FileSystemInterface::class);
$mock_time = $this->createMock(TimeInterface::class);
$this->optimizer = new CssCollectionOptimizer($mock_grouper, $mock_optimizer, $mock_dumper, $mock_state, $mock_file_system, $mock_time);
$this->optimizer = new CssCollectionOptimizer($mock_grouper, $mock_optimizer, $mock_dumper, $mock_state, $mock_file_system);
$gpl_license = [
'name' => 'GNU-GPL-2.0-or-later',
'url' => 'https://www.drupal.org/licensing/faq',
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment