Skip to content
Snippets Groups Projects
Verified Commit 79980296 authored by Théodore Biadala's avatar Théodore Biadala
Browse files

Issue #3443461 by Gauravvvv, Mithun S, finnsky, ckrina: escapeAdmin.js... 

Issue #3443461 by Gauravvvv, Mithun S, finnsky, ckrina: escapeAdmin.js functionality should be removed(it not used anymore)
parent fe3721e8
No related branches found
No related tags found
31 merge requests!11131[10.4.x-only-DO-NOT-MERGE]: Issue ##2842525 Ajax attached to Views exposed filter form does not trigger callbacks,!9470[10.3.x-only-DO-NOT-MERGE]: #3331771 Fix file_get_contents(): Passing null to parameter,!8736Update the Documention As per the Function uses.,!8540Issue #3457061: Bootstrap Modal dialog Not closing after 10.3.0 Update,!8528Issue #3456871 by Tim Bozeman: Support NULL services,!8513Issue #3453786: DefaultSelection should document why values for target_bundles NULL and [] behave as they do,!8373Issue #3427374 by danflanagan8, Vighneshh: taxonomy_tid ViewsArgumentDefault...,!8256Issue #3445896 by mstrelan, mondrake: PHPUnit\Runner\ErrorHandler::__construct...,!8126Added escape fucntionality on admintoolbar close icon,!8012Expand RecipeDiscovery to return a list of recipes from recipe directories - Issue # 3446354,!7927Issue #3445425: \Drupal\Core\Template\Attribute should implement Countable interface,!3878Removed unused condition head title for views,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #169644 passed with warnings
Stage: 🏗️ Build
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal

#169648

    Hide whitespace changes
    Inline Side-by-side
    core/modules/navigation/js/escapeAdmin.js deleted 100644 → 0
    + 0
    − 67
    View file @ fe3721e8
    /**
    * @file
    * Replaces the home link in toolbar with a back to site link.
    */
    ((Drupal, drupalSettings, once) => {
    /**
    * Information about the current page path.
    *
    * @type {object}
    */
    const pathInfo = drupalSettings.path;
    /**
    * The last non-administrative page visited in the current browser tab.
    *
    * @type {string}
    */
    const escapeAdminPath = sessionStorage.getItem('escapeAdminPath');
    /**
    * The window object representing the current browser tab.
    *
    * @type {Window}
    */
    const windowLocation = window.location;
    // Saves the last non-administrative page in the browser to be able to link
    // back to it when browsing administrative pages. If there is a destination
    // parameter there is not need to save the current path because the page is
    // loaded within an existing "workflow".
    if (
    !pathInfo.currentPathIsAdmin &&
    !/destination=/.test(windowLocation.search)
    ) {
    sessionStorage.setItem('escapeAdminPath', windowLocation);
    }
    /**
    * Replaces "Back to site" link url when appropriate.
    *
    * Back to site link points to the last non-administrative page the user
    * visited within the same browser tab.
    *
    * @type {Drupal~behavior}
    *
    * @prop {Drupal~behaviorAttach} attach
    * Attaches the replacement functionality to the toolbar-escape-admin element.
    */
    Drupal.behaviors.escapeAdmin = {
    attach() {
    /**
    * Element with the data-toolbar-escape-admin attribute.
    *
    * @type {HTMLElement}
    */
    const toolbarEscape = once('escapeAdmin', '[data-toolbar-escape-admin]');
    if (
    toolbarEscape.length &&
    pathInfo.currentPathIsAdmin &&
    escapeAdminPath !== null
    ) {
    toolbarEscape[0].setAttribute('href', escapeAdminPath);
    }
    },
    };
    })(Drupal, drupalSettings, once);
    core/modules/navigation/navigation.libraries.yml
    + 0
    − 13
    View file @ 79980296
    ......@@ -33,22 +33,9 @@ admin-reset-styles:
    base:
    css/base/admin-reset-styles.css: {}
    internal.navigation.escapeAdmin:
    # Internal library. Do not depend on it outside core nor add core usage
    # beyond the Navigation module.
    version: VERSION
    js:
    js/escapeAdmin.js: {}
    dependencies:
    - core/drupal
    - core/drupalSettings
    - core/once
    - core/drupal.displace
    navigation.layout:
    dependencies:
    - navigation/internal.navigation
    - navigation/internal.navigation.escapeAdmin
    body-scroll-lock:
    version: VERSION
    ......
    0% or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Finish editing this message first!
    Please register or to comment