Skip to content
Snippets Groups Projects
Verified Commit 74d72efa authored by Théodore Biadala's avatar Théodore Biadala
Browse files

Issue #3396099 by Utkarsh_33, nod_, Gauravvvv, bnjmnm, tedbow, smustgrave,...

Issue #3396099 by Utkarsh_33, nod_, Gauravvvv, bnjmnm, tedbow, smustgrave, Anybody, Rob230: The core/drupal.message library requires a status_messages render element
parent 3e3b4953
Branches
Tags
25 merge requests!11131[10.4.x-only-DO-NOT-MERGE]: Issue ##2842525 Ajax attached to Views exposed filter form does not trigger callbacks,!9470[10.3.x-only-DO-NOT-MERGE]: #3331771 Fix file_get_contents(): Passing null to parameter,!8736Update the Documention As per the Function uses.,!8528Issue #3456871 by Tim Bozeman: Support NULL services,!8513Issue #3453786: DefaultSelection should document why values for target_bundles NULL and [] behave as they do,!8126Added escape fucntionality on admintoolbar close icon,!3878Removed unused condition head title for views,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #209507 canceled
Pipeline: drupal

#209509

    ......@@ -37,13 +37,27 @@
    * The default destination for JavaScript messages.
    */
    static defaultWrapper() {
    let wrapper = document.querySelector('[data-drupal-messages]');
    // Search for the element with '[data-drupal-messages]' selector.
    // If not found then only try to search for fallback element.
    let wrapper =
    document.querySelector('[data-drupal-messages]') ||
    document.querySelector('[data-drupal-messages-fallback]');
    if (!wrapper) {
    wrapper = document.querySelector('[data-drupal-messages-fallback]');
    // If no status messages element is found, a fallback element is created to prevent
    // execution-breaking JS errors when attempting to report a problem.
    // This scenario can occur on any page that does not include a status_messages
    // render element.
    wrapper = document.createElement('div');
    document.body.appendChild(wrapper);
    }
    if (wrapper.hasAttribute('data-drupal-messages-fallback')) {
    // Remove the fallback attribute if it exists.
    wrapper.removeAttribute('data-drupal-messages-fallback');
    wrapper.setAttribute('data-drupal-messages', '');
    wrapper.classList.remove('hidden');
    }
    wrapper.setAttribute('data-drupal-messages', '');
    return wrapper.innerHTML === ''
    ? Drupal.Message.messageInternalWrapper(wrapper)
    : wrapper.firstElementChild;
    ......
    ......@@ -58,19 +58,6 @@ public function batchPage(Request $request) {
    return $output;
    }
    elseif (isset($output)) {
    // Directly render a status message placeholder without any messages.
    // Messages are not intended to be show on the batch page, but in the
    // event an error in a AJAX callback the messages will be displayed.
    // @todo Remove in https://drupal.org/i/3396099.
    $output['batch_messages'] = [
    '#theme' => 'status_messages',
    '#message_list' => [],
    '#status_headings' => [
    'status' => $this->t('Status message'),
    'error' => $this->t('Error message'),
    'warning' => $this->t('Warning message'),
    ],
    ];
    $title = $output['#title'] ?? NULL;
    $page = [
    '#type' => 'page',
    ......
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Please register or to comment