Skip to content
Snippets Groups Projects
Commit 63df811e authored by catch's avatar catch
Browse files

Issue #3386682 by Spokje: [random test failure] MenuUiTest::testMenuAdministration

parent f33c99a1
No related branches found
No related tags found
42 merge requests!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!3878Removed unused condition head title for views,!38582585169-10.1.x,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3668Resolve #3347842 "Deprecate the trusted",!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3546refactored dialog.pcss file,!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3502Issue #3335308: Confusing behavior with FormState::setFormState and FormState::setMethod,!3452Issue #3332701: Refactor Claro's tablesort-indicator stylesheet,!3451Issue #2410579: Allows setting the current language programmatically.,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3226Issue #2987537: Custom menu link entity type should not declare "bundle" entity key,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3147Issue #3328457: Replace most substr($a, $i) where $i is negative with str_ends_with(),!3146Issue #3328456: Replace substr($a, 0, $i) with str_starts_with(),!3133core/modules/system/css/components/hidden.module.css,!31312878513-10.1.x,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2614Issue #2981326: Replace non-test usages of \Drupal::logger() with IoC injection,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2062Issue #3246454: Add weekly granularity to views date sort,!1591Issue #3199697: Add JSON:API Translation experimental module,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!844Resolve #3036010 "Updaters",!673Issue #3214208: FinishResponseSubscriber could create duplicate headers,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
Pipeline #21227 canceled
Stage: 🏗️ Build
Stage: 🪄 Lint
Stage: 🗜️ Test
Hide whitespace changes
Inline Side-by-side
core/modules/menu_ui/tests/src/Functional/MenuUiTest.php
+ 27
− 17
View file @ 63df811e
...@@ -186,30 +186,40 @@ public function testMenuAdministration() { ...@@ -186,30 +186,40 @@ public function testMenuAdministration() {
} }
// Test alphabetical order without pager. // Test alphabetical order without pager.
$menus = []; $menu_entities = [];
for ($i = 1; $i < 6; $i++) { for ($i = 1; $i < 6; $i++) {
$menus[] = strtolower($this->getRandomGenerator()->name()); $menu = strtolower($this->getRandomGenerator()->name());
} $menu_entity = Menu::create(['id' => $menu, 'label' => $menu]);
sort($menus); $menu_entities[] = $menu_entity;
foreach ($menus as $menu) { $menu_entity->save();
Menu::create(['id' => $menu, 'label' => $menu])->save();
} }
uasort($menu_entities, [Menu::class, 'sort']);
$menu_entities = array_values($menu_entities);
$this->drupalGet('/admin/structure/menu'); $this->drupalGet('/admin/structure/menu');
$base_path = parse_url($this->baseUrl, PHP_URL_PATH) ?? ''; $base_path = parse_url($this->baseUrl, PHP_URL_PATH) ?? '';
$first_link = $this->assertSession()->elementExists('css', 'tbody tr:nth-of-type(1) a'); $first_link = $this->assertSession()->elementExists('css', 'tbody tr:nth-of-type(1) a');
$last_link = $this->assertSession()->elementExists('css', 'tbody tr:nth-of-type(5) a'); $last_link = $this->assertSession()->elementExists('css', 'tbody tr:nth-of-type(5) a');
$this->assertEquals($first_link->getAttribute('href'), sprintf('%s/admin/structure/menu/manage/%s', $base_path, $menus[0])); $this->assertEquals($first_link->getAttribute('href'), sprintf('%s/admin/structure/menu/manage/%s', $base_path, $menu_entities[0]->label()));
$this->assertEquals($last_link->getAttribute('href'), sprintf('%s/admin/structure/menu/manage/%s', $base_path, $menus[4])); $this->assertEquals($last_link->getAttribute('href'), sprintf('%s/admin/structure/menu/manage/%s', $base_path, $menu_entities[4]->label()));
// Test alphabetical order with pager. // Test alphabetical order with pager.
$new_menus = []; $new_menu_entities = [];
for ($i = 1; $i < 61; $i++) { for ($i = 1; $i < 61; $i++) {
$new_menus[] = strtolower($this->getRandomGenerator()->name()); $new_menu = strtolower($this->getRandomGenerator()->name());
} $new_menu_entity = Menu::create(['id' => $new_menu, 'label' => $new_menu]);
foreach ($new_menus as $menu) { $new_menu_entities[] = $new_menu_entity;
Menu::create(['id' => $menu, 'label' => $menu])->save(); $new_menu_entity->save();
} }
$menus = array_merge($menus, $new_menus); $menu_entities = array_merge($menu_entities, $new_menu_entities);
sort($menus);
// To accommodate the current non-natural sorting of the pager, we have to
// first non-natural sort the array of menu entities, and then do a
// natural-sort on the ones that are on page 1.
sort($menu_entities);
$menu_entities_page_one = array_slice($menu_entities, 50, 64, TRUE);
uasort($menu_entities_page_one, [Menu::class, 'sort']);
$menu_entities_page_one = array_values($menu_entities_page_one);
$this->drupalGet('/admin/structure/menu', [ $this->drupalGet('/admin/structure/menu', [
'query' => [ 'query' => [
'page' => 1, 'page' => 1,
...@@ -217,8 +227,8 @@ public function testMenuAdministration() { ...@@ -217,8 +227,8 @@ public function testMenuAdministration() {
]); ]);
$first_link = $this->assertSession()->elementExists('css', 'tbody tr:nth-of-type(1) a'); $first_link = $this->assertSession()->elementExists('css', 'tbody tr:nth-of-type(1) a');
$last_link = $this->assertSession()->elementExists('css', 'tbody tr:nth-of-type(15) a'); $last_link = $this->assertSession()->elementExists('css', 'tbody tr:nth-of-type(15) a');
$this->assertEquals($first_link->getAttribute('href'), sprintf('%s/admin/structure/menu/manage/%s', $base_path, $menus[50])); $this->assertEquals($first_link->getAttribute('href'), sprintf('%s/admin/structure/menu/manage/%s', $base_path, $menu_entities_page_one[0]->label()));
$this->assertEquals($last_link->getAttribute('href'), sprintf('%s/admin/structure/menu/manage/%s', $base_path, $menus[64])); $this->assertEquals($last_link->getAttribute('href'), sprintf('%s/admin/structure/menu/manage/%s', $base_path, $menu_entities_page_one[14]->label()));
} }
/** /**
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment