Skip to content
Snippets Groups Projects
Unverified Commit 331e284e authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3092430 by quietone, shrutidkadam, RdeBoer, bgprior, danflanagan8:...

Issue #3092430 by quietone, shrutidkadam, RdeBoer, bgprior, danflanagan8: Ensure SearchPlugin has a configuration array
parent 20f3c89d
No related branches found
No related tags found
38 merge requests!7471uncessary 5 files are moved from media-library folder to misc folder,!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!4289Issue #1344552 by marcingy, Niklas Fiekas, Ravi.J, aleevas, Eduardo Morales...,!4114Issue #2707291: Disable body-level scrolling when a dialog is open as a modal,!3630Issue #2815301 by Chi, DanielVeza, kostyashupenko, smustgrave: Allow to create...,!3291Issue #3336463: Rewrite rules for gzipped CSS and JavaScript aggregates never match,!3143Issue #3313342: [PHP 8.1] Deprecated function: strpos(): Passing null to parameter #1 LayoutBuilderUiCacheContext.php on line 28,!3102Issue #3164428 by DonAtt, longwave, sahil.goyal, Anchal_gupta, alexpott: Use...,!2853#3274419 Makes BaseFieldOverride inherit the internal property from the base field.,!2719Issue #3110137: Remove Classy from core.,!2437Issue #3238257 by hooroomoo, Wim Leers: Fragment link pointing to <textarea>...,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2074Issue #2707689: NodeForm::actions() checks for delete access on new entities,!2062Issue #3246454: Add weekly granularity to views date sort,!1974Issue #3036862 demonstration,!1591Issue #3199697: Add JSON:API Translation experimental module,!1484Exposed filters get values from URL when Ajax is on,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1254Issue #3238915: Refactor (if feasible) uses of the jQuery ready function to use VanillaJS,!1162Issue #3100350: Unable to save '/' root path alias,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!957Added throwing of InvalidPluginDefinitionException from getDefinition().,!925Issue #2339235: Remove taxonomy hard dependency on node module,!877Issue #2708101: Default value for link text is not saved,!873Issue #2875228: Site install not using batch API service,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!844Resolve #3036010 "Updaters",!712Issue #2909128: Autocomplete intermittent on Chrome Android,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
...@@ -41,6 +41,9 @@ process: ...@@ -41,6 +41,9 @@ process:
- module - module
- 'constants/suffix' - 'constants/suffix'
path: module path: module
configuration:
plugin: default_value
default_value: [ ]
'configuration/rankings': 'configuration/rankings':
plugin: search_configuration_rankings plugin: search_configuration_rankings
destination: destination:
......
...@@ -21,6 +21,9 @@ process: ...@@ -21,6 +21,9 @@ process:
id: 'constants/id' id: 'constants/id'
path: 'constants/path' path: 'constants/path'
plugin: 'constants/plugin' plugin: 'constants/plugin'
configuration:
plugin: default_value
default_value: [ ]
'configuration/rankings': 'configuration/rankings':
plugin: search_configuration_rankings plugin: search_configuration_rankings
destination: destination:
......
...@@ -60,6 +60,20 @@ public function testSearchPage() { ...@@ -60,6 +60,20 @@ public function testSearchPage() {
$configuration = SearchPage::load($id)->getPlugin()->getConfiguration(); $configuration = SearchPage::load($id)->getPlugin()->getConfiguration();
$this->assertSame(4, $configuration['rankings']['comments']); $this->assertSame(4, $configuration['rankings']['comments']);
// Test that a configurable search without a configuration imports. Do this
// by removing the node rankings from the source database.
Database::getConnection('default', 'migrate')
->delete('variable')
->condition('name', 'node_rank_%', 'LIKE')
->execute();
$migration = $this->getMigration('search_page');
$migration->getIdMap()->prepareUpdate();
$this->executeMigration($migration);
$configuration = SearchPage::load($id)->getPlugin()->getConfiguration();
$this->assertSame([], $configuration['rankings']);
} }
} }
...@@ -79,6 +79,19 @@ public function testSearchPage() { ...@@ -79,6 +79,19 @@ public function testSearchPage() {
$this->executeMigration($migration); $this->executeMigration($migration);
$configuration['rankings']['comments'] = 4; $configuration['rankings']['comments'] = 4;
$this->assertEntity('node_search', 'node', TRUE, $configuration); $this->assertEntity('node_search', 'node', TRUE, $configuration);
// Test that a configurable search without a configuration imports. Do this
// by removing the node rankings from the source database.
Database::getConnection('default', 'migrate')
->delete('variable')
->condition('name', 'node_rank_%', 'LIKE')
->execute();
$migration = $this->getMigration('d7_search_page');
$migration->getIdMap()->prepareUpdate();
$this->executeMigration($migration);
$configuration = ['rankings' => []];
$this->assertEntity('node_search', 'node', TRUE, $configuration);
} }
/** /**
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment