Skip to content
Snippets Groups Projects
Verified Commit 2969dada authored by Théodore Biadala's avatar Théodore Biadala
Browse files

Issue #3469716 by catch, smustgrave: Optimize dblog tests

parent 38cdb2d3
No related branches found
No related tags found
20 merge requests!11131[10.4.x-only-DO-NOT-MERGE]: Issue ##2842525 Ajax attached to Views exposed filter form does not trigger callbacks,!9470[10.3.x-only-DO-NOT-MERGE]: #3331771 Fix file_get_contents(): Passing null to parameter,!8736Update the Documention As per the Function uses.,!8513Issue #3453786: DefaultSelection should document why values for target_bundles NULL and [] behave as they do,!3878Removed unused condition head title for views,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2062Issue #3246454: Add weekly granularity to views date sort,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #261972 passed with warnings
Pipeline: drupal

#261975

    ......@@ -19,7 +19,6 @@
    * Verifies log entries and user access based on permissions.
    *
    * @group dblog
    * @group #slow
    */
    class DbLogTest extends BrowserTestBase {
    use FakeLogEntries;
    ......@@ -105,6 +104,12 @@ public function testDbLog(): void {
    // Log in the regular user.
    $this->drupalLogin($this->webUser);
    $this->verifyReports(403);
    $this->testLogEventNotFoundPage();
    $this->testLogEventPageWithMissingInfo();
    $this->test403LogEventPage();
    $this->testMessageParsing();
    $this->testOverviewLinks();
    }
    /**
    ......@@ -178,7 +183,7 @@ public function testOnError(): void {
    /**
    * Tests that a 403 event is logged with the exception triggering it.
    */
    public function test403LogEventPage(): void {
    protected function test403LogEventPage(): void {
    $assert_session = $this->assertSession();
    $uri = 'admin/reports';
    ......@@ -218,7 +223,7 @@ public function test403LogEventPage(): void {
    /**
    * Tests not-existing log event page.
    */
    public function testLogEventNotFoundPage(): void {
    protected function testLogEventNotFoundPage(): void {
    // Login the admin user.
    $this->drupalLogin($this->adminUser);
    ......@@ -237,7 +242,7 @@ public function testLogEventNotFoundPage(): void {
    * - Incorrect location: When location attribute is incorrect uri which can
    * not be used to generate a valid link.
    */
    public function testLogEventPageWithMissingInfo(): void {
    protected function testLogEventPageWithMissingInfo(): void {
    $this->drupalLogin($this->adminUser);
    $connection = Database::getConnection();
    ......@@ -280,7 +285,7 @@ public function testLogEventPageWithMissingInfo(): void {
    /**
    * Test that twig errors are displayed correctly.
    */
    public function testMessageParsing(): void {
    protected function testMessageParsing(): void {
    $this->drupalLogin($this->adminUser);
    // Log a common twig error with {{ }} and { } variables.
    \Drupal::service('logger.factory')->get("php")
    ......@@ -433,7 +438,7 @@ private function verifyEvents() {
    * @param string $order
    * The order by which the table should be sorted.
    */
    public function verifySort($sort = 'asc', $order = 'Date') {
    protected function verifySort($sort = 'asc', $order = 'Date') {
    $this->drupalGet('admin/reports/dblog', ['query' => ['sort' => $sort, 'order' => $order]]);
    $this->assertSession()->statusCodeEquals(200);
    $this->assertSession()->pageTextContains('Recent log messages');
    ......@@ -859,7 +864,7 @@ public function testTemporaryUser(): void {
    /**
    * Make sure HTML tags are filtered out in the log overview links.
    */
    public function testOverviewLinks(): void {
    protected function testOverviewLinks(): void {
    $this->drupalLogin($this->adminUser);
    // cSpell:disable-next-line
    $this->generateLogEntries(1, ['message' => "&lt;script&gt;alert('foo');&lt;/script&gt;<strong>Lorem</strong> ipsum dolor sit amet, consectetur adipiscing & elit."]);
    ......
    ......@@ -12,7 +12,6 @@
    * @see Drupal\dblog\Tests\DbLogTest
    *
    * @group dblog
    * @group #slow
    */
    class DbLogViewsTest extends DbLogTest {
    ......
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Please register or to comment