Skip to content
Snippets Groups Projects
Commit 2746a72d authored by catch's avatar catch
Browse files

Issue #3369914 by Spokje, quietone, Hardik_Patel_12: Move non-migrations tests to Actions module

parent 7daf50fa
No related branches found
No related tags found
27 merge requests!8528Issue #3456871 by Tim Bozeman: Support NULL services,!6278Issue #3187770 by godotislate, smustgrave, catch, quietone: Views Rendered...,!3878Removed unused condition head title for views,!38582585169-10.1.x,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3668Resolve #3347842 "Deprecate the trusted",!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3226Issue #2987537: Custom menu link entity type should not declare "bundle" entity key,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #80243 passed
Pipeline: drupal

#80246

    Showing
    with 30 additions and 22 deletions
    <?php <?php
    namespace Drupal\Tests\jsonapi\Functional; namespace Drupal\Tests\action\Functional\Jsonapi;
    use Drupal\Core\Url; use Drupal\Core\Url;
    use Drupal\Tests\jsonapi\Functional\ConfigEntityResourceTestBase;
    use Drupal\system\Entity\Action; use Drupal\system\Entity\Action;
    use Drupal\user\RoleInterface; use Drupal\user\RoleInterface;
    /** /**
    * JSON:API integration test for the "Action" config entity type. * JSON:API integration test for the "Action" config entity type.
    * *
    * @group jsonapi * @group action
    * @group #slow * @group #slow
    */ */
    class ActionTest extends ConfigEntityResourceTestBase { class ActionTest extends ConfigEntityResourceTestBase {
    ......
    <?php <?php
    namespace Drupal\Tests\node\Functional; namespace Drupal\Tests\action\Functional\Node;
    use Drupal\Component\Serialization\Json; use Drupal\Component\Serialization\Json;
    use Drupal\Tests\BrowserTestBase; use Drupal\Tests\BrowserTestBase;
    ...@@ -10,7 +10,7 @@ ...@@ -10,7 +10,7 @@
    /** /**
    * Tests configuration of actions provided by the Node module. * Tests configuration of actions provided by the Node module.
    * *
    * @group node * @group action
    */ */
    class NodeActionsConfigurationTest extends BrowserTestBase { class NodeActionsConfigurationTest extends BrowserTestBase {
    ......
    <?php <?php
    namespace Drupal\Tests\system\Functional\Rest; namespace Drupal\Tests\action\Functional\Rest;
    use Drupal\Tests\rest\Functional\AnonResourceTestTrait; use Drupal\Tests\rest\Functional\AnonResourceTestTrait;
    /** /**
    * @group rest * @group action
    */ */
    class ActionJsonAnonTest extends ActionResourceTestBase { class ActionJsonAnonTest extends ActionResourceTestBase {
    ......
    <?php <?php
    namespace Drupal\Tests\system\Functional\Rest; namespace Drupal\Tests\action\Functional\Rest;
    use Drupal\Tests\rest\Functional\BasicAuthResourceTestTrait; use Drupal\Tests\rest\Functional\BasicAuthResourceTestTrait;
    /** /**
    * @group rest * @group action
    */ */
    class ActionJsonBasicAuthTest extends ActionResourceTestBase { class ActionJsonBasicAuthTest extends ActionResourceTestBase {
    ......
    <?php <?php
    namespace Drupal\Tests\system\Functional\Rest; namespace Drupal\Tests\action\Functional\Rest;
    use Drupal\Tests\rest\Functional\CookieResourceTestTrait; use Drupal\Tests\rest\Functional\CookieResourceTestTrait;
    /** /**
    * @group rest * @group action
    */ */
    class ActionJsonCookieTest extends ActionResourceTestBase { class ActionJsonCookieTest extends ActionResourceTestBase {
    ......
    <?php <?php
    namespace Drupal\Tests\system\Functional\Rest; namespace Drupal\Tests\action\Functional\Rest;
    use Drupal\Tests\rest\Functional\EntityResource\ConfigEntityResourceTestBase; use Drupal\Tests\rest\Functional\EntityResource\ConfigEntityResourceTestBase;
    use Drupal\system\Entity\Action; use Drupal\system\Entity\Action;
    ......
    <?php <?php
    namespace Drupal\Tests\system\Functional\Rest; namespace Drupal\Tests\action\Functional\Rest;
    use Drupal\Tests\rest\Functional\AnonResourceTestTrait; use Drupal\Tests\rest\Functional\AnonResourceTestTrait;
    use Drupal\Tests\rest\Functional\EntityResource\XmlEntityNormalizationQuirksTrait; use Drupal\Tests\rest\Functional\EntityResource\XmlEntityNormalizationQuirksTrait;
    /** /**
    * @group rest * @group action
    */ */
    class ActionXmlAnonTest extends ActionResourceTestBase { class ActionXmlAnonTest extends ActionResourceTestBase {
    ......
    <?php <?php
    namespace Drupal\Tests\system\Functional\Rest; namespace Drupal\Tests\action\Functional\Rest;
    use Drupal\Tests\rest\Functional\BasicAuthResourceTestTrait; use Drupal\Tests\rest\Functional\BasicAuthResourceTestTrait;
    use Drupal\Tests\rest\Functional\EntityResource\XmlEntityNormalizationQuirksTrait; use Drupal\Tests\rest\Functional\EntityResource\XmlEntityNormalizationQuirksTrait;
    /** /**
    * @group rest * @group action
    */ */
    class ActionXmlBasicAuthTest extends ActionResourceTestBase { class ActionXmlBasicAuthTest extends ActionResourceTestBase {
    ......
    <?php <?php
    namespace Drupal\Tests\system\Functional\Rest; namespace Drupal\Tests\action\Functional\Rest;
    use Drupal\Tests\rest\Functional\CookieResourceTestTrait; use Drupal\Tests\rest\Functional\CookieResourceTestTrait;
    use Drupal\Tests\rest\Functional\EntityResource\XmlEntityNormalizationQuirksTrait; use Drupal\Tests\rest\Functional\EntityResource\XmlEntityNormalizationQuirksTrait;
    /** /**
    * @group rest * @group action
    */ */
    class ActionXmlCookieTest extends ActionResourceTestBase { class ActionXmlCookieTest extends ActionResourceTestBase {
    ......
    ...@@ -71,6 +71,9 @@ public function testEntityTypeRestTestCoverage() { ...@@ -71,6 +71,9 @@ public function testEntityTypeRestTestCoverage() {
    $possible_paths = [ $possible_paths = [
    'Drupal\Tests\jsonapi\Functional\CLASSTest', 'Drupal\Tests\jsonapi\Functional\CLASSTest',
    '\Drupal\Tests\\' . $module_name . '\Functional\Jsonapi\CLASSTest', '\Drupal\Tests\\' . $module_name . '\Functional\Jsonapi\CLASSTest',
    // For entities defined in the system module with Jsonapi tests in
    // another module.
    '\Drupal\Tests\\' . $info->id() . '\Functional\Jsonapi\CLASSTest',
    ]; ];
    foreach ($possible_paths as $path) { foreach ($possible_paths as $path) {
    $missing_tests = []; $missing_tests = [];
    ......
    ...@@ -16,7 +16,7 @@ class UnpublishByKeywordActionTest extends KernelTestBase { ...@@ -16,7 +16,7 @@ class UnpublishByKeywordActionTest extends KernelTestBase {
    /** /**
    * {@inheritdoc} * {@inheritdoc}
    */ */
    protected static $modules = ['action', 'node', 'system', 'user', 'field']; protected static $modules = ['node', 'system', 'user', 'field'];
    /** /**
    * {@inheritdoc} * {@inheritdoc}
    ......
    ...@@ -94,7 +94,10 @@ public function testEntityTypeRestTestCoverage() { ...@@ -94,7 +94,10 @@ public function testEntityTypeRestTestCoverage() {
    foreach ($info['class suffix'] as $postfix) { foreach ($info['class suffix'] as $postfix) {
    $class = str_replace(['PROVIDER', 'CLASS'], [$module_name, $class_name], $path . $postfix); $class = str_replace(['PROVIDER', 'CLASS'], [$module_name, $class_name], $path . $postfix);
    $class_alternative = str_replace("\\Drupal\\Tests\\$module_name\\Functional", '\Drupal\FunctionalTests', $class); $class_alternative = str_replace("\\Drupal\\Tests\\$module_name\\Functional", '\Drupal\FunctionalTests', $class);
    if (class_exists($class) || class_exists($class_alternative)) { // For entities defined in the system module with Jsonapi tests in
    // another module.
    $class_entity_in_system_alternative = str_replace(['PROVIDER', 'CLASS'], [$entity_type_id, $class_name], $path . $postfix);
    if (class_exists($class) || class_exists($class_alternative) || class_exists($class_entity_in_system_alternative)) {
    continue; continue;
    } }
    $missing_tests[] = $postfix; $missing_tests[] = $postfix;
    ...@@ -109,7 +112,9 @@ public function testEntityTypeRestTestCoverage() { ...@@ -109,7 +112,9 @@ public function testEntityTypeRestTestCoverage() {
    } }
    $config_entity = is_subclass_of($class_name_full, ConfigEntityInterface::class); $config_entity = is_subclass_of($class_name_full, ConfigEntityInterface::class);
    $config_test = is_subclass_of($class, ConfigEntityResourceTestBase::class) || is_subclass_of($class_alternative, ConfigEntityResourceTestBase::class); $config_test = is_subclass_of($class, ConfigEntityResourceTestBase::class)
    || is_subclass_of($class_alternative, ConfigEntityResourceTestBase::class)
    || is_subclass_of($class_entity_in_system_alternative, ConfigEntityResourceTestBase::class);
    if ($config_entity && !$config_test) { if ($config_entity && !$config_test) {
    $problems[] = "$entity_type_id: $class_name is a config entity, but the test is for content entities."; $problems[] = "$entity_type_id: $class_name is a config entity, but the test is for content entities.";
    } }
    ......
    ...@@ -24,7 +24,6 @@ class ConfigEntityImportTest extends KernelTestBase { ...@@ -24,7 +24,6 @@ class ConfigEntityImportTest extends KernelTestBase {
    * {@inheritdoc} * {@inheritdoc}
    */ */
    protected static $modules = [ protected static $modules = [
    'action',
    'block', 'block',
    'config_test', 'config_test',
    'filter', 'filter',
    ...@@ -38,7 +37,7 @@ class ConfigEntityImportTest extends KernelTestBase { ...@@ -38,7 +37,7 @@ class ConfigEntityImportTest extends KernelTestBase {
    * Runs test methods for each module within a single test run. * Runs test methods for each module within a single test run.
    */ */
    public function testConfigUpdateImport() { public function testConfigUpdateImport() {
    $this->installConfig(['action', 'block', 'filter', 'image']); $this->installConfig(['block', 'filter', 'image']);
    $this->container->get('theme_installer')->install(['olivero']); $this->container->get('theme_installer')->install(['olivero']);
    $config_storage = $this->container->get('config.storage'); $config_storage = $this->container->get('config.storage');
    // Ensure the 'system.site' config. // Ensure the 'system.site' config.
    ......
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Finish editing this message first!
    Please register or to comment