Skip to content
Snippets Groups Projects
Commit 225e9301 authored by catch's avatar catch
Browse files

Issue #3409388 by quietone, smustgrave: Remove usage of forum module from comments and strings

parent 2c6bb82a
Branches
Tags
32 merge requests!12227Issue #3181946 by jonmcl, mglaman,!8528Issue #3456871 by Tim Bozeman: Support NULL services,!8323Fix source code editing and in place front page site studio editing.,!6278Issue #3187770 by godotislate, smustgrave, catch, quietone: Views Rendered...,!3878Removed unused condition head title for views,!38582585169-10.1.x,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3668Resolve #3347842 "Deprecate the trusted",!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3478Issue #3337882: Deleted menus are not removed from content type config,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3226Issue #2987537: Custom menu link entity type should not declare "bundle" entity key,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2614Issue #2981326: Replace non-test usages of \Drupal::logger() with IoC injection,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!844Resolve #3036010 "Updaters",!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!213Issue #2906496: Give Media a menu item under Content
Pipeline #75876 passed with warnings
Pipeline: drupal

#75878

    ......@@ -68,11 +68,11 @@
    *
    * If an extension author wants a configuration entity to depend on something
    * that is not calculable then they can add these dependencies to the enforced
    * dependencies key. For example, the Forum module provides the forum node type
    * and in order for it to be deleted when the forum module is uninstalled it has
    * an enforced dependency on the module. The dependency on the Forum module can
    * not be calculated since there is nothing inherent in the state of the node
    * type configuration entity that depends on functionality provided by the Forum
    * dependencies key. For example, a custom module that provides a node type can
    * have that type deleted when the module is uninstalled, if it has an enforced
    * dependency on the module. The dependency on the custom module can not be
    * calculated since there is nothing inherent in the state of the node type
    * configuration entity that depends on functionality provided by the custom
    * module.
    *
    * Once declared properly, dependencies are saved to the configuration entity's
    ......
    ......@@ -523,8 +523,6 @@
    * general information about configuration.)
    *
    * There are several good examples of this in Drupal Core:
    * - The Forum module defines a content type in node.type.forum.yml and a
    * vocabulary in taxonomy.vocabulary.forums.yml
    * - The Book module defines a content type in node.type.book.yml
    * - The Standard install profile defines Page and Article content types in
    * node.type.page.yml and node.type.article.yml, a Tags vocabulary in
    ......
    ......@@ -40,7 +40,7 @@ interface InfoParserInterface {
    * can contain "x" as a wildcard. Examples: (>=8.22, <8.28), (8.x-3.x).
    * - package: The name of the package of modules this module belongs to.
    *
    * See forum.info.yml for an example of a module .info.yml file.
    * See node.info.yml for an example of a module .info.yml file.
    *
    * Information stored in a theme .info.yml file:
    * - screenshot: Path to screenshot relative to the theme's .info.yml file.
    ......
    ......@@ -1222,15 +1222,7 @@ function hook_page_bottom(array &$page_bottom) {
    * rendered output.
    * - pattern: A regular expression pattern to be used to allow this theme
    * implementation to have a dynamic name. The convention is to use __ to
    * differentiate the dynamic portion of the theme. For example, to allow
    * forums to be themed individually, the pattern might be: 'forum__'. Then,
    * when the forum is rendered, following render array can be used:
    * @code
    * $render_array = array(
    * '#theme' => array('forum__' . $tid, 'forum'),
    * '#forum' => $forum,
    * );
    * @endcode
    * differentiate the dynamic portion of the theme.
    * - preprocess functions: A list of functions used to preprocess this data.
    * Ordinarily this won't be used; it's automatically filled in. By default,
    * for a module this will be filled in as template_preprocess_HOOK. For
    ......@@ -1256,13 +1248,13 @@ function hook_page_bottom(array &$page_bottom) {
    */
    function hook_theme($existing, $type, $theme, $path) {
    return [
    'forum_display' => [
    'variables' => ['forums' => NULL, 'topics' => NULL, 'parents' => NULL, 'tid' => NULL, 'sortby' => NULL, 'forum_per_page' => NULL],
    'my_module_display' => [
    'variables' => ['my_modules' => NULL, 'topics' => NULL, 'parents' => NULL, 'tid' => NULL, 'sortby' => NULL, 'my_module_per_page' => NULL],
    ],
    'forum_list' => [
    'variables' => ['forums' => NULL, 'parents' => NULL, 'tid' => NULL],
    'my_module_list' => [
    'variables' => ['my_modules' => NULL, 'parents' => NULL, 'tid' => NULL],
    ],
    'forum_icon' => [
    'my_module_icon' => [
    'variables' => ['new_posts' => NULL, 'num_posts' => 0, 'comment_mode' => 0, 'sticky' => 0],
    ],
    'status_report' => [
    ......@@ -1315,10 +1307,10 @@ function hook_theme($existing, $type, $theme, $path) {
    * @see \Drupal\Core\Theme\Registry::processExtension()
    */
    function hook_theme_registry_alter(&$theme_registry) {
    // Kill the next/previous forum topic navigation links.
    foreach ($theme_registry['forum_topic_navigation']['preprocess functions'] as $key => $value) {
    if ($value == 'template_preprocess_forum_topic_navigation') {
    unset($theme_registry['forum_topic_navigation']['preprocess functions'][$key]);
    // Kill the next/previous my_module topic navigation links.
    foreach ($theme_registry['my_module_topic_navigation']['preprocess functions'] as $key => $value) {
    if ($value == 'template_preprocess_my_module_topic_navigation') {
    unset($theme_registry['my_module_topic_navigation']['preprocess functions'][$key]);
    }
    }
    }
    ......
    ......@@ -6,8 +6,8 @@
    *
    * When installed, the Comment module creates a field that facilitates a
    * discussion board for each Drupal entity to which a comment field is attached.
    * Users can post comments to discuss a forum topic, story, collaborative
    * book page, user etc.
    * Users can post comments to discuss a story, collaborative book page, user
    * etc.
    */
    use Drupal\comment\CommentInterface;
    ......
    ......@@ -161,7 +161,7 @@ class FieldStorageConfig extends ConfigEntityBase implements FieldStorageConfigI
    * are no remaining fields using them. If multiple modules provide bundles
    * which need to use the same field storage then setting this to TRUE will
    * preserve the field storage regardless of what happens to the bundles. The
    * classic use case for this is node body field storage since Book, Forum, the
    * classic use case for this is node body field storage since Book, the
    * Standard profile and bundle (node type) creation through the UI all use
    * same field storage.
    *
    ......
    ......@@ -5,7 +5,6 @@
    * Records which users have read which content.
    *
    * @todo
    * - Generic helper for _forum_user_last_visit() + history_read().
    * - Generic helper for node_mark().
    */
    ......
    ......@@ -210,8 +210,8 @@ public function testNodeTypeDeletion() {
    $locked = \Drupal::state()->get('node.type.locked');
    $locked['default'] = 'default';
    \Drupal::state()->set('node.type.locked', $locked);
    // Call to flush all caches after installing the forum module in the same
    // way installing a module through the UI does.
    // Call to flush all caches after installing the node_test_config module in
    // the same way installing a module through the UI does.
    $this->resetAll();
    $this->drupalGet('admin/structure/types/manage/default');
    $this->assertSession()->linkNotExists('Delete');
    ......
    ......@@ -148,7 +148,7 @@ function path_field_widget_single_element_form_alter(&$element, FormStateInterfa
    }
    if ($field_name === 'path') {
    $element['value']['#description'] = t('Specify the existing path you wish to alias. For example: /node/28, /forum/1, /taxonomy/term/1.');
    $element['value']['#description'] = t('Specify the existing path you wish to alias. For example: /node/28, /media/1, /taxonomy/term/1.');
    }
    if ($field_name === 'alias') {
    ......
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Please to comment