Skip to content
Snippets Groups Projects
Verified Commit 1ea295c8 authored by Lauri Timmanee's avatar Lauri Timmanee
Browse files

Issue #3383080 by amateescu, srishtiiee, Wim Leers: Provide the 'general'...

Issue #3383080 by amateescu, srishtiiee, Wim Leers: Provide the 'general' category within the plugin manager, and ensure that it remains unaltered
parent d418da39
No related branches found
No related tags found
41 merge requests!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!3878Removed unused condition head title for views,!38582585169-10.1.x,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3668Resolve #3347842 "Deprecate the trusted",!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3546refactored dialog.pcss file,!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3502Issue #3335308: Confusing behavior with FormState::setFormState and FormState::setMethod,!3452Issue #3332701: Refactor Claro's tablesort-indicator stylesheet,!3451Issue #2410579: Allows setting the current language programmatically.,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3226Issue #2987537: Custom menu link entity type should not declare "bundle" entity key,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3147Issue #3328457: Replace most substr($a, $i) where $i is negative with str_ends_with(),!3146Issue #3328456: Replace substr($a, 0, $i) with str_starts_with(),!3133core/modules/system/css/components/hidden.module.css,!31312878513-10.1.x,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2614Issue #2981326: Replace non-test usages of \Drupal::logger() with IoC injection,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2062Issue #3246454: Add weekly granularity to views date sort,!1591Issue #3199697: Add JSON:API Translation experimental module,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!877Issue #2708101: Default value for link text is not saved,!844Resolve #3036010 "Updaters",!673Issue #3214208: FinishResponseSubscriber could create duplicate headers,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer,!23Issue #2879087: Use comment access handler instead of hardcoding permissions
......@@ -79,6 +79,17 @@ protected function getDiscovery(): YamlDiscovery {
return $this->discovery;
}
/**
* {@inheritdoc}
*/
protected function alterDefinitions(&$definitions): void {
parent::alterDefinitions($definitions);
if (!isset($definitions[FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY])) {
throw new \LogicException('Missing fallback category.');
}
}
/**
* {@inheritdoc}
*/
......
......@@ -789,9 +789,7 @@ function comment_entity_view_display_presave(EntityViewDisplayInterface $display
* Implements hook_field_type_category_info_alter().
*/
function comment_field_type_category_info_alter(&$definitions) {
// TRICKY: the `comment` field type belongs in the `general` category, so the
// The `comment` field type belongs in the `general` category, so the
// libraries need to be attached using an alter hook.
if (array_key_exists(FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY, $definitions)) {
$definitions[FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY]['libraries'][] = 'comment/drupal.comment-icon';
}
$definitions[FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY]['libraries'][] = 'comment/drupal.comment-icon';
}
......@@ -33,9 +33,7 @@ function datetime_range_help($route_name, RouteMatchInterface $route_match) {
* Implements hook_field_type_category_info_alter().
*/
function datetime_range_field_type_category_info_alter(&$definitions) {
// TRICKY: the `datetime_range` field type belongs in the `general` category,
// so the libraries need to be attached using an alter hook.
if (array_key_exists(FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY, $definitions)) {
$definitions[FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY]['libraries'][] = 'datetime_range/drupal.datetime_range-icon';
}
// The `datetime_range` field type belongs in the `general` category, so the
// libraries need to be attached using an alter hook.
$definitions[FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY]['libraries'][] = 'datetime_range/drupal.datetime_range-icon';
}
......@@ -71,9 +71,7 @@ function template_preprocess_link_formatter_link_separate(&$variables) {
* Implements hook_field_type_category_info_alter().
*/
function link_field_type_category_info_alter(&$definitions) {
// TRICKY: the `link` field type belongs in the `general` category, so the
// libraries need to be attached using an alter hook.
if (array_key_exists(FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY, $definitions)) {
$definitions[FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY]['libraries'][] = 'link/drupal.link-icon';
}
// The `link` field type belongs in the `general` category, so the libraries
// need to be attached using an alter hook.
$definitions[FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY]['libraries'][] = 'link/drupal.link-icon';
}
......@@ -537,9 +537,7 @@ function media_views_query_substitutions(ViewExecutable $view) {
* Implements hook_field_type_category_info_alter().
*/
function media_field_type_category_info_alter(&$definitions) {
// TRICKY: the `media` field type belongs in the `general` category, so the
// libraries need to be attached using an alter hook.
if (array_key_exists(FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY, $definitions)) {
$definitions[FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY]['libraries'][] = 'media/drupal.media-icon';
}
// The `media` field type belongs in the `general` category, so the libraries
// need to be attached using an alter hook.
$definitions[FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY]['libraries'][] = 'media/drupal.media-icon';
}
......@@ -40,9 +40,7 @@ function telephone_field_formatter_info_alter(&$info) {
* Implements hook_field_type_category_info_alter().
*/
function telephone_field_type_category_info_alter(&$definitions) {
// TRICKY: the `telephone` field type belongs in the `general` category, so
// the libraries need to be attached using an alter hook.
if (array_key_exists(FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY, $definitions)) {
$definitions[FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY]['libraries'][] = 'telephone/drupal.telephone-icon';
}
// The `telephone` field type belongs in the `general` category, so the
// libraries need to be attached using an alter hook.
$definitions[FieldTypeCategoryManagerInterface::FALLBACK_CATEGORY]['libraries'][] = 'telephone/drupal.telephone-icon';
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment