Skip to content
Snippets Groups Projects
Unverified Commit 0d091ad9 authored by Lauri Timmanee's avatar Lauri Timmanee
Browse files

Issue #3258987 by phenaproxima, xjm, mrweiner, catch, cilefen, mfb,...

Issue #3258987 by phenaproxima, xjm, mrweiner, catch, cilefen, mfb, benjifisher, Berdir, szato: Status report should warn about OPcache bug in PHP 8.1.0 to 8.1.5
parent e1ae3a33
No related branches found
No related tags found
37 merge requests!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!4289Issue #1344552 by marcingy, Niklas Fiekas, Ravi.J, aleevas, Eduardo Morales...,!4114Issue #2707291: Disable body-level scrolling when a dialog is open as a modal,!4100Issue #3249600: Add support for PHP 8.1 Enums as allowed values for list_* data types,!3630Issue #2815301 by Chi, DanielVeza, kostyashupenko, smustgrave: Allow to create...,!3600Issue #3344629: Passing null to parameter #1 ($haystack) of type string is deprecated,!3291Issue #3336463: Rewrite rules for gzipped CSS and JavaScript aggregates never match,!3102Issue #3164428 by DonAtt, longwave, sahil.goyal, Anchal_gupta, alexpott: Use...,!2853#3274419 Makes BaseFieldOverride inherit the internal property from the base field.,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2074Issue #2707689: NodeForm::actions() checks for delete access on new entities,!2062Issue #3246454: Add weekly granularity to views date sort,!1591Issue #3199697: Add JSON:API Translation experimental module,!1484Exposed filters get values from URL when Ajax is on,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1254Issue #3238915: Refactor (if feasible) uses of the jQuery ready function to use VanillaJS,!1162Issue #3100350: Unable to save '/' root path alias,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!957Added throwing of InvalidPluginDefinitionException from getDefinition().,!925Issue #2339235: Remove taxonomy hard dependency on node module,!877Issue #2708101: Default value for link text is not saved,!873Issue #2875228: Site install not using batch API service,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!844Resolve #3036010 "Updaters",!712Issue #2909128: Autocomplete intermittent on Chrome Android,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
...@@ -316,6 +316,19 @@ function system_requirements($phase) { ...@@ -316,6 +316,19 @@ function system_requirements($phase) {
elseif ($phase === 'runtime' && version_compare($phpversion, \Drupal::RECOMMENDED_PHP) < 0) { elseif ($phase === 'runtime' && version_compare($phpversion, \Drupal::RECOMMENDED_PHP) < 0) {
$requirements['php']['description'] = t('It is recommended to upgrade to PHP version %recommended or higher for the best ongoing support. See <a href="http://php.net/supported-versions.php">PHP\'s version support documentation</a> and the <a href=":php_requirements">Drupal PHP requirements</a> page for more information.', ['%recommended' => \Drupal::RECOMMENDED_PHP, ':php_requirements' => 'https://www.drupal.org/docs/system-requirements/php-requirements']); $requirements['php']['description'] = t('It is recommended to upgrade to PHP version %recommended or higher for the best ongoing support. See <a href="http://php.net/supported-versions.php">PHP\'s version support documentation</a> and the <a href=":php_requirements">Drupal PHP requirements</a> page for more information.', ['%recommended' => \Drupal::RECOMMENDED_PHP, ':php_requirements' => 'https://www.drupal.org/docs/system-requirements/php-requirements']);
$requirements['php']['severity'] = REQUIREMENT_INFO; $requirements['php']['severity'] = REQUIREMENT_INFO;
// PHP 8.1.0 through 8.1.5 have a known OPcache bug that can cause fatal
// errors, so warn about that when running Drupal on those versions.
// @todo Remove this when \Drupal::MINIMUM_PHP is at least 8.1.6 in
// https://www.drupal.org/i/3305726.
if (version_compare(\Drupal::MINIMUM_PHP, '8.1.6') < 0) {
$requirements['php']['description'] = t('PHP %version has <a href=":bug_url">an OPcache bug that can cause fatal errors with class autoloading</a>. This can be fixed by upgrading to PHP 8.1.6 or later. See <a href="http://php.net/supported-versions.php">PHP\'s version support documentation</a> and the <a href=":php_requirements">Drupal PHP requirements</a> page for more information.', [
'%version' => $phpversion,
':bug_url' => 'https://github.com/php/php-src/issues/8164',
':php_requirements' => 'https://www.drupal.org/docs/system-requirements/php-requirements',
]);
$requirements['php']['severity'] = REQUIREMENT_WARNING;
}
} }
// Test for PHP extensions. // Test for PHP extensions.
......
...@@ -72,7 +72,17 @@ public function testStatusPage() { ...@@ -72,7 +72,17 @@ public function testStatusPage() {
// There should be an informational message if the PHP version is below the // There should be an informational message if the PHP version is below the
// recommended version. // recommended version.
if (version_compare($phpversion, \Drupal::RECOMMENDED_PHP) < 0) { if (version_compare($phpversion, \Drupal::RECOMMENDED_PHP) < 0) {
$this->assertSession()->pageTextContains('It is recommended to upgrade to PHP version ' . \Drupal::RECOMMENDED_PHP . ' or higher'); // If it's possible to run Drupal on PHP 8.1.0 to 8.1.5, warn about a
// bug in OPcache.
// @todo Remove this when \Drupal::MINIMUM_PHP is at least 8.1.6 in
// https://www.drupal.org/i/3305726.
if (version_compare(\Drupal::MINIMUM_PHP, '8.1.6') < 0) {
$this->assertSession()->pageTextContains("PHP $phpversion has an OPcache bug that can cause fatal errors with class autoloading. This can be fixed by upgrading to PHP 8.1.6 or later.");
$this->assertSession()->linkExists('an OPcache bug that can cause fatal errors with class autoloading');
}
else {
$this->assertSession()->pageTextContains('It is recommended to upgrade to PHP version ' . \Drupal::RECOMMENDED_PHP . ' or higher');
}
} }
// Otherwise, the message should not be there. // Otherwise, the message should not be there.
else { else {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment