Skip to content
Snippets Groups Projects
Verified Commit ba111c10 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3272354 by danflanagan8: Filter tests should not rely on Classy

parent 946d5a31
Branches
Tags
37 merge requests!12227Issue #3181946 by jonmcl, mglaman,!7471uncessary 5 files are moved from media-library folder to misc folder,!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!4289Issue #1344552 by marcingy, Niklas Fiekas, Ravi.J, aleevas, Eduardo Morales...,!4114Issue #2707291: Disable body-level scrolling when a dialog is open as a modal,!3630Issue #2815301 by Chi, DanielVeza, kostyashupenko, smustgrave: Allow to create...,!3291Issue #3336463: Rewrite rules for gzipped CSS and JavaScript aggregates never match,!3143Issue #3313342: [PHP 8.1] Deprecated function: strpos(): Passing null to parameter #1 LayoutBuilderUiCacheContext.php on line 28,!3102Issue #3164428 by DonAtt, longwave, sahil.goyal, Anchal_gupta, alexpott: Use...,!2853#3274419 Makes BaseFieldOverride inherit the internal property from the base field.,!2719Issue #3110137: Remove Classy from core.,!2437Issue #3238257 by hooroomoo, Wim Leers: Fragment link pointing to <textarea>...,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2074Issue #2707689: NodeForm::actions() checks for delete access on new entities,!2062Issue #3246454: Add weekly granularity to views date sort,!1591Issue #3199697: Add JSON:API Translation experimental module,!1484Exposed filters get values from URL when Ajax is on,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1254Issue #3238915: Refactor (if feasible) uses of the jQuery ready function to use VanillaJS,!1162Issue #3100350: Unable to save '/' root path alias,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!957Added throwing of InvalidPluginDefinitionException from getDefinition().,!925Issue #2339235: Remove taxonomy hard dependency on node module,!877Issue #2708101: Default value for link text is not saved,!873Issue #2875228: Site install not using batch API service,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!844Resolve #3036010 "Updaters",!712Issue #2909128: Autocomplete intermittent on Chrome Android,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
Hide whitespace changes
Inline Side-by-side
core/modules/filter/tests/src/Functional/FilterAdminTest.php
+ 10
− 10
View file @ ba111c10
......@@ -32,7 +32,7 @@ class FilterAdminTest extends BrowserTestBase {
/**
* {@inheritdoc}
*/
protected $defaultTheme = 'classy';
protected $defaultTheme = 'stark';
/**
* A user with administration permissions.
......@@ -178,7 +178,7 @@ public function testFormatAdmin() {
];
$this->drupalGet('admin/config/content/formats/add');
$this->submitForm($edit, 'Save configuration');
$this->assertSession()->pageTextContains('The machine-readable name is already in use. It must be unique.');
$this->assertSession()->statusMessageContains('The machine-readable name is already in use. It must be unique.', 'error');
// Attempt to create a format of the same human readable name as the
// disabled format but with a different machine name.
......@@ -188,7 +188,7 @@ public function testFormatAdmin() {
];
$this->drupalGet('admin/config/content/formats/add');
$this->submitForm($edit, 'Save configuration');
$this->assertSession()->pageTextContains("Text format names must be unique. A format named $name already exists.");
$this->assertSession()->statusMessageContains("Text format names must be unique. A format named $name already exists.", 'error');
}
/**
......@@ -266,7 +266,7 @@ public function testFilterAdmin() {
$this->drupalGet('admin/config/content/formats/add');
$this->submitForm($edit, 'Save configuration');
$this->assertSession()->addressEquals('admin/config/content/formats');
$this->assertSession()->pageTextContains("Added text format {$edit['name']}.");
$this->assertSession()->statusMessageContains("Added text format {$edit['name']}.", 'status');
filter_formats_reset();
$format = FilterFormat::load($edit['format']);
......@@ -284,7 +284,7 @@ public function testFilterAdmin() {
$this->drupalGet('admin/config/content/formats/manage/' . $format->id() . '/disable');
$this->submitForm([], 'Disable');
$this->assertSession()->addressEquals('admin/config/content/formats');
$this->assertSession()->pageTextContains("Disabled text format {$edit['name']}.");
$this->assertSession()->statusMessageContains("Disabled text format {$edit['name']}.", 'status');
\Drupal::entityTypeManager()->getStorage('user_role')->resetCache([RoleInterface::AUTHENTICATED_ID]);
$role = Role::load(RoleInterface::AUTHENTICATED_ID);
$this->assertFalse($role->hasPermission($format->getPermissionName()), 'The filter permission has been removed from the authenticated role');
......@@ -297,7 +297,7 @@ public function testFilterAdmin() {
$this->drupalGet('admin/config/content/formats/manage/' . $full);
$this->submitForm($edit, 'Save configuration');
$this->assertSession()->addressEquals('admin/config/content/formats/manage/' . $full);
$this->assertSession()->pageTextContains("The text format {$format->label()} has been updated.");
$this->assertSession()->statusMessageContains("The text format {$format->label()} has been updated.", 'status');
// Switch user.
$this->drupalLogin($this->webUser);
......@@ -316,10 +316,10 @@ public function testFilterAdmin() {
$edit['body[0][format]'] = $basic;
$this->drupalGet('node/add/page');
$this->submitForm($edit, 'Save');
$this->assertSession()->pageTextContains('Basic page ' . $edit['title[0][value]'] . ' has been created.');
$this->assertSession()->statusMessageContains('Basic page ' . $edit['title[0][value]'] . ' has been created.', 'status');
// Verify that the creation message contains a link to a node.
$this->assertSession()->elementExists('xpath', '//div[contains(@class, "messages")]//a[contains(@href, "node/")]');
$this->assertSession()->elementExists('xpath', '//div[@aria-label="Status message"]//a[contains(@href, "node/")]');
$node = $this->drupalGetNodeByTitle($edit['title[0][value]']);
$this->assertNotEmpty($node, 'Node found in database.');
......@@ -363,7 +363,7 @@ public function testFilterAdmin() {
$this->drupalGet('admin/config/content/formats/manage/' . $full);
$this->submitForm($edit, 'Save configuration');
$this->assertSession()->addressEquals('admin/config/content/formats/manage/' . $full);
$this->assertSession()->pageTextContains("The text format {$format->label()} has been updated.");
$this->assertSession()->statusMessageContains("The text format {$format->label()} has been updated.", 'status');
$this->drupalGet('admin/config/content/formats/manage/' . $full);
$this->assertSession()->fieldValueEquals('roles[' . RoleInterface::AUTHENTICATED_ID . ']', $edit['roles[' . RoleInterface::AUTHENTICATED_ID . ']']);
......@@ -389,7 +389,7 @@ public function testUrlFilterAdmin() {
];
$this->drupalGet('admin/config/content/formats/manage/basic_html');
$this->submitForm($edit, 'Save configuration');
$this->assertSession()->pageTextNotContains("The text format Basic HTML has been updated.");
$this->assertSession()->statusMessageNotContains('The text format Basic HTML has been updated.');
}
/**
......
core/modules/filter/tests/src/Functional/FilterFormatAccessTest.php
+ 2
− 2
View file @ ba111c10
......@@ -282,7 +282,7 @@ public function testFormatWidgetPermissions() {
$edit['title[0][value]'] = $new_title;
$this->drupalGet('node/' . $node->id() . '/edit');
$this->submitForm($edit, 'Save');
$this->assertSession()->pageTextContains('Text format field is required.');
$this->assertSession()->statusMessageContains('Text format field is required.', 'error');
$this->drupalGet('node/' . $node->id());
$this->assertSession()->pageTextContains($old_title);
$this->assertSession()->pageTextNotContains($new_title);
......@@ -320,7 +320,7 @@ public function testFormatWidgetPermissions() {
$edit['title[0][value]'] = $new_title;
$this->drupalGet('node/' . $node->id() . '/edit');
$this->submitForm($edit, 'Save');
$this->assertSession()->pageTextContains('Text format field is required.');
$this->assertSession()->statusMessageContains('Text format field is required.', 'error');
$this->drupalGet('node/' . $node->id());
$this->assertSession()->pageTextContains($old_title);
$this->assertSession()->pageTextNotContains($new_title);
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment