Skip to content
Snippets Groups Projects
Verified Commit 9b3d27c5 authored by Lauri Timmanee's avatar Lauri Timmanee
Browse files

Issue #2820586 by joaopauloc.dev, Gauravvvv, lauriii, ranjith_kumar_k_u,...

Issue #2820586 by joaopauloc.dev, Gauravvvv, lauriii, ranjith_kumar_k_u, smustgrave, markhalliwell, longwave, dawehner, quietone: #states not applied to link elements
parent 116c87e4
No related branches found
No related tags found
42 merge requests!8528Issue #3456871 by Tim Bozeman: Support NULL services,!8323Fix source code editing and in place front page site studio editing.,!6278Issue #3187770 by godotislate, smustgrave, catch, quietone: Views Rendered...,!54479.5.x SF update,!5022Issue #3394406: FileUploadHandler::handleExtensionValidation does not have fallback for sites still using file_validate_extensions,!5014Issue #3071143: Table Render Array Example Is Incorrect,!3878Removed unused condition head title for views,!38582585169-10.1.x,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3668Resolve #3347842 "Deprecate the trusted",!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3546refactored dialog.pcss file,!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3502Issue #3335308: Confusing behavior with FormState::setFormState and FormState::setMethod,!3452Issue #3332701: Refactor Claro's tablesort-indicator stylesheet,!3451Issue #2410579: Allows setting the current language programmatically.,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3226Issue #2987537: Custom menu link entity type should not declare "bundle" entity key,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3147Issue #3328457: Replace most substr($a, $i) where $i is negative with str_ends_with(),!3146Issue #3328456: Replace substr($a, 0, $i) with str_starts_with(),!3133core/modules/system/css/components/hidden.module.css,!31312878513-10.1.x,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2614Issue #2981326: Replace non-test usages of \Drupal::logger() with IoC injection,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2062Issue #3246454: Add weekly granularity to views date sort,!1591Issue #3199697: Add JSON:API Translation experimental module,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!877Issue #2708101: Default value for link text is not saved,!844Resolve #3036010 "Updaters",!673Issue #3214208: FinishResponseSubscriber could create duplicate headers,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.
Pipeline #29035 failed
+1
......@@ -4,6 +4,7 @@
use Drupal\Component\Utility\NestedArray;
use Drupal\Component\Utility\Html as HtmlUtility;
use Drupal\Core\Form\FormHelper;
use Drupal\Core\Render\BubbleableMetadata;
use Drupal\Core\Render\Element;
use Drupal\Core\Url as CoreUrl;
......@@ -57,6 +58,12 @@ public function getInfo() {
* The passed-in element containing a rendered link in '#markup'.
*/
public static function preRenderLink($element) {
// As the preRenderLink() method is executed before Renderer::doRender(),
// call processStates() to make sure that states are added to link elements.
if (!empty($element['#states'])) {
FormHelper::processStates($element);
}
// By default, link options to pass to the link generator are normally set
// in #options.
$element += ['#options' => []];
......
......@@ -724,9 +724,14 @@
$document.on('state:visible', (e) => {
if (e.trigger) {
$(e.target)
.closest('.js-form-item, .js-form-submit, .js-form-wrapper')
.toggle(e.value);
let $element = $(e.target).closest(
'.js-form-item, .js-form-submit, .js-form-wrapper',
);
// For links, update the state of itself instead of the wrapper.
if (e.target.tagName === 'A') {
$element = $(e.target);
}
$element.toggle(e.value);
}
});
......
......@@ -4,6 +4,7 @@
use Drupal\Core\Form\FormBase;
use Drupal\Core\Form\FormStateInterface;
use Drupal\Core\Url;
/**
* Builds a simple form to test states.
......@@ -544,6 +545,18 @@ public function buildForm(array $form, FormStateInterface $form_state) {
],
],
];
$form['link'] = [
'#type' => 'link',
'#title' => 'Link states test',
'#url' => Url::fromRoute('<front>'),
'#states' => [
'visible' => [
':input[name="checkbox_trigger"]' => ['checked' => FALSE],
],
],
];
return $form;
}
......
......@@ -102,6 +102,7 @@ protected function doCheckboxTriggerTests() {
$this->assertNotEmpty($text_format_invisible_value);
$text_format_invisible_format = $page->findField('text_format_invisible_when_checkbox_trigger_checked[format]');
$this->assertNotEmpty($text_format_invisible_format);
$link = $page->findLink('Link states test');
$checkboxes_all_checked_element_value1 = $page->findField('checkboxes_all_checked_when_checkbox_trigger_checked[value1]');
$this->assertNotEmpty($checkboxes_all_checked_element_value1);
......@@ -180,6 +181,8 @@ protected function doCheckboxTriggerTests() {
$this->assertFalse($radios_all_disabled_value2->hasAttribute('disabled'));
$this->assertFalse($radios_some_disabled_value1->hasAttribute('disabled'));
$this->assertFalse($radios_some_disabled_value2->hasAttribute('disabled'));
// Check if the link is visible.
$this->assertTrue($link->isVisible());
// Change state: check the checkbox.
$trigger->check();
......@@ -219,6 +222,8 @@ protected function doCheckboxTriggerTests() {
// Only value1 should be disabled, value 2 should remain enabled.
$this->assertTrue($radios_some_disabled_value1->hasAttribute('disabled'));
$this->assertFalse($radios_some_disabled_value2->hasAttribute('disabled'));
// The link shouldn't be visible.
$this->assertFalse($link->isVisible());
// Change state: uncheck the checkbox.
$trigger->uncheck();
......@@ -252,6 +257,8 @@ protected function doCheckboxTriggerTests() {
$this->assertFalse($radios_all_disabled_value2->hasAttribute('disabled'));
$this->assertFalse($radios_some_disabled_value1->hasAttribute('disabled'));
$this->assertFalse($radios_some_disabled_value2->hasAttribute('disabled'));
// Check if the link is turned back to visible state.
$this->assertTrue($link->isVisible());
}
/**
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment