Skip to content
Snippets Groups Projects

#3428652 - fix js error in Date Formats machine name generation when using accented characters in label

Open #3428652 - fix js error in Date Formats machine name generation when using accented characters in label
issue/drupal-3428652:fix/3428652d-date_format_machine_name_pattern_replacement into 11.x
2 unresolved threads
Open Julien Maxant requested to merge issue/drupal-3428652:fix/3428652d-date_format_machine_name_pattern_replacement into 11.x
2 unresolved threads

Fixes :

  • Javascript error in ajax callback for machine name generation when using non-ASCII accented chars in label (such as åäöÅÄÖš).

Adds:

  • TestCase related to said characters in machine name

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #195308 passed

Stage: 🏗️ Build
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal-3428652

#195315

    Merge request pipeline passed for 02065a6f

    Code Quality is loading
    Test summary results are being parsed
    Full report
    Ready to merge by members who can write to the target branch.
    Loading

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    core/modules/system/src/Form/DateFormatFormBase.php
    14 14 */
    15 15 abstract class DateFormatFormBase extends EntityForm {
    16 16
    17 /**
    18 * Pattern used for preg_replace when generating machine name.
    19 *
    20 * Replaces capital characters & accented chars (à, â, å etc.) & reserved
    21 * keyword custom.
    22 *
    23 * @var string
    24 */
    25 public const REPLACE_PATTERN = '[^A-Za-zÀ-ÖØ-öø-ÿ0-9_]+|^custom$';
  • Prashant Chauhan added 1 commit

    added 1 commit

    • 20687afd - Review fix: Constant not being used anywhere else removed it

    Compare with previous version

  • Prashant Chauhan added 1 commit

    added 1 commit

    • c13e168d - Review fix: Constant not being used anywhere else removed it

    Compare with previous version

  • Théodore Biadala
    Théodore Biadala @nod_ started a thread on an old version of the diff
    • core/modules/system/src/Form/DateFormatFormBase.php
    88 88 '#default_value' => $this->entity->id(),
    89 89 '#machine_name' => [
    90 90 'exists' => [$this, 'exists'],
    91 'replace_pattern' => '([^a-z0-9_]+)|(^custom$)',
    91 'replace_pattern' => '[^A-Za-zÀ-ÖØ-öø-ÿ0-9_]+|^custom$',
  • Julien Maxant added 1 commit

    added 1 commit

    Compare with previous version

    • Please register or sign in to reply