Skip to content
Snippets Groups Projects

Remove QuickEditIntegration from Layout Builder

Closes #3264633

Merge request reports

Members who can merge are allowed to add commits.
Ready to merge by members who can write to the target branch.
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
172 179
173 180 $build['#attributes']['data-quickedit-entity-id'] = $entity->getEntityTypeId() . '/' . $entity->id();
174 181 }
182
183 /**
184 * Implements hook_quickedit_render_field().
185 *
186 * @todo can this go somewhere else?
  • Comment on lines +184 to +186
    Maintainer

    I would look at where the hook is invoked and decide from there. This appears to be in Drupal\quickedit\QuickEditController::renderField().

    Edited by Jess
  • I figured as much. It still feels to me it should be a hook implementation. Is there a pattern for contrib modules to provide hook implementations for core modules? I seem to recall views in contrib used to do this for node, etc.

  • It's also called from \Drupal\image\Controller\QuickEditImageController::upload so I'm inclined to leave it as a hook. It turns out it doesn't actually work when it's quickedit_quickedit_render_field (changes aren't reflected after saving). Changing to layout_builder_quickedit_render_field works if that is allowed.

  • Michael Strelan changed this line in version 3 of the diff

    changed this line in version 3 of the diff

  • Please register or sign in to reply
  • Jess
  • added 1 commit

    • fce05e51 - Refactor LayoutBuilderEntityViewDisplay

    Compare with previous version

  • Michael Strelan added 3 commits

    added 3 commits

    Compare with previous version

  • Michael Strelan added 2 commits

    added 2 commits

    • e08226b3 - Clean up unused use statements
    • 18f61cf5 - Make jsonapi/hal/rest modules happy

    Compare with previous version

  • Michael Strelan
  • Michael Strelan added 2 commits

    added 2 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Michael Strelan added 14 commits

    added 14 commits

    • b699f32f...18e36fa4 - 11 commits from branch project:9.4.x
    • e951d5f5 - Enable quickedit in HAL/REST tests
    • fdb014e5 - Merge branch '9.4.x' into 3264633-remove-layoutbuilder-quickeditintegration
    • a5f9ded2 - Fix test group

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Michael Strelan added 13 commits

    added 13 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Jess
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading