Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
D
drupal
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
drupal
Merge requests
!11249
Resolve
#3498100
"Duplicate summary on vertical tabs"
Code
Review changes
Check out branch
Download
Patches
Plain diff
Closed
Resolve
#3498100
"Duplicate summary on vertical tabs"
issue/drupal-3498100:3498100-duplicate-summary-on-vertical-tabs
into
11.x
Overview
1
Commits
7
Pipelines
7
Changes
6
1 unresolved thread
Hide all comments
Closed
Maximo Mena
requested to merge
issue/drupal-3498100:3498100-duplicate-summary-on-vertical-tabs
into
11.x
2 months ago
Overview
1
Commits
7
Pipelines
7
Changes
6
1 unresolved thread
Hide all comments
Expand
Closes
#3498100
0
0
Merge request reports
Compare
11.x
version 6
dce4041d
1 month ago
version 5
9f722b76
2 months ago
version 4
6fa1a679
2 months ago
version 3
42c530f8
2 months ago
version 2
307e0a7e
2 months ago
version 1
928b82f1
2 months ago
11.x (base)
and
latest version
latest version
bdd45173
7 commits,
1 month ago
version 6
dce4041d
6 commits,
1 month ago
version 5
9f722b76
5 commits,
2 months ago
version 4
6fa1a679
4 commits,
2 months ago
version 3
42c530f8
3 commits,
2 months ago
version 2
307e0a7e
2 commits,
2 months ago
version 1
928b82f1
1 commit,
2 months ago
6 files
+
161
−
1
Side-by-side
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
6
Search (e.g. *.vue) (Ctrl+P)
core/misc/vertical-tabs.js
+
6
−
1
Options
@@ -85,8 +85,13 @@
@@ -85,8 +85,13 @@
$details
.
each
(
function
()
{
$details
.
each
(
function
()
{
const
$that
=
$
(
this
);
const
$that
=
$
(
this
);
const
$summary
=
$that
.
find
(
'
> summary
'
);
const
$summary
=
$that
.
find
(
'
> summary
'
);
// Summary elements often have 2 child nodes: a text title and a
// dynamic summary wrapped in <span>. To set the vertical tab title,
// we only want to copy the summary title, which is the first child
// node.
const
title
=
$summary
[
0
]?.
firstChild
?.
textContent
||
''
;
const
verticalTab
=
new
Drupal
.
verticalTab
({
const
verticalTab
=
new
Drupal
.
verticalTab
({
title
:
$summary
.
length
?
$summary
[
0
].
textContent
:
''
,
title
,
details
:
$that
,
details
:
$that
,
});
});
tabList
.
append
(
verticalTab
.
item
);
tabList
.
append
(
verticalTab
.
item
);
Loading