Skip to content
Snippets Groups Projects

Resolve #3498100 "Duplicate summary on vertical tabs"

Open Resolve #3498100 "Duplicate summary on vertical tabs"
issue/drupal-3498100:3498100-duplicate-summary-on-vertical-tabs into 11.x
1 unresolved thread
Open Maximo Mena requested to merge issue/drupal-3498100:3498100-duplicate-summary-on-vertical-tabs into 11.x
1 unresolved thread

Closes #3498100

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #458712 passed

Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal-3498100

#458713

    Merge request pipeline passed for bdd45173

    Approval is optional
    Code Quality is loading
    Test summary results are being parsed
    Full report
    Ready to merge by members who can write to the target branch.
    • The source branch is 66 commits behind the target branch.
    • 2 commits and 1 merge commit will be added to .
    • Source branch will not be deleted.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    core/misc/vertical-tabs.js
    85 85 $details.each(function () {
    86 86 const $that = $(this);
    87 87 const $summary = $that.find('> summary');
    88 // Summary elements often have 2 child nodes: a text title and a
    89 // dynamic summary wrapped in <span>. To set the vertical tab title,
    90 // we only want to copy the summary title, which is the first child
    91 // node.
    92 const title =
    93 $summary.length && $summary[0].childNodes.length
    94 ? $summary[0].firstChild.textContent
    95 : '';
  • Maximo Mena added 184 commits

    added 184 commits

    • dce4041d...d81484de - 177 commits from branch project:11.x
    • fdb4b775 - Only the summary's first child node should be set as the vertical tab title
    • 165acb4c - Fix lint issues
    • 61fc0c13 - Improve explanation of code changes in comment
    • 5e8cb00e - Add test coverage for vertical-tabs form elements with dynamic summaries
    • 7a6b4d04 - Fix PHP coding standards issues
    • fd10df5e - Fix PHPStan issues
    • bdd45173 - Optimizing JS code changes

    Compare with previous version

    Toggle commit list
    • Please register or sign in to reply