Issue #3224523 by alexpott, longwave: [PHP 8.1] Add ReturnTypeWillChange attribute where necessary

core/modules/migrate/src/Plugin/migrate/source/SourcePluginBase.php

@@ -343,6 +343,7 @@ protected function getIterator() {
   /**
    * {@inheritdoc}
    */
+  #[\ReturnTypeWillChange]
   public function current() {
     return $this->currentRow;
   }
@@ -355,6 +356,7 @@ public function current() {
    * serialize to fulfill the requirement, but using getCurrentIds() is
    * preferable.
    */
+  #[\ReturnTypeWillChange]
   public function key() {
     return serialize($this->currentSourceIds);
   }
@@ -365,6 +367,7 @@ public function key() {
    * Implementation of \Iterator::valid() - called at the top of the loop,
    * returning TRUE to process the loop and FALSE to terminate it.
    */
+  #[\ReturnTypeWillChange]
   public function valid() {
     return isset($this->currentRow);
   }
@@ -376,6 +379,7 @@ public function valid() {
    * should implement initializeIterator() to do any class-specific setup for
    * iterating source records.
    */
+  #[\ReturnTypeWillChange]
   public function rewind() {
     $this->getIterator()->rewind();
     $this->next();
@@ -384,6 +388,7 @@ public function rewind() {
   /**
    * {@inheritdoc}
    */
+  #[\ReturnTypeWillChange]
   public function next() {
     $this->currentSourceIds = NULL;
     $this->currentRow = NULL;
@@ -486,6 +491,7 @@ public function getCurrentIds() {
    * @return int
    *   The count.
    */
+  #[\ReturnTypeWillChange]
   public function count($refresh = FALSE) {
     if ($this->skipCount) {
       return MigrateSourceInterface::NOT_COUNTABLE;

core/modules/system/tests/modules/session_test/src/Session/TestSessionHandlerProxy.php

@@ -37,6 +37,7 @@ public function __construct(\SessionHandlerInterface $session_handler, $optional
   /**
    * {@inheritdoc}
    */
+  #[\ReturnTypeWillChange]
   public function open($save_path, $name) {
     $trace = \Drupal::service('session_test.session_handler_proxy_trace');
     $trace[] = ['BEGIN', $this->optionalArgument, __FUNCTION__];
@@ -48,6 +49,7 @@ public function open($save_path, $name) {
   /**
    * {@inheritdoc}
    */
+  #[\ReturnTypeWillChange]
   public function close() {
     $trace = \Drupal::service('session_test.session_handler_proxy_trace');
     $trace[] = ['BEGIN', $this->optionalArgument, __FUNCTION__];
@@ -59,6 +61,7 @@ public function close() {
   /**
    * {@inheritdoc}
    */
+  #[\ReturnTypeWillChange]
   public function read($session_id) {
     $trace = \Drupal::service('session_test.session_handler_proxy_trace');
     $trace[] = ['BEGIN', $this->optionalArgument, __FUNCTION__, $session_id];
@@ -70,6 +73,7 @@ public function read($session_id) {
   /**
    * {@inheritdoc}
    */
+  #[\ReturnTypeWillChange]
   public function write($session_id, $session_data) {
     $trace = \Drupal::service('session_test.session_handler_proxy_trace');
     $trace[] = ['BEGIN', $this->optionalArgument, __FUNCTION__, $session_id];
@@ -81,6 +85,7 @@ public function write($session_id, $session_data) {
   /**
    * {@inheritdoc}
    */
+  #[\ReturnTypeWillChange]
   public function destroy($session_id) {
     return $this->sessionHandler->destroy($session_id);
   }
@@ -88,6 +93,7 @@ public function destroy($session_id) {
   /**
    * {@inheritdoc}
    */
+  #[\ReturnTypeWillChange]
   public function gc($max_lifetime) {
     return $this->sessionHandler->gc($max_lifetime);
   }

core/tests/Drupal/Tests/StreamCapturer.php

@@ -9,6 +9,7 @@ class StreamCapturer extends \php_user_filter {
 
   public static $cache = '';
 
+  #[\ReturnTypeWillChange]
   public function filter($in, $out, &$consumed, $closing) {
     while ($bucket = stream_bucket_make_writeable($in)) {
       self::$cache .= $bucket->data;