Skip to content
Snippets Groups Projects
Verified Commit e4e23732 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3439830 by thebumik, alexpott, pradhumanjain2311, vensires, smustgrave,...

Issue #3439830 by thebumik, alexpott, pradhumanjain2311, vensires, smustgrave, kristiaanvandeneynde, larowlan: Fix Comments tests that rely on UID1's super user behavior
parent 26e593af
No related branches found
No related tags found
27 merge requests!11131[10.4.x-only-DO-NOT-MERGE]: Issue ##2842525 Ajax attached to Views exposed filter form does not trigger callbacks,!9470[10.3.x-only-DO-NOT-MERGE]: #3331771 Fix file_get_contents(): Passing null to parameter,!8540Issue #3457061: Bootstrap Modal dialog Not closing after 10.3.0 Update,!8528Issue #3456871 by Tim Bozeman: Support NULL services,!8373Issue #3427374 by danflanagan8, Vighneshh: taxonomy_tid ViewsArgumentDefault...,!7526Expose roles in response,!3878Removed unused condition head title for views,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2794Issue #3100732: Allow specifying `meta` data on JSON:API objects,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #147857 canceled
Pipeline: drupal

#147861

    ......@@ -15,14 +15,6 @@
    */
    class CommentStatisticsTest extends CommentTestBase {
    /**
    * {@inheritdoc}
    *
    * @todo Remove and fix test to not rely on super user.
    * @see https://www.drupal.org/project/drupal/issues/3437620
    */
    protected bool $usesSuperUserAccessPolicy = TRUE;
    /**
    * A secondary user for posting comments.
    *
    ......@@ -41,12 +33,17 @@ class CommentStatisticsTest extends CommentTestBase {
    protected function setUp(): void {
    parent::setUp();
    // Add more permissions the admin user.
    $this->adminUser->addRole($this->drupalCreateRole([
    'administer permissions',
    'access administration pages',
    'administer site configuration',
    ]))->save();
    // Create a second user to post comments.
    $this->webUser2 = $this->drupalCreateUser([
    'post comments',
    'create article content',
    'edit own comments',
    'post comments',
    'skip comment approval',
    'access comments',
    'access content',
    ......@@ -88,7 +85,8 @@ public function testCommentNodeCommentStatistics() {
    // Prepare for anonymous comment submission (comment approval enabled).
    // Note we don't use user_role_change_permissions(), because that caused
    // random test failures.
    $this->drupalLogin($this->rootUser);
    $this->drupalLogin($this->adminUser);
    $this->drupalGet('admin/people/permissions');
    $edit = [
    'anonymous[access comments]' => 1,
    ......@@ -117,7 +115,7 @@ public function testCommentNodeCommentStatistics() {
    // Prepare for anonymous comment submission (no approval required).
    // Note we don't use user_role_change_permissions(), because that caused
    // random test failures.
    $this->drupalLogin($this->rootUser);
    $this->drupalLogin($this->adminUser);
    $this->drupalGet('admin/people/permissions');
    $edit = [
    'anonymous[skip comment approval]' => 1,
    ......
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Finish editing this message first!
    Please register or to comment