Skip to content
Snippets Groups Projects
Commit e036e737 authored by catch's avatar catch
Browse files

Issue #3418453 by longwave, Spokje: Remove withConsecutive() in FormCacheTest

parent af369c3c
No related branches found
No related tags found
26 merge requests!8528Issue #3456871 by Tim Bozeman: Support NULL services,!3878Removed unused condition head title for views,!38582585169-10.1.x,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3668Resolve #3347842 "Deprecate the trusted",!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3226Issue #2987537: Custom menu link entity type should not declare "bundle" entity key,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #86431 passed with warnings
Stage: 🏗️ Build
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal

#86433

    Hide whitespace changes
    Inline Side-by-side
    core/phpstan-baseline.neon
    + 0
    − 5
    View file @ e036e737
    ...@@ -3328,11 +3328,6 @@ parameters: ...@@ -3328,11 +3328,6 @@ parameters:
    count: 1 count: 1
    path: tests/Drupal/Tests/Core/EventSubscriber/SpecialAttributesRouteSubscriberTest.php path: tests/Drupal/Tests/Core/EventSubscriber/SpecialAttributesRouteSubscriberTest.php
    -
    message: "#^Call to deprecated method withConsecutive\\(\\) of class PHPUnit\\\\Framework\\\\MockObject\\\\Builder\\\\InvocationMocker\\.$#"
    count: 1
    path: tests/Drupal/Tests/Core/Form/FormCacheTest.php
    - -
    message: """ message: """
    #^Call to deprecated method getConfig\\(\\) of class GuzzleHttp\\\\Client\\: #^Call to deprecated method getConfig\\(\\) of class GuzzleHttp\\\\Client\\:
    ......
    core/tests/Drupal/Tests/Core/Form/FormCacheTest.php
    + 7
    − 9
    View file @ e036e737
    ...@@ -45,7 +45,7 @@ class FormCacheTest extends UnitTestCase { ...@@ -45,7 +45,7 @@ class FormCacheTest extends UnitTestCase {
    /** /**
    * The mocked module handler. * The mocked module handler.
    * *
    * @var \Drupal\Core\Extension\ModuleHandlerInterface|\PHPUnit\Framework\MockObject\MockObject * @var \Prophecy\Prophecy\ObjectProphecy
    */ */
    protected $moduleHandler; protected $moduleHandler;
    ...@@ -100,7 +100,7 @@ class FormCacheTest extends UnitTestCase { ...@@ -100,7 +100,7 @@ class FormCacheTest extends UnitTestCase {
    protected function setUp(): void { protected function setUp(): void {
    parent::setUp(); parent::setUp();
    $this->moduleHandler = $this->createMock('Drupal\Core\Extension\ModuleHandlerInterface'); $this->moduleHandler = $this->prophesize('Drupal\Core\Extension\ModuleHandlerInterface');
    $this->formCacheStore = $this->createMock('Drupal\Core\KeyValueStore\KeyValueStoreExpirableInterface'); $this->formCacheStore = $this->createMock('Drupal\Core\KeyValueStore\KeyValueStoreExpirableInterface');
    $this->formStateCacheStore = $this->createMock('Drupal\Core\KeyValueStore\KeyValueStoreExpirableInterface'); $this->formStateCacheStore = $this->createMock('Drupal\Core\KeyValueStore\KeyValueStoreExpirableInterface');
    ...@@ -121,7 +121,7 @@ protected function setUp(): void { ...@@ -121,7 +121,7 @@ protected function setUp(): void {
    $this->requestStack = $this->createMock('\Symfony\Component\HttpFoundation\RequestStack'); $this->requestStack = $this->createMock('\Symfony\Component\HttpFoundation\RequestStack');
    $this->requestPolicy = $this->createMock('\Drupal\Core\PageCache\RequestPolicyInterface'); $this->requestPolicy = $this->createMock('\Drupal\Core\PageCache\RequestPolicyInterface');
    $this->formCache = new FormCache($this->root, $this->keyValueExpirableFactory, $this->moduleHandler, $this->account, $this->csrfToken, $this->logger, $this->requestStack, $this->requestPolicy); $this->formCache = new FormCache($this->root, $this->keyValueExpirableFactory, $this->moduleHandler->reveal(), $this->account, $this->csrfToken, $this->logger, $this->requestStack, $this->requestPolicy);
    } }
    /** /**
    ...@@ -313,12 +313,10 @@ public function testLoadCachedFormStateWithFiles() { ...@@ -313,12 +313,10 @@ public function testLoadCachedFormStateWithFiles() {
    ], ],
    ], ],
    ]; ];
    $this->moduleHandler->expects($this->exactly(2)) $this->moduleHandler->loadInclude('a_module', 'the_type', 'some_name')
    ->method('loadInclude') ->shouldBeCalledOnce();
    ->withConsecutive( $this->moduleHandler->loadInclude('another_module', 'inc', 'another_module')
    ['a_module', 'the_type', 'some_name'], ->shouldBeCalledOnce();
    ['another_module', 'inc', 'another_module'],
    );
    $this->formStateCacheStore->expects($this->once()) $this->formStateCacheStore->expects($this->once())
    ->method('get') ->method('get')
    ->with($form_build_id) ->with($form_build_id)
    ......
    0% or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Finish editing this message first!
    Please register or to comment