Issue #3421480 by Spokje, longwave, andypost: Convert OpenerResolver to use a service locator

core/modules/media_library/media_library.services.yml

@@ -9,8 +9,8 @@ services:
     class: Drupal\media_library\Routing\RouteSubscriber
   media_library.opener_resolver:
     class: Drupal\media_library\OpenerResolver
-    calls:
-      - [setContainer, ['@service_container']]
+    tags:
+      - { name: service_collector, tag: media_library.opener, call: addOpener }
   Drupal\media_library\OpenerResolverInterface: '@media_library.opener_resolver'
   media_library.opener.field_widget:
     class: Drupal\media_library\MediaLibraryFieldWidgetOpener

core/modules/media_library/src/MediaLibraryServiceProvider.php

+<?php
+
+declare(strict_types=1);
+
+namespace Drupal\media_library;
+
+use Drupal\Core\DependencyInjection\ContainerBuilder;
+use Drupal\Core\DependencyInjection\ServiceProviderInterface;
+
+/**
+ * Service provider for media library services.
+ */
+class MediaLibraryServiceProvider implements ServiceProviderInterface {
+
+  /**
+   * {@inheritdoc}
+   */
+  public function register(ContainerBuilder $container) {
+    $container->registerForAutoconfiguration(MediaLibraryOpenerInterface::class)
+      ->addTag('media_library.opener');
+  }
+
+}

core/modules/media_library/src/OpenerResolver.php

@@ -2,10 +2,8 @@
 
 namespace Drupal\media_library;
 
-use Symfony\Component\DependencyInjection\ContainerAwareTrait;
-
 /**
- * Defines a class to get media library openers from the container.
+ * Defines a class to resolve media library openers.
  *
  * This is intended to be a very thin interface-verifying wrapper around
  * services which implement \Drupal\media_library\MediaLibraryOpenerInterface.
@@ -18,7 +16,22 @@
  */
 class OpenerResolver implements OpenerResolverInterface {
 
-  use ContainerAwareTrait;
+  /**
+   * @var \Drupal\media_library\MediaLibraryOpenerInterface[]
+   */
+  protected array $openers = [];
+
+  /**
+   * Registers an opener.
+   *
+   * @param \Drupal\media_library\MediaLibraryOpenerInterface $opener
+   *   The opener.
+   * @param string $id
+   *   The service ID.
+   */
+  public function addOpener(MediaLibraryOpenerInterface $opener, string $id): void {
+    $this->openers[$id] = $opener;
+  }
 
   /**
    * {@inheritdoc}
@@ -26,7 +39,7 @@ class OpenerResolver implements OpenerResolverInterface {
   public function get(MediaLibraryState $state) {
     $service_id = $state->getOpenerId();
 
-    $service = $this->container->get($service_id);
+    $service = $this->openers[$service_id] ?? NULL;
     if ($service instanceof MediaLibraryOpenerInterface) {
       return $service;
     }

core/modules/media_library/tests/src/Kernel/MediaLibraryAddFormTest.php

@@ -29,6 +29,7 @@ class MediaLibraryAddFormTest extends KernelTestBase {
     'media_library',
     'file',
     'field',
+    'filter',
     'image',
     'system',
     'views',

core/modules/media_library/tests/src/Kernel/MediaLibraryWidgetTest.php

@@ -29,6 +29,7 @@ class MediaLibraryWidgetTest extends KernelTestBase {
     'media',
     'media_library',
     'field',
+    'filter',
     'image',
     'system',
     'views',

core/phpstan-baseline.neon

@@ -1161,14 +1161,6 @@ parameters:
 			count: 1
 			path: modules/media/src/OEmbed/UrlResolver.php
 
-		-
-			message: """
-				#^Usage of deprecated trait Symfony\\\\Component\\\\DependencyInjection\\\\ContainerAwareTrait in class Drupal\\\\media_library\\\\OpenerResolver\\:
-				since Symfony 6\\.4, use dependency injection instead$#
-			"""
-			count: 1
-			path: modules/media_library/src/OpenerResolver.php
-
 		-
 			message: "#^Variable \\$jpg_image might not be defined\\.$#"
 			count: 1