Issue #3437589 by andypost: Move permission, jsonapi and rest tests out of the action module

core/modules/action/action.permissions.yml

-administer actions:
-  title: 'Administer actions'
-  restrict access: true

core/modules/action/tests/src/Functional/Jsonapi/ActionTest.php → core/modules/jsonapi/tests/src/Functional/ActionTest.php

@@ -2,26 +2,24 @@
 
 declare(strict_types=1);
 
-namespace Drupal\Tests\action\Functional\Jsonapi;
+namespace Drupal\Tests\jsonapi\Functional;
 
 use Drupal\Core\Url;
-use Drupal\Tests\jsonapi\Functional\ConfigEntityResourceTestBase;
 use Drupal\system\Entity\Action;
 use Drupal\user\RoleInterface;
 
 /**
  * JSON:API integration test for the "Action" config entity type.
  *
- * @group action
+ * @group Action
  * @group #slow
- * @group legacy
  */
 class ActionTest extends ConfigEntityResourceTestBase {
 
   /**
    * {@inheritdoc}
    */
-  protected static $modules = ['action'];
+  protected static $modules = [];
 
   /**
    * {@inheritdoc}

core/modules/system/system.permissions.yml

@@ -29,3 +29,6 @@ link to any page:
   description: 'This allows to bypass access checking when linking to internal paths.'
 administer menu:
   title: 'Administer menus and menu links'
+administer actions:
+  title: 'Administer actions'
+  restrict access: true

core/modules/action/tests/src/Functional/Rest/ActionJsonAnonTest.php → core/modules/system/tests/src/Functional/Rest/ActionJsonAnonTest.php

@@ -2,13 +2,12 @@
 
 declare(strict_types=1);
 
-namespace Drupal\Tests\action\Functional\Rest;
+namespace Drupal\Tests\system\Functional\Rest;
 
 use Drupal\Tests\rest\Functional\AnonResourceTestTrait;
 
 /**
- * @group action
- * @group legacy
+ * @group Action
  */
 class ActionJsonAnonTest extends ActionResourceTestBase {
 

core/modules/action/tests/src/Functional/Rest/ActionJsonBasicAuthTest.php → core/modules/system/tests/src/Functional/Rest/ActionJsonBasicAuthTest.php

@@ -2,13 +2,12 @@
 
 declare(strict_types=1);
 
-namespace Drupal\Tests\action\Functional\Rest;
+namespace Drupal\Tests\system\Functional\Rest;
 
 use Drupal\Tests\rest\Functional\BasicAuthResourceTestTrait;
 
 /**
- * @group action
- * @group legacy
+ * @group Action
  */
 class ActionJsonBasicAuthTest extends ActionResourceTestBase {
 

core/modules/action/tests/src/Functional/Rest/ActionJsonCookieTest.php → core/modules/system/tests/src/Functional/Rest/ActionJsonCookieTest.php

@@ -2,13 +2,12 @@
 
 declare(strict_types=1);
 
-namespace Drupal\Tests\action\Functional\Rest;
+namespace Drupal\Tests\system\Functional\Rest;
 
 use Drupal\Tests\rest\Functional\CookieResourceTestTrait;
 
 /**
- * @group action
- * @group legacy
+ * @group Action
  */
 class ActionJsonCookieTest extends ActionResourceTestBase {
 

core/modules/action/tests/src/Functional/Rest/ActionResourceTestBase.php → core/modules/system/tests/src/Functional/Rest/ActionResourceTestBase.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Drupal\Tests\action\Functional\Rest;
+namespace Drupal\Tests\system\Functional\Rest;
 
 use Drupal\Tests\rest\Functional\EntityResource\ConfigEntityResourceTestBase;
 use Drupal\system\Entity\Action;
@@ -13,7 +13,7 @@ abstract class ActionResourceTestBase extends ConfigEntityResourceTestBase {
   /**
    * {@inheritdoc}
    */
-  protected static $modules = ['action', 'user'];
+  protected static $modules = ['user'];
 
   /**
    * {@inheritdoc}
@@ -80,4 +80,13 @@ protected function getNormalizedPostEntity() {
     return [];
   }
 
+  /**
+   * {@inheritdoc}
+   */
+  protected function getExpectedCacheContexts() {
+    return [
+      'user.permissions',
+    ];
+  }
+
 }

core/modules/action/tests/src/Functional/Rest/ActionXmlAnonTest.php → core/modules/system/tests/src/Functional/Rest/ActionXmlAnonTest.php

@@ -2,14 +2,13 @@
 
 declare(strict_types=1);
 
-namespace Drupal\Tests\action\Functional\Rest;
+namespace Drupal\Tests\system\Functional\Rest;
 
 use Drupal\Tests\rest\Functional\AnonResourceTestTrait;
 use Drupal\Tests\rest\Functional\EntityResource\XmlEntityNormalizationQuirksTrait;
 
 /**
- * @group action
- * @group legacy
+ * @group Action
  */
 class ActionXmlAnonTest extends ActionResourceTestBase {
 

core/modules/action/tests/src/Functional/Rest/ActionXmlBasicAuthTest.php → core/modules/system/tests/src/Functional/Rest/ActionXmlBasicAuthTest.php

@@ -2,14 +2,13 @@
 
 declare(strict_types=1);
 
-namespace Drupal\Tests\action\Functional\Rest;
+namespace Drupal\Tests\system\Functional\Rest;
 
 use Drupal\Tests\rest\Functional\BasicAuthResourceTestTrait;
 use Drupal\Tests\rest\Functional\EntityResource\XmlEntityNormalizationQuirksTrait;
 
 /**
- * @group action
- * @group legacy
+ * @group Action
  */
 class ActionXmlBasicAuthTest extends ActionResourceTestBase {
 

core/modules/action/tests/src/Functional/Rest/ActionXmlCookieTest.php → core/modules/system/tests/src/Functional/Rest/ActionXmlCookieTest.php

@@ -2,14 +2,13 @@
 
 declare(strict_types=1);
 
-namespace Drupal\Tests\action\Functional\Rest;
+namespace Drupal\Tests\system\Functional\Rest;
 
 use Drupal\Tests\rest\Functional\CookieResourceTestTrait;
 use Drupal\Tests\rest\Functional\EntityResource\XmlEntityNormalizationQuirksTrait;
 
 /**
- * @group action
- * @group legacy
+ * @group Action
  */
 class ActionXmlCookieTest extends ActionResourceTestBase {
 

core/modules/user/tests/src/Kernel/Migrate/d7/MigrateUserRoleTest.php

@@ -55,6 +55,7 @@ public function testUserRole() {
       'access site in maintenance mode',
       'access site reports',
       'access user profiles',
+      'administer actions',
       'administer menu',
       'administer modules',
       'administer permissions',
@@ -141,7 +142,6 @@ public function testUserRole() {
       'access toolbar',
       'access user contact forms',
       'add content to books',
-      'administer actions',
       'administer blocks',
       'administer book outlines',
       'administer comments',