Commit bf1ed94f authored by catch's avatar catch
Browse files

Issue #3105990 by Hardik_Patel_12, ravi.shankar, Rangaswini: Type hint...

Issue #3105990 by Hardik_Patel_12, ravi.shankar, Rangaswini: Type hint "\Drupal\views\ViewExecutable" missing for $view in views module
parent 96e280c8
......@@ -4,6 +4,7 @@
use Drupal\views\Plugin\views\join\FieldOrLanguageJoin;
use Drupal\views\Views;
use Drupal\views\ViewExecutable;
/**
* Tests the "field OR language" join plugin.
......@@ -191,7 +192,7 @@ public function testLanguageBundleConditions() {
* \Drupal\Core\Database\Query\Select::$tables for more information on the
* structure of the array.
*/
protected function buildJoin($view, $configuration, $table_alias) {
protected function buildJoin(ViewExecutable $view, $configuration, $table_alias) {
// Build the actual join values and read them back from the query object.
$query = \Drupal::database()->select('node');
......
......@@ -4,6 +4,7 @@
use Drupal\Component\Render\FormattableMarkup;
use Drupal\views\Views;
use Drupal\views\ViewExecutable;
/**
* Tests mapping style functionality.
......@@ -45,7 +46,7 @@ public function testMappedOutput() {
* @return string
* The view rendered as HTML.
*/
protected function mappedOutputHelper($view) {
protected function mappedOutputHelper(ViewExecutable $view) {
$output = $view->preview();
$rendered_output = \Drupal::service('renderer')->renderRoot($output);
$this->storeViewPreview($rendered_output);
......
......@@ -354,7 +354,7 @@ public function testDestroy() {
*
* @param \Drupal\views\ViewExecutable $view
*/
protected function assertViewDestroy($view) {
protected function assertViewDestroy(ViewExecutable $view) {
$reflection = new \ReflectionClass($view);
$defaults = $reflection->getDefaultProperties();
// The storage and user should remain.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment