From bf1ed94fb34520a7a98f9980ee9faa9ec8d46786 Mon Sep 17 00:00:00 2001
From: catch <catch@35733.no-reply.drupal.org>
Date: Tue, 4 Feb 2020 09:41:29 +0000
Subject: [PATCH] Issue #3105990 by Hardik_Patel_12, ravi.shankar, Rangaswini:
Type hint "\Drupal\views\ViewExecutable" missing for $view in views module
---
.../views/tests/src/Kernel/Plugin/FieldOrLanguageJoinTest.php | 3 ++-
.../modules/views/tests/src/Kernel/Plugin/StyleMappingTest.php | 3 ++-
core/modules/views/tests/src/Kernel/ViewExecutableTest.php | 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/core/modules/views/tests/src/Kernel/Plugin/FieldOrLanguageJoinTest.php b/core/modules/views/tests/src/Kernel/Plugin/FieldOrLanguageJoinTest.php
index 34e4f93000dd..823ffdefd5ee 100644
--- a/core/modules/views/tests/src/Kernel/Plugin/FieldOrLanguageJoinTest.php
+++ b/core/modules/views/tests/src/Kernel/Plugin/FieldOrLanguageJoinTest.php
@@ -4,6 +4,7 @@
use Drupal\views\Plugin\views\join\FieldOrLanguageJoin;
use Drupal\views\Views;
+use Drupal\views\ViewExecutable;
/**
* Tests the "field OR language" join plugin.
@@ -191,7 +192,7 @@ public function testLanguageBundleConditions() {
* \Drupal\Core\Database\Query\Select::$tables for more information on the
* structure of the array.
*/
- protected function buildJoin($view, $configuration, $table_alias) {
+ protected function buildJoin(ViewExecutable $view, $configuration, $table_alias) {
// Build the actual join values and read them back from the query object.
$query = \Drupal::database()->select('node');
diff --git a/core/modules/views/tests/src/Kernel/Plugin/StyleMappingTest.php b/core/modules/views/tests/src/Kernel/Plugin/StyleMappingTest.php
index d83b2643ac8c..353a258bc951 100644
--- a/core/modules/views/tests/src/Kernel/Plugin/StyleMappingTest.php
+++ b/core/modules/views/tests/src/Kernel/Plugin/StyleMappingTest.php
@@ -4,6 +4,7 @@
use Drupal\Component\Render\FormattableMarkup;
use Drupal\views\Views;
+use Drupal\views\ViewExecutable;
/**
* Tests mapping style functionality.
@@ -45,7 +46,7 @@ public function testMappedOutput() {
* @return string
* The view rendered as HTML.
*/
- protected function mappedOutputHelper($view) {
+ protected function mappedOutputHelper(ViewExecutable $view) {
$output = $view->preview();
$rendered_output = \Drupal::service('renderer')->renderRoot($output);
$this->storeViewPreview($rendered_output);
diff --git a/core/modules/views/tests/src/Kernel/ViewExecutableTest.php b/core/modules/views/tests/src/Kernel/ViewExecutableTest.php
index 84d2504e25df..1c32786b8a29 100644
--- a/core/modules/views/tests/src/Kernel/ViewExecutableTest.php
+++ b/core/modules/views/tests/src/Kernel/ViewExecutableTest.php
@@ -354,7 +354,7 @@ public function testDestroy() {
*
* @param \Drupal\views\ViewExecutable $view
*/
- protected function assertViewDestroy($view) {
+ protected function assertViewDestroy(ViewExecutable $view) {
$reflection = new \ReflectionClass($view);
$defaults = $reflection->getDefaultProperties();
// The storage and user should remain.
--
GitLab