Skip to content
Snippets Groups Projects
Verified Commit b3c74ca1 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3415118 by ahmad.k, Lendude: Combine fields filter REGEXP causes PostgreSQL syntax error

parent eacd1fa3
No related branches found
No related tags found
35 merge requests!12227Issue #3181946 by jonmcl, mglaman,!11131[10.4.x-only-DO-NOT-MERGE]: Issue ##2842525 Ajax attached to Views exposed filter form does not trigger callbacks,!9470[10.3.x-only-DO-NOT-MERGE]: #3331771 Fix file_get_contents(): Passing null to parameter,!8540Issue #3457061: Bootstrap Modal dialog Not closing after 10.3.0 Update,!8528Issue #3456871 by Tim Bozeman: Support NULL services,!8373Issue #3427374 by danflanagan8, Vighneshh: taxonomy_tid ViewsArgumentDefault...,!7526Expose roles in response,!7352Draft: Resolve #3203489 "Set filename as",!6880Add @property to the DateTimeItem,!5423Draft: Resolve #3329907 "Test2",!3878Removed unused condition head title for views,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3668Resolve #3347842 "Deprecate the trusted",!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3478Issue #3337882: Deleted menus are not removed from content type config,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2794Issue #3100732: Allow specifying `meta` data on JSON:API objects,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #106794 canceled
Pipeline: drupal

#106796

    ......@@ -210,7 +210,8 @@ protected function opNotLike($expression) {
    protected function opRegex($expression) {
    $placeholder = $this->placeholder();
    $this->query->addWhereExpression($this->options['group'], "$expression REGEXP $placeholder", [$placeholder => $this->value]);
    $operator = $this->getConditionOperator('REGEXP');
    $this->query->addWhereExpression($this->options['group'], "$expression $operator $placeholder", [$placeholder => $this->value]);
    }
    protected function opEmpty($expression) {
    ......
    ......@@ -98,6 +98,65 @@ public function testFilterCombineContains() {
    $this->assertIdenticalResultset($view, $resultset, $this->columnMap);
    }
    /**
    * Tests the Combine field filter with the 'regular_expression' operator.
    */
    public function testFilterCombineRegEx() {
    $view = Views::getView('test_view');
    $view->setDisplay();
    $fields = $view->displayHandlers->get('default')->getOption('fields');
    $view->displayHandlers->get('default')->overrideOption('fields', $fields + [
    'job' => [
    'id' => 'job',
    'table' => 'views_test_data',
    'field' => 'job',
    'relationship' => 'none',
    ],
    ]);
    // Change the filtering.
    $view->displayHandlers->get('default')->overrideOption('filters', [
    'age' => [
    'id' => 'combine',
    'table' => 'views',
    'field' => 'combine',
    'relationship' => 'none',
    'operator' => 'regular_expression',
    'fields' => [
    'name',
    'job',
    ],
    'value' => '(ing|write)',
    ],
    ]);
    $this->executeView($view);
    $resultset = [
    [
    'name' => 'John',
    'job' => 'Singer',
    ],
    [
    'name' => 'George',
    'job' => 'Singer',
    ],
    [
    'name' => 'Ringo',
    'job' => 'Drummer',
    ],
    [
    'name' => 'Paul',
    'job' => 'Songwriter',
    ],
    [
    'name' => 'Ginger',
    'job' => NULL,
    ],
    ];
    $this->assertIdenticalResultset($view, $resultset, $this->columnMap);
    }
    /**
    * Tests the Combine field filter with the 'word' operator.
    */
    ......
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Please register or to comment