Issue #3417531 by longwave, mondrake: Remove withConsecutive() in pgsql SchemaTest

core/modules/pgsql/tests/src/Unit/SchemaTest.php

@@ -6,8 +6,7 @@
 
 use Drupal\pgsql\Driver\Database\pgsql\Schema;
 use Drupal\Tests\UnitTestCase;
-
-// cSpell:ignore conname
+use Prophecy\Argument;
 
 /**
  * @coversDefaultClass \Drupal\pgsql\Driver\Database\pgsql\Schema
@@ -15,24 +14,6 @@
  */
 class SchemaTest extends UnitTestCase {
 
-  /**
-   * The PostgreSql DB connection.
-   *
-   * @var \PHPUnit\Framework\MockObject\MockObject|\Drupal\pgsql\Driver\Database\pgsql\Connection
-   */
-  protected $connection;
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function setUp(): void {
-    parent::setUp();
-
-    $this->connection = $this->getMockBuilder('\Drupal\pgsql\Driver\Database\pgsql\Connection')
-      ->disableOriginalConstructor()
-      ->getMock();
-  }
-
   /**
    * Tests whether the actual constraint name is correctly computed.
    *
@@ -48,24 +29,20 @@ protected function setUp(): void {
    */
   public function testComputedConstraintName($table_name, $name, $expected) {
     $max_identifier_length = 63;
-    $schema = new Schema($this->connection);
 
-    $statement = $this->createMock('\Drupal\Core\Database\StatementInterface');
-    $statement->expects($this->any())
-      ->method('fetchField')
-      ->willReturn($max_identifier_length);
+    $connection = $this->prophesize('\Drupal\pgsql\Driver\Database\pgsql\Connection');
+    $connection->getConnectionOptions()->willReturn([]);
+    $connection->getPrefix()->willReturn('');
+
+    $statement = $this->prophesize('\Drupal\Core\Database\StatementInterface');
+    $statement->fetchField()->willReturn($max_identifier_length);
+    $connection->query('SHOW max_identifier_length')->willReturn($statement->reveal());
 
-    $this->connection->expects($this->exactly(2))
-      ->method('query')
-      ->withConsecutive(
-        [$this->anything()],
-        ["SELECT 1 FROM pg_constraint WHERE conname = '$expected'"],
-      )
-      ->willReturnOnConsecutiveCalls(
-        $statement,
-        $this->createMock('\Drupal\Core\Database\StatementInterface'),
-      );
+    $connection->query(Argument::containingString($expected))
+      ->willReturn($this->prophesize('\Drupal\Core\Database\StatementInterface')->reveal())
+      ->shouldBeCalled();
 
+    $schema = new Schema($connection->reveal());
     $schema->constraintExists($table_name, $name);
   }
 

core/phpstan-baseline.neon

@@ -2078,11 +2078,6 @@ parameters:
 			count: 1
 			path: modules/pgsql/src/Update10101.php
 
-		-
-			message: "#^Call to deprecated method withConsecutive\\(\\) of class PHPUnit\\\\Framework\\\\MockObject\\\\Builder\\\\InvocationMocker\\.$#"
-			count: 1
-			path: modules/pgsql/tests/src/Unit/SchemaTest.php
-
 		-
 			message: "#^Variable \\$responsive_image_styles in empty\\(\\) always exists and is not falsy\\.$#"
 			count: 1