Skip to content
Snippets Groups Projects
Verified Commit 82df75eb authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3436391 by mondrake: Fix return typehinting for Validator related classes

parent 9dbd2a6b
Branches
Tags
32 merge requests!12227Issue #3181946 by jonmcl, mglaman,!11131[10.4.x-only-DO-NOT-MERGE]: Issue ##2842525 Ajax attached to Views exposed filter form does not trigger callbacks,!9470[10.3.x-only-DO-NOT-MERGE]: #3331771 Fix file_get_contents(): Passing null to parameter,!8540Issue #3457061: Bootstrap Modal dialog Not closing after 10.3.0 Update,!8528Issue #3456871 by Tim Bozeman: Support NULL services,!8373Issue #3427374 by danflanagan8, Vighneshh: taxonomy_tid ViewsArgumentDefault...,!7526Expose roles in response,!7352Draft: Resolve #3203489 "Set filename as",!5423Draft: Resolve #3329907 "Test2",!3878Removed unused condition head title for views,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3478Issue #3337882: Deleted menus are not removed from content type config,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2794Issue #3100732: Allow specifying `meta` data on JSON:API objects,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!213Issue #2906496: Give Media a menu item under Content
Pipeline #132511 canceled
Pipeline: drupal

#132514

    Showing
    with 20 additions and 20 deletions
    ......@@ -42,7 +42,7 @@ public static function create(ContainerInterface $container) {
    /**
    * {@inheritdoc}
    */
    public function validate(mixed $name, Constraint $constraint) {
    public function validate(mixed $name, Constraint $constraint): void {
    assert($constraint instanceof ConfigExistsConstraint);
    // This constraint may be used to validate nullable (optional) values.
    ......
    ......@@ -48,7 +48,7 @@ public static function create(ContainerInterface $container) {
    /**
    * {@inheritdoc}
    */
    public function validate(mixed $entity, Constraint $constraint) {
    public function validate(mixed $entity, Constraint $constraint): void {
    assert($constraint instanceof RequiredConfigDependenciesConstraint);
    // Only config entities can have config dependencies.
    ......
    ......@@ -13,7 +13,7 @@ class EntityChangedConstraintValidator extends ConstraintValidator {
    /**
    * {@inheritdoc}
    */
    public function validate($entity, Constraint $constraint) {
    public function validate($entity, Constraint $constraint): void {
    if (isset($entity)) {
    /** @var \Drupal\Core\Entity\EntityInterface $entity */
    if (!$entity->isNew()) {
    ......
    ......@@ -14,7 +14,7 @@ class EntityHasFieldConstraintValidator extends ConstraintValidator {
    /**
    * {@inheritdoc}
    */
    public function validate($entity, Constraint $constraint) {
    public function validate($entity, Constraint $constraint): void {
    if (!isset($entity)) {
    return;
    }
    ......
    ......@@ -46,7 +46,7 @@ public static function create(ContainerInterface $container) {
    /**
    * {@inheritdoc}
    */
    public function validate($entity, Constraint $constraint) {
    public function validate($entity, Constraint $constraint): void {
    /** @var \Drupal\Core\Entity\ContentEntityInterface $entity */
    /** @var \Drupal\Core\Entity\Plugin\Validation\Constraint\EntityUntranslatableFieldsConstraint $constraint */
    ......
    ......@@ -40,7 +40,7 @@ public static function create(ContainerInterface $container): static {
    /**
    * {@inheritdoc}
    */
    public function validate(mixed $value, Constraint $constraint) {
    public function validate(mixed $value, Constraint $constraint): void {
    assert($constraint instanceof ImmutablePropertiesConstraint);
    if (!$value instanceof ConfigEntityInterface) {
    ......
    ......@@ -13,7 +13,7 @@ class ReferenceAccessConstraintValidator extends ConstraintValidator {
    /**
    * {@inheritdoc}
    */
    public function validate($value, Constraint $constraint) {
    public function validate($value, Constraint $constraint): void {
    /** @var \Drupal\Core\Field\FieldItemInterface $value */
    if (!isset($value)) {
    return;
    ......
    ......@@ -55,7 +55,7 @@ public static function create(ContainerInterface $container) {
    /**
    * {@inheritdoc}
    */
    public function validate($value, Constraint $constraint) {
    public function validate($value, Constraint $constraint): void {
    /** @var \Drupal\Core\Field\FieldItemListInterface $value */
    /** @var ValidReferenceConstraint $constraint */
    if (!isset($value)) {
    ......
    ......@@ -56,7 +56,7 @@ public static function create(ContainerInterface $container) {
    /**
    * {@inheritdoc}
    */
    public function validate(mixed $extension_name, Constraint $constraint) {
    public function validate(mixed $extension_name, Constraint $constraint): void {
    $variables = ['@name' => $extension_name];
    switch ($constraint->type) {
    ......
    ......@@ -42,7 +42,7 @@ public static function create(ContainerInterface $container) {
    /**
    * {@inheritdoc}
    */
    public function validate($entity, Constraint $constraint) {
    public function validate($entity, Constraint $constraint): void {
    /** @var \Drupal\path_alias\PathAliasInterface $entity */
    $path = $entity->getPath();
    $alias = $entity->getAlias();
    ......
    ......@@ -42,7 +42,7 @@ public static function create(ContainerInterface $container) {
    /**
    * {@inheritdoc}
    */
    public function validate($value, Constraint $constraint) {
    public function validate($value, Constraint $constraint): void {
    if (!isset($value)) {
    return;
    }
    ......
    ......@@ -17,7 +17,7 @@ class PluginExistsConstraintValidator extends ConstraintValidator {
    /**
    * {@inheritdoc}
    */
    public function validate(mixed $plugin_id, Constraint $constraint) {
    public function validate(mixed $plugin_id, Constraint $constraint): void {
    assert($constraint instanceof PluginExistsConstraint);
    if ($plugin_id === NULL) {
    ......
    ......@@ -19,7 +19,7 @@ class ComplexDataConstraintValidator extends ConstraintValidator {
    /**
    * {@inheritdoc}
    */
    public function validate($data, Constraint $constraint) {
    public function validate($data, Constraint $constraint): void {
    // If un-wrapped data has been passed, fetch the typed data object first.
    if (!$data instanceof TypedDataInterface) {
    ......
    ......@@ -37,7 +37,7 @@ public static function create(ContainerInterface $container) {
    /**
    * {@inheritdoc}
    */
    public function validate($value, Constraint $constraint) {
    public function validate($value, Constraint $constraint): void {
    assert($constraint instanceof EntityBundleExistsConstraint);
    if (!is_string($value)) {
    ......
    ......@@ -17,7 +17,7 @@ final class FullyValidatableConstraintValidator extends ConstraintValidator {
    /**
    * {@inheritdoc}
    */
    public function validate(mixed $value, Constraint $constraint) {
    public function validate(mixed $value, Constraint $constraint): void {
    // No-op.
    }
    ......
    ......@@ -38,7 +38,7 @@ public static function create(ContainerInterface $container) {
    /**
    * {@inheritdoc}
    */
    public function validate($items, Constraint $constraint) {
    public function validate($items, Constraint $constraint): void {
    if (!$items->first()) {
    return;
    }
    ......
    ......@@ -20,7 +20,7 @@ class ValidKeysConstraintValidator extends ConstraintValidator {
    /**
    * {@inheritdoc}
    */
    public function validate(mixed $value, Constraint $constraint) {
    public function validate(mixed $value, Constraint $constraint): void {
    assert($constraint instanceof ValidKeysConstraint);
    if (!is_array($value)) {
    ......
    ......@@ -14,7 +14,7 @@ class BlockContentEntityChangedConstraintValidator extends EntityChangedConstrai
    /**
    * {@inheritdoc}
    */
    public function validate($entity, Constraint $constraint) {
    public function validate($entity, Constraint $constraint): void {
    // This prevents saving an update to the block via a host entity's form if
    // the host entity has had other changes made via the API instead of the
    // entity form, such as a revision revert. This is safe, for example, in the
    ......
    ......@@ -42,7 +42,7 @@ public static function create(ContainerInterface $container) {
    /**
    * {@inheritdoc}
    */
    public function validate($entity, Constraint $constraint) {
    public function validate($entity, Constraint $constraint): void {
    if (isset($entity) && !$entity->isNew() && !$entity->isDefaultRevision()) {
    /** @var \Drupal\Core\Entity\ContentEntityInterface $original */
    $original = $this->bookManager->loadBookLink($entity->id(), FALSE) ?: [
    ......
    ......@@ -21,7 +21,7 @@ class CKEditor5ElementConstraintValidator extends ConstraintValidator {
    * @throws \Symfony\Component\Validator\Exception\UnexpectedTypeException
    * Thrown when the given constraint is not supported by this validator.
    */
    public function validate($element, $constraint) {
    public function validate($element, $constraint): void {
    if (!$constraint instanceof CKEditor5ElementConstraint) {
    throw new UnexpectedTypeException($constraint, __NAMESPACE__ . '\CKEditor5Element');
    }
    ......
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Please to comment